All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] x86/paravirt: Cleanup native_patch()
Date: Mon, 10 Sep 2018 10:33:16 +0200	[thread overview]
Message-ID: <dfe856d6-a4db-b406-ef18-dba3b6b8c342@suse.com> (raw)
In-Reply-To: <20180910070108.GA21406@zn.tnic>

On 10/09/18 09:01, Borislav Petkov wrote:
> On Mon, Sep 10, 2018 at 08:54:12AM +0200, Juergen Gross wrote:
>>> +	case PARAVIRT_PATCH(lock.queued_spin_unlock):
>>> +		if (pv_is_native_spin_unlock())
>>> +			return paravirt_patch_insns(ibuf, len,
>>> +						    start_lock_queued_spin_unlock,
>>> +						    end_lock_queued_spin_unlock);
>>> +		else
>>> +			return paravirt_patch_default(type, ibuf, addr, len);
>>
>> Why not replace the else clause by a "break;" and ...
> 
> Because I think that exiting right then and there is much easier to
> follow than adding all those breaks and wading through ifdeffery
> to realize that this is the default path and we'll end up calling
> paravirt_patch_default() in the end.
> 

Really? All of the remaining coding would fit easily on one screen. No
hidden breaks anywhere and no deep nesting involved. And the ifdefs
hardly makes it more difficult to understand, as they are not even
nested.


Juergen

  parent reply	other threads:[~2018-09-10  8:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 10:49 [PATCH] x86/paravirt: Get rid of patch_site label Borislav Petkov
2018-09-07 10:51 ` Borislav Petkov
2018-09-07 20:10   ` [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels Borislav Petkov
2018-09-08  5:45     ` Juergen Gross
2018-09-08  5:45       ` Juergen Gross
2018-09-08 15:28       ` [PATCH] x86/paravirt: Cleanup native_patch() Borislav Petkov
2018-09-08 15:28         ` Borislav Petkov
2018-09-10  6:54         ` Juergen Gross
2018-09-10  7:01           ` Borislav Petkov
2018-09-10  7:01           ` Borislav Petkov
2018-09-10  8:33             ` Juergen Gross
2018-09-10  8:33             ` Juergen Gross [this message]
2018-09-11  9:15               ` [PATCH v2] " Borislav Petkov
2018-09-11  9:44                 ` Juergen Gross
2018-09-11  9:44                 ` Juergen Gross
2018-09-11 15:34                 ` [tip:x86/paravirt] x86/paravirt: Clean up native_patch() tip-bot for Borislav Petkov
2018-09-11  9:15               ` [PATCH v2] x86/paravirt: Cleanup native_patch() Borislav Petkov
2018-09-10  6:54         ` [PATCH] " Juergen Gross
2018-09-07 20:10   ` [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels Borislav Petkov
2018-09-07 10:51 ` [PATCH] x86/paravirt: Get rid of patch_site label Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfe856d6-a4db-b406-ef18-dba3b6b8c342@suse.com \
    --to=jgross@suse.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.