* [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
@ 2019-09-05 11:33 Thomas Huth
2019-09-05 11:41 ` Philippe Mathieu-Daudé
2019-09-05 12:07 ` Greg Kurz
0 siblings, 2 replies; 7+ messages in thread
From: Thomas Huth @ 2019-09-05 11:33 UTC (permalink / raw)
To: qemu-devel, Alex Bennée, Fam Zheng
Cc: Philippe Mathieu-Daudé, Greg Kurz
So far we were not testing virtio-9p in Travis yet, since we forgot to
install libcap-devel. Do it now to get some more test coverage.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.travis.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.travis.yml b/.travis.yml
index 92b00927d4..1d46442020 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,6 +15,7 @@ addons:
- libaio-dev
- libattr1-dev
- libbrlapi-dev
+ - libcap-dev
- libcap-ng-dev
- libgcc-4.8-dev
- libgnutls-dev
--
2.18.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-05 11:33 [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p Thomas Huth
@ 2019-09-05 11:41 ` Philippe Mathieu-Daudé
2019-09-05 12:07 ` Greg Kurz
1 sibling, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-05 11:41 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Alex Bennée, Fam Zheng; +Cc: Greg Kurz
"virito-9p" -> "virtio-9p" in subject
On 9/5/19 1:33 PM, Thomas Huth wrote:
> So far we were not testing virtio-9p in Travis yet, since we forgot to
> install libcap-devel. Do it now to get some more test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .travis.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 92b00927d4..1d46442020 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,6 +15,7 @@ addons:
> - libaio-dev
> - libattr1-dev
> - libbrlapi-dev
> + - libcap-dev
> - libcap-ng-dev
> - libgcc-4.8-dev
> - libgnutls-dev
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-05 11:33 [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p Thomas Huth
2019-09-05 11:41 ` Philippe Mathieu-Daudé
@ 2019-09-05 12:07 ` Greg Kurz
2019-09-05 12:18 ` Greg Kurz
2019-09-06 11:25 ` Thomas Huth
1 sibling, 2 replies; 7+ messages in thread
From: Greg Kurz @ 2019-09-05 12:07 UTC (permalink / raw)
To: Thomas Huth
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée, qemu-devel
On Thu, 5 Sep 2019 13:33:46 +0200
Thomas Huth <thuth@redhat.com> wrote:
> So far we were not testing virtio-9p in Travis yet, since we forgot to
> install libcap-devel. Do it now to get some more test coverage.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
Acked-by: Greg Kurz <groug@kaod.org>
and
Tested-by: Greg Kurz <groug@kaod.org>
Whose tree is this going through BTW ?
> .travis.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 92b00927d4..1d46442020 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,6 +15,7 @@ addons:
> - libaio-dev
> - libattr1-dev
> - libbrlapi-dev
> + - libcap-dev
> - libcap-ng-dev
> - libgcc-4.8-dev
> - libgnutls-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-05 12:07 ` Greg Kurz
@ 2019-09-05 12:18 ` Greg Kurz
2019-09-06 11:22 ` Thomas Huth
2019-09-06 11:25 ` Thomas Huth
1 sibling, 1 reply; 7+ messages in thread
From: Greg Kurz @ 2019-09-05 12:18 UTC (permalink / raw)
To: Thomas Huth
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée, qemu-devel
On Thu, 5 Sep 2019 14:07:01 +0200
Greg Kurz <groug@kaod.org> wrote:
> On Thu, 5 Sep 2019 13:33:46 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
> > So far we were not testing virtio-9p in Travis yet, since we forgot to
> > install libcap-devel. Do it now to get some more test coverage.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
>
> Acked-by: Greg Kurz <groug@kaod.org>
>
Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
section as well, near line 260 ?
> and
>
> Tested-by: Greg Kurz <groug@kaod.org>
>
> Whose tree is this going through BTW ?
>
> > .travis.yml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 92b00927d4..1d46442020 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -15,6 +15,7 @@ addons:
> > - libaio-dev
> > - libattr1-dev
> > - libbrlapi-dev
> > + - libcap-dev
> > - libcap-ng-dev
> > - libgcc-4.8-dev
> > - libgnutls-dev
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-05 12:18 ` Greg Kurz
@ 2019-09-06 11:22 ` Thomas Huth
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2019-09-06 11:22 UTC (permalink / raw)
To: Greg Kurz
Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée, qemu-devel
On 05/09/2019 14.18, Greg Kurz wrote:
> On Thu, 5 Sep 2019 14:07:01 +0200
> Greg Kurz <groug@kaod.org> wrote:
>
>> On Thu, 5 Sep 2019 13:33:46 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>>> install libcap-devel. Do it now to get some more test coverage.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>
>> Acked-by: Greg Kurz <groug@kaod.org>
>>
>
> Hmm... shouldn't libcap-dev be added in the "Acceptance (Functional) tests"
> section as well, near line 260 ?
Unless there is a test for 9p in the "check-acceptance" suite, it likely
does not make a difference - 9p would just get built one more additional
time, but it won't be tested afterwards.
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-05 12:07 ` Greg Kurz
2019-09-05 12:18 ` Greg Kurz
@ 2019-09-06 11:25 ` Thomas Huth
2019-09-06 12:05 ` Alex Bennée
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Huth @ 2019-09-06 11:25 UTC (permalink / raw)
To: Greg Kurz, Alex Bennée
Cc: Fam Zheng, qemu-trivial, Philippe Mathieu-Daudé, qemu-devel
On 05/09/2019 14.07, Greg Kurz wrote:
> On Thu, 5 Sep 2019 13:33:46 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>> install libcap-devel. Do it now to get some more test coverage.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>
> Acked-by: Greg Kurz <groug@kaod.org>
>
> and
>
> Tested-by: Greg Kurz <groug@kaod.org>
>
> Whose tree is this going through BTW ?
According to MAINTAINERS, .travis.yml is taken care of by Alex and Fam,
so I hope they will pick this patch up. Otherwise, I think it could also
go via trivial (now on CC: ), since it's just a one-liner.
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p
2019-09-06 11:25 ` Thomas Huth
@ 2019-09-06 12:05 ` Alex Bennée
0 siblings, 0 replies; 7+ messages in thread
From: Alex Bennée @ 2019-09-06 12:05 UTC (permalink / raw)
To: Thomas Huth
Cc: Fam Zheng, qemu-trivial, Philippe Mathieu-Daudé,
Greg Kurz, qemu-devel
Thomas Huth <thuth@redhat.com> writes:
> On 05/09/2019 14.07, Greg Kurz wrote:
>> On Thu, 5 Sep 2019 13:33:46 +0200
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> So far we were not testing virtio-9p in Travis yet, since we forgot to
>>> install libcap-devel. Do it now to get some more test coverage.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>
>> Acked-by: Greg Kurz <groug@kaod.org>
>>
>> and
>>
>> Tested-by: Greg Kurz <groug@kaod.org>
>>
>> Whose tree is this going through BTW ?
>
> According to MAINTAINERS, .travis.yml is taken care of by Alex and Fam,
> so I hope they will pick this patch up. Otherwise, I think it could also
> go via trivial (now on CC: ), since it's just a one-liner.
Sure I'll grab it for the next iteration of testing/next - the queue is
quite full at the moment.
--
Alex Bennée
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-06 12:06 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 11:33 [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p Thomas Huth
2019-09-05 11:41 ` Philippe Mathieu-Daudé
2019-09-05 12:07 ` Greg Kurz
2019-09-05 12:18 ` Greg Kurz
2019-09-06 11:22 ` Thomas Huth
2019-09-06 11:25 ` Thomas Huth
2019-09-06 12:05 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.