From: "Ivan T. Ivanov" <iivanov@suse.de>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: Add nvmem node for BCM2711 bootloader public key
Date: Thu, 13 Apr 2023 21:18:30 +0300 [thread overview]
Message-ID: <duuhz5pju4q7lnvzwndcnruqwqzbwy4jhrfn42vov2rfct4i7c@qh55cifhoud7> (raw)
In-Reply-To: <9b03551a-278d-16dc-08ed-1ef0f89dc79c@i2se.com>
On 04-13 18:15, Stefan Wahren wrote:
>
> Hi Ivan,
>
> Am 13.04.23 um 10:52 schrieb Ivan T. Ivanov:
> > From: Tim Gover <tim.gover@raspberrypi.com>
> >
> > Make a copy of the bootloader secure-boot public key available to the OS
> > via an nvmem node. The placement information is populated by the
> > Raspberry Pi firmware if a public key is present in the BCM2711
> > bootloader EEPROM.
>
> It would be nice to have a helpful link like:
> https://www.raspberrypi.com/documentation/computers/configuration.html#nvmem-nodes
Yep, make sense.
> > +
> > + /*
> > + * RPi4 will copy the binary public key blob (if present) from the bootloader
> > + * into memory for use by the OS.
> > + */
> > + blpubkey: nvram@1 {
> > + compatible = "raspberrypi,bootloader-public-key", "nvmem-rmem";
>
> Yes this looks better, but this introduce a new dtbs_check issue. The new
Oops, yes, I forgot to make this check.
> compatible must be documented in
> Documentation/devicetree/bindings/nvmem/rmem.yaml in a separate patch and
> reviewed by the DT guys.
Or I can drop the new compatible string altogether? It looks like
only alias is strictly required?! Tim Gover is this correct?
Regards,
Ivan
next prev parent reply other threads:[~2023-04-13 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 8:52 [PATCH v2 0/2] nvmem: rmem: Make reserved region name unique Ivan T. Ivanov
2023-04-13 8:52 ` [PATCH v2 1/2] nvmem: rmem: Use NVMEM_DEVID_AUTO Ivan T. Ivanov
2023-04-13 8:52 ` [PATCH v2 2/2] ARM: dts: Add nvmem node for BCM2711 bootloader public key Ivan T. Ivanov
2023-04-13 16:15 ` Stefan Wahren
2023-04-13 18:18 ` Ivan T. Ivanov [this message]
2023-04-13 18:44 ` Stefan Wahren
2023-04-13 19:28 ` Tim Gover
2023-04-16 13:11 ` Stefan Wahren
2023-04-18 8:49 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=duuhz5pju4q7lnvzwndcnruqwqzbwy4jhrfn42vov2rfct4i7c@qh55cifhoud7 \
--to=iivanov@suse.de \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stefan.wahren@i2se.com \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.