All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] some cleanups and fixes
@ 2017-01-18  2:40 Monk Liu
       [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Monk Liu @ 2017-01-18  2:40 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu

Monk Liu (3):
  drm/amdgpu:set cond_exec polling value to 1 in ring_init
  drm/amdgpu:Preamble is forbid to be ignored in SRIOV
  drm/amdgpu:insert switch buffer only for VM submit

 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c   | 8 +++-----
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 +++-
 2 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] drm/amdgpu:set cond_exec polling value to 1 in ring_init
       [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
@ 2017-01-18  2:40   ` Monk Liu
  2017-01-18  2:40   ` [PATCH 2/3] drm/amdgpu:Preamble is forbid to be ignored in SRIOV Monk Liu
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Monk Liu @ 2017-01-18  2:40 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu

no need to set it per ib_schedule(), hw won't override
this polling address.

Change-Id: Ie27a36f187f7db26239c016315cd2dee482387b5
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c   | 3 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 +++-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
index 6939822..bcd5142 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -175,9 +175,6 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
 	if (ring->funcs->emit_hdp_flush)
 		amdgpu_ring_emit_hdp_flush(ring);
 
-	/* always set cond_exec_polling to CONTINUE */
-	*ring->cond_exe_cpu_addr = 1;
-
 	skip_preamble = ring->current_ctx == fence_ctx;
 	need_ctx_switch = ring->current_ctx != fence_ctx;
 	if (job && ring->funcs->emit_cntxcntl) {
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
index 4c99282..7bacf3c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
@@ -207,6 +207,8 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
 	}
 	ring->cond_exe_gpu_addr = adev->wb.gpu_addr + (ring->cond_exe_offs * 4);
 	ring->cond_exe_cpu_addr = &adev->wb.wb[ring->cond_exe_offs];
+	/* always set cond_exec_polling to CONTINUE */
+	*ring->cond_exe_cpu_addr = 1;
 
 	r = amdgpu_fence_driver_start_ring(ring, irq_src, irq_type);
 	if (r) {
@@ -307,7 +309,7 @@ static ssize_t amdgpu_debugfs_ring_read(struct file *f, char __user *buf,
 	while (size) {
 		if (*pos >= (ring->ring_size + 12))
 			return result;
-			
+
 		value = ring->ring[(*pos - 12)/4];
 		r = put_user(value, (uint32_t*)buf);
 		if (r)
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] drm/amdgpu:Preamble is forbid to be ignored in SRIOV
       [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
  2017-01-18  2:40   ` [PATCH 1/3] drm/amdgpu:set cond_exec polling value to 1 in ring_init Monk Liu
@ 2017-01-18  2:40   ` Monk Liu
  2017-01-18  2:40   ` [PATCH 3/3] drm/amdgpu:insert switch buffer only for VM submit Monk Liu
  2017-01-18  9:20   ` [PATCH 0/3] some cleanups and fixes Christian König
  3 siblings, 0 replies; 7+ messages in thread
From: Monk Liu @ 2017-01-18  2:40 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu

Change-Id: I6da941fa22cfaee43d6dc11191b1fb7482e7362b
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
index bcd5142..7552326 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -193,7 +193,8 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
 		/* drop preamble IBs if we don't have a context switch */
 		if ((ib->flags & AMDGPU_IB_FLAG_PREAMBLE) &&
 			skip_preamble &&
-			!(status & AMDGPU_PREAMBLE_IB_PRESENT_FIRST))
+			!(status & AMDGPU_PREAMBLE_IB_PRESENT_FIRST) &&
+			!amdgpu_sriov_vf(adev)) /* for SRIOV preemption, Preamble CE ib must be inserted anyway */
 			continue;
 
 		amdgpu_ring_emit_ib(ring, ib, job ? job->vm_id : 0,
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] drm/amdgpu:insert switch buffer only for VM submit
       [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
  2017-01-18  2:40   ` [PATCH 1/3] drm/amdgpu:set cond_exec polling value to 1 in ring_init Monk Liu
  2017-01-18  2:40   ` [PATCH 2/3] drm/amdgpu:Preamble is forbid to be ignored in SRIOV Monk Liu
@ 2017-01-18  2:40   ` Monk Liu
  2017-01-18  9:20   ` [PATCH 0/3] some cleanups and fixes Christian König
  3 siblings, 0 replies; 7+ messages in thread
From: Monk Liu @ 2017-01-18  2:40 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu

for non-VM submit which is from kernel side, no need
to switch buffer at all.

Change-Id: I55c993e6111a7c438a6bc94b36aabdab9ed5f4bd
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
index 7552326..12300c3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
@@ -224,7 +224,7 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
 		amdgpu_ring_patch_cond_exec(ring, patch_offset);
 
 	ring->current_ctx = fence_ctx;
-	if (ring->funcs->emit_switch_buffer)
+	if (vm && ring->funcs->emit_switch_buffer)
 		amdgpu_ring_emit_switch_buffer(ring);
 	amdgpu_ring_commit(ring);
 	return 0;
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/3] some cleanups and fixes
       [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
                     ` (2 preceding siblings ...)
  2017-01-18  2:40   ` [PATCH 3/3] drm/amdgpu:insert switch buffer only for VM submit Monk Liu
@ 2017-01-18  9:20   ` Christian König
  3 siblings, 0 replies; 7+ messages in thread
From: Christian König @ 2017-01-18  9:20 UTC (permalink / raw)
  To: Monk Liu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW

Reviewed-by: Christian König <christian.koenig@amd.com> for the series.

Regards,
Christian.

Am 18.01.2017 um 03:40 schrieb Monk Liu:
> Monk Liu (3):
>    drm/amdgpu:set cond_exec polling value to 1 in ring_init
>    drm/amdgpu:Preamble is forbid to be ignored in SRIOV
>    drm/amdgpu:insert switch buffer only for VM submit
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c   | 8 +++-----
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 +++-
>   2 files changed, 6 insertions(+), 6 deletions(-)
>

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 0/3] Some cleanups and fixes
@ 2023-12-14 16:38 ` Yuntao Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Yuntao Wang @ 2023-12-14 16:38 UTC (permalink / raw)
  To: linux-kernel, kexec, x86
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
	H. Peter Anvin, Baoquan He, Vivek Goyal, Dave Young,
	Hari Bathini, Eric DeVolder, Andrew Morton, Sourabh Jain,
	Sean Christopherson, Takashi Iwai, Lianbo Jiang, Yuntao Wang

This series includes two cleanups and one fix.

Yuntao Wang (3):
  x86/crash: remove the unused image parameter from
    prepare_elf_headers()
  x86/crash: use SZ_1M macro instead of hardcoded value
  crash_core: fix and simplify the logic of crash_exclude_mem_range()

 arch/x86/kernel/crash.c | 12 +++----
 kernel/crash_core.c     | 70 +++++++++++------------------------------
 2 files changed, 25 insertions(+), 57 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 0/3] Some cleanups and fixes
@ 2023-12-14 16:38 ` Yuntao Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Yuntao Wang @ 2023-12-14 16:38 UTC (permalink / raw)
  To: linux-kernel, kexec, x86
  Cc: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
	H. Peter Anvin, Baoquan He, Vivek Goyal, Dave Young,
	Hari Bathini, Eric DeVolder, Andrew Morton, Sourabh Jain,
	Sean Christopherson, Takashi Iwai, Lianbo Jiang, Yuntao Wang

This series includes two cleanups and one fix.

Yuntao Wang (3):
  x86/crash: remove the unused image parameter from
    prepare_elf_headers()
  x86/crash: use SZ_1M macro instead of hardcoded value
  crash_core: fix and simplify the logic of crash_exclude_mem_range()

 arch/x86/kernel/crash.c | 12 +++----
 kernel/crash_core.c     | 70 +++++++++++------------------------------
 2 files changed, 25 insertions(+), 57 deletions(-)

-- 
2.43.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-14 16:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-18  2:40 [PATCH 0/3] some cleanups and fixes Monk Liu
     [not found] ` <1484707233-29838-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org>
2017-01-18  2:40   ` [PATCH 1/3] drm/amdgpu:set cond_exec polling value to 1 in ring_init Monk Liu
2017-01-18  2:40   ` [PATCH 2/3] drm/amdgpu:Preamble is forbid to be ignored in SRIOV Monk Liu
2017-01-18  2:40   ` [PATCH 3/3] drm/amdgpu:insert switch buffer only for VM submit Monk Liu
2017-01-18  9:20   ` [PATCH 0/3] some cleanups and fixes Christian König
2023-12-14 16:38 [PATCH 0/3] Some " Yuntao Wang
2023-12-14 16:38 ` Yuntao Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.