From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D369C433EF for ; Thu, 16 Sep 2021 08:26:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E160961209 for ; Thu, 16 Sep 2021 08:26:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234928AbhIPI1k (ORCPT ); Thu, 16 Sep 2021 04:27:40 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:19986 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234904AbhIPI1j (ORCPT ); Thu, 16 Sep 2021 04:27:39 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H996q084QzbmXv; Thu, 16 Sep 2021 16:22:11 +0800 (CST) Received: from dggpemm100004.china.huawei.com (7.185.36.189) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:17 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100004.china.huawei.com (7.185.36.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:16 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2308.008; Thu, 16 Sep 2021 09:26:14 +0100 From: Shameerali Kolothum Thodi To: Jon Nettleton CC: Robin Murphy , Lorenzo Pieralisi , Laurentiu Tudor , linux-arm-kernel , "ACPI Devel Maling List" , Linux IOMMU , Joerg Roedel , "Will Deacon" , wanghuiqiang , "Guohanjun (Hanjun Guo)" , Steven Price , Sami Mujawar , Eric Auger , yangyicong Subject: RE: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Topic: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Index: AQHXidEiKr58723PTUGGkSglF1QKPatlAmqAgDJmwoCAACN+gIAO55oggAAG1QCAABhrQA== Date: Thu, 16 Sep 2021 08:26:14 +0000 Message-ID: References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-3-shameerali.kolothum.thodi@huawei.com> <20210805160319.GB23085@lpieralisi> <5d9bebdf-6eb5-49a0-2e8f-490df2d6754d@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.83.177] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSm9uIE5ldHRsZXRvbiBb bWFpbHRvOmpvbkBzb2xpZC1ydW4uY29tXQ0KPiBTZW50OiAxNiBTZXB0ZW1iZXIgMjAyMSAwODo1 Mg0KPiBUbzogU2hhbWVlcmFsaSBLb2xvdGh1bSBUaG9kaSA8c2hhbWVlcmFsaS5rb2xvdGh1bS50 aG9kaUBodWF3ZWkuY29tPg0KPiBDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNv bT47IExvcmVuem8gUGllcmFsaXNpDQo+IDxsb3JlbnpvLnBpZXJhbGlzaUBhcm0uY29tPjsgTGF1 cmVudGl1IFR1ZG9yIDxsYXVyZW50aXUudHVkb3JAbnhwLmNvbT47DQo+IGxpbnV4LWFybS1rZXJu ZWwgPGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz47IEFDUEkgRGV2ZWwgTWFs aW5nDQo+IExpc3QgPGxpbnV4LWFjcGlAdmdlci5rZXJuZWwub3JnPjsgTGludXggSU9NTVUNCj4g PGlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnPjsgSm9lcmcgUm9lZGVsIDxqb3JvQDhi eXRlcy5vcmc+OyBXaWxsDQo+IERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPjsgd2FuZ2h1aXFpYW5n IDx3YW5naHVpcWlhbmdAaHVhd2VpLmNvbT47DQo+IEd1b2hhbmp1biAoSGFuanVuIEd1bykgPGd1 b2hhbmp1bkBodWF3ZWkuY29tPjsgU3RldmVuIFByaWNlDQo+IDxzdGV2ZW4ucHJpY2VAYXJtLmNv bT47IFNhbWkgTXVqYXdhciA8U2FtaS5NdWphd2FyQGFybS5jb20+OyBFcmljDQo+IEF1Z2VyIDxl cmljLmF1Z2VyQHJlZGhhdC5jb20+OyB5YW5neWljb25nIDx5YW5neWljb25nQGh1YXdlaS5jb20+ DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjcgMi85XSBBQ1BJL0lPUlQ6IEFkZCBzdXBwb3J0IGZv ciBSTVIgbm9kZSBwYXJzaW5nDQo+IA0KPiBPbiBUaHUsIFNlcCAxNiwgMjAyMSBhdCA5OjI2IEFN IFNoYW1lZXJhbGkgS29sb3RodW0gVGhvZGkNCj4gPHNoYW1lZXJhbGkua29sb3RodW0udGhvZGlA aHVhd2VpLmNvbT4gd3JvdGU6DQo+ID4NCj4gPg0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogSm9uIE5ldHRsZXRvbiBbbWFpbHRvOmpvbkBzb2xpZC1y dW4uY29tXQ0KPiA+ID4gU2VudDogMDYgU2VwdGVtYmVyIDIwMjEgMjA6NTENCj4gPiA+IFRvOiBS b2JpbiBNdXJwaHkgPHJvYmluLm11cnBoeUBhcm0uY29tPg0KPiA+ID4gQ2M6IExvcmVuem8gUGll cmFsaXNpIDxsb3JlbnpvLnBpZXJhbGlzaUBhcm0uY29tPjsgU2hhbWVlcmFsaQ0KPiA+ID4gS29s b3RodW0gVGhvZGkgPHNoYW1lZXJhbGkua29sb3RodW0udGhvZGlAaHVhd2VpLmNvbT47IExhdXJl bnRpdQ0KPiA+ID4gVHVkb3IgPGxhdXJlbnRpdS50dWRvckBueHAuY29tPjsgbGludXgtYXJtLWtl cm5lbA0KPiA+ID4gPGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz47IEFDUEkg RGV2ZWwgTWFsaW5nIExpc3QNCj4gPiA+IDxsaW51eC1hY3BpQHZnZXIua2VybmVsLm9yZz47IExp bnV4IElPTU1VDQo+ID4gPiA8aW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmc+OyBMaW51 eGFybSA8bGludXhhcm1AaHVhd2VpLmNvbT47DQo+ID4gPiBKb2VyZyBSb2VkZWwgPGpvcm9AOGJ5 dGVzLm9yZz47IFdpbGwgRGVhY29uIDx3aWxsQGtlcm5lbC5vcmc+Ow0KPiA+ID4gd2FuZ2h1aXFp YW5nIDx3YW5naHVpcWlhbmdAaHVhd2VpLmNvbT47IEd1b2hhbmp1biAoSGFuanVuIEd1bykNCj4g PiA+IDxndW9oYW5qdW5AaHVhd2VpLmNvbT47IFN0ZXZlbiBQcmljZSA8c3RldmVuLnByaWNlQGFy bS5jb20+OyBTYW1pDQo+ID4gPiBNdWphd2FyIDxTYW1pLk11amF3YXJAYXJtLmNvbT47IEVyaWMg QXVnZXINCj4gPGVyaWMuYXVnZXJAcmVkaGF0LmNvbT47DQo+ID4gPiB5YW5neWljb25nIDx5YW5n eWljb25nQGh1YXdlaS5jb20+DQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHY3IDIvOV0gQUNQ SS9JT1JUOiBBZGQgc3VwcG9ydCBmb3IgUk1SIG5vZGUNCj4gPiA+IHBhcnNpbmcNCj4gPiA+DQo+ ID4gWy4uLl0NCj4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gT24gdGhlIHByb3QgdmFsdWUgYXNz aWdubWVudCBiYXNlZCBvbiB0aGUgcmVtYXBwaW5nIGZsYWcsIEknZA0KPiA+ID4gPiA+IGxpa2Ug dG8gaGVhciBSb2Jpbi9Kb2VyZydzIG9waW5pb24sIEknZCBhdm9pZCBiZWluZyBpbiBhDQo+ID4g PiA+ID4gc2l0dWF0aW9uIHdoZXJlICJub3JtYWxseSIgdGhpcyB3b3VsZCB3b3JrIGJ1dCB0aGVu IHdlIGhhdmUgdG8gcXVpcmsNCj4gaXQuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBJcyB0aGlzIGEg dmFsaWQgYXNzdW1wdGlvbiBfYWx3YXlzXyA/DQo+ID4gPiA+DQo+ID4gPiA+IE5vLiBDZXJ0YWlu bHkgYXBwbHlpbmcgSU9NTVVfQ0FDSEUgd2l0aG91dCByZWZlcmVuY2UgdG8gdGhlDQo+ID4gPiA+ IGRldmljZSdzIF9DQ0EgYXR0cmlidXRlIG9yIGhvdyBDUFVzIG1heSBiZSBhY2Nlc3NpbmcgYSBz aGFyZWQNCj4gPiA+ID4gYnVmZmVyIGNvdWxkIGxlYWQgdG8gYSBsb3NzIG9mIGNvaGVyZW5jeS4g QXQgd29yc3QsIGFwcGx5aW5nDQo+ID4gPiA+IElPTU1VX01NSU8gdG8gYSBkZXZpY2UtcHJpdmF0 ZSBidWZmZXIgKmNvdWxkKiBjYXVzZSB0aGUgZGV2aWNlIHRvDQo+ID4gPiA+IGxvc2UgY29oZXJl bmN5IHdpdGggaXRzZWxmIGlmIHRoZSBtZW1vcnkgdW5kZXJseWluZyB0aGUgUk1SIG1heQ0KPiA+ ID4gPiBoYXZlIGFsbG9jYXRlZCBpbnRvIHN5c3RlbSBjYWNoZXMuIE5vdGUgdGhhdCB0aGUgZXhw ZWN0ZWQgdXNlIGZvcg0KPiA+ID4gPiBub24tcmVtYXBwYWJsZSBSTVJzIGlzIHRoZSBkZXZpY2Ug aG9sZGluZyBzb21lIHNvcnQgb2YgbG9uZy1saXZlZA0KPiA+ID4gPiBwcml2YXRlIGRhdGEgaW4g c3lzdGVtIFJBTSAtIHRoZSBNU0kgZG9vcmJlbGwgdHJpY2sgaXMgZmFyIG1vcmUgb2YgYSBuaWNo ZQ0KPiBoYWNrIHJlYWxseS4NCj4gPiA+ID4NCj4gPiA+ID4gQXQgdGhlIHZlcnkgbGVhc3QgSSB0 aGluayB3ZSBuZWVkIHRvIHJlZmVyIHRvIHRoZSBkZXZpY2UncyBtZW1vcnkNCj4gPiA+ID4gYWNj ZXNzIHByb3BlcnRpZXMgaGVyZS4NCj4gPiA+ID4NCj4gPiA+ID4gSm9uLCBMYXVyZW50aXUgLSBo b3cgZG8gUk1ScyBjb3JyZXNwb25kIHRvIHRoZSBFRkkgbWVtb3J5IG1hcCBvbg0KPiA+ID4gPiB5 b3VyIGZpcm13YXJlPyBJJ20gc3RhcnRpbmcgdG8gdGhpbmsgdGhhdCBhcyBsb25nIGFzIHRoZQ0K PiA+ID4gPiB1bmRlcmx5aW5nIG1lbW9yeSBpcyBkZXNjcmliZWQgYXBwcm9wcmlhdGVseSB0aGVy ZSB0aGVuIHdlIHNob3VsZA0KPiA+ID4gPiBiZSBhYmxlIHRvIGluZmVyIGNvcnJlY3QgYXR0cmli dXRlcyBmcm9tIHRoZSBFRkkgbWVtb3J5IHR5cGUgYW5kIGZsYWdzLg0KPiA+ID4NCj4gPiA+IFRo ZSBkZXZpY2VzIGFyZSBhbGwgY2FjaGUgY29oZXJlbnQgYW5kIG1hcmtlZCBhcyBfQ0NBLCAxLiAg VGhlDQo+ID4gPiBNZW1vcnkgcmVnaW9ucyBhcmUgaW4gdGhlIHZpcnQgdGFibGUgYXMNCj4gQVJN X01FTU9SWV9SRUdJT05fQVRUUklCVVRFX0RFVklDRS4NCj4gPiA+DQo+ID4gPiBUaGUgY3VycmVu dCBjaGlja2VuIGFuZCBlZ2cgcHJvYmxlbSB3ZSBoYXZlIGlzIHRoYXQgZHVyaW5nIHRoZQ0KPiA+ ID4gZnNsLW1jLWJ1cyBpbml0aWFsaXphdGlvbiB3ZSBjYWxsDQo+ID4gPg0KPiA+ID4gZXJyb3Ig PSBhY3BpX2RtYV9jb25maWd1cmVfaWQoJnBkZXYtPmRldiwgREVWX0RNQV9DT0hFUkVOVCwNCj4g PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmbWNfc3Ry ZWFtX2lkKTsNCj4gPiA+DQo+ID4gPiB3aGljaCBnZXRzIGRlZmVycmVkIGJlY2F1c2UgdGhlIFNN TVUgaGFzIG5vdCBiZWVuIGluaXRpYWxpemVkIHlldC4NCj4gPiA+IFRoZW4gd2UgaW5pdGlhbGl6 ZSB0aGUgUk1SIHRhYmxlcyBidXQgdGhlcmUgaXMgbm8gZGV2aWNlIHJlZmVyZW5jZQ0KPiA+ID4g dGhlcmUgdG8gYmUgYWJsZSB0byBxdWVyeSBkZXZpY2UgcHJvcGVydGllcywgb25seSB0aGUgc3Ry ZWFtIGlkLg0KPiA+ID4gQWZ0ZXIgdGhlIElPUlQgdGFibGVzIGFyZSBwYXJzZWQgYW5kIHRoZSBT TU1VIGlzIHNldHVwLCBvbiB0aGUNCj4gPiA+IHNlY29uZCBkZXZpY2UgcHJvYmUgd2UgYXNzb2Np YXRlIGV2ZXJ5dGhpbmcgYmFzZWQgb24gdGhlIHN0cmVhbSBpZA0KPiA+ID4gYW5kIHRoZSBmc2wt bWMtYnVzIGRldmljZSBpcyBhYmxlIHRvIGNsYWltIGl0cyAxLTEgRE1BIG1hcHBpbmdzLg0KPiA+ DQo+ID4gQ2FuIHdlIHNvbHZlIHRoaXMgb3JkZXIgcHJvYmxlbSBieSBkZWxheWluZyB0aGUNCj4g PiBpb21tdV9hbGxvY19yZXN2X3JlZ2lvbigpIHRvIHRoZSBpb21tdV9kbWFfZ2V0X3Jtcl9yZXN2 X3JlZ2lvbnMoZGV2LA0KPiA+IGxpc3QpID8gV2UgY291bGQgaW52b2tlDQo+ID4gZGV2aWNlX2dl dF9kbWFfYXR0cigpIGZyb20gdGhlcmUgd2hpY2ggSSBiZWxpZXZlIHdpbGwgcmV0dXJuIHRoZSBf Q0NBDQo+IGF0dHJpYnV0ZS4NCj4gPg0KPiA+IE9yIGlzIHRoYXQgc3RpbGwgZWFybHkgdG8gaW52 b2tlIHRoYXQ/DQo+IA0KPiBUaGF0IGxvb2tzIGxpa2UgaXQgc2hvdWxkIHdvcmsuIERvIHdlIHRo ZW4gYWxzbyBuZWVkIHRvIHBhcnNlIHRocm91Z2ggdGhlDQo+IFZpcnR1YWxNZW1vcnlUYWJsZSBt YXRjaGluZyB0aGUgc3RhcnQgYW5kIGVuZCBhZGRyZXNzZXMgdG8gZGV0ZXJtaW5lIHRoZQ0KPiBv dGhlciBtZW1vcnkgYXR0cmlidXRlcyBsaWtlIE1NSU8/DQoNClllcy4gQnV0IHRoYXQgbG9va3Mg dHJpY2t5IGFzIEkgY2FuJ3QgZmluZCB0aGF0IHJlYWRpbHkgYXZhaWxhYmxlIG9uIEFybSwgbGlr ZSB0aGUNCmVmaV9tZW1fYXR0cmlidXRlcygpLiBJIHdpbGwgdGFrZSBhIGxvb2suDQoNClBsZWFz ZSBsZXQgbWUga25vdyBpZiB0aGVyZSBpcyBvbmUgb3IgYW55IG90aGVyIGVhc3kgd2F5IHRvIHJl dHJpZXZlIGl0Lg0KDQpUaGFua3MsDQpTaGFtZWVyDQoNCj4gDQo+IC1Kb24NCj4gDQo+ID4NCj4g PiBUaGFua3MsDQo+ID4gU2hhbWVlcg0KPiA+DQo+ID4gPiBjYXQgL3N5cy9rZXJuZWwvaW9tbXVf Z3JvdXBzLzAvcmVzZXJ2ZWRfcmVnaW9ucw0KPiA+ID4gMHgwMDAwMDAwMDAxMDAwMDAwIDB4MDAw MDAwMDAxMGZmZmZmZiBkaXJlY3QtcmVsYXhhYmxlDQo+ID4gPiAweDAwMDAwMDAwMDgwMDAwMDAg MHgwMDAwMDAwMDA4MGZmZmZmIG1zaQ0KPiA+ID4gMHgwMDAwMDAwODBjMDAwMDAwIDB4MDAwMDAw MDgxYmZmZmZmZiBkaXJlY3QtcmVsYXhhYmxlDQo+ID4gPiAweDAwMDAwMDFjMDAwMDAwMDAgMHgw MDAwMDAxYzAwMWZmZmZmIGRpcmVjdC1yZWxheGFibGUNCj4gPiA+IDB4MDAwMDAwMjA4MDAwMDAw MCAweDAwMDAwMDIwOWZmZmZmZmYgZGlyZWN0LXJlbGF4YWJsZQ0KPiA+ID4NCj4gPiA+IC1Kb24N Cj4gPiA+DQo+ID4gPiA+DQo+ID4gPiA+IFJvYmluLg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A8F4C433F5 for ; Thu, 16 Sep 2021 08:26:27 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F2E36113E for ; Thu, 16 Sep 2021 08:26:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F2E36113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E4B2F40755; Thu, 16 Sep 2021 08:26:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PjrCDjuOFcPZ; Thu, 16 Sep 2021 08:26:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 959CA406DF; Thu, 16 Sep 2021 08:26:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C3EBC0011; Thu, 16 Sep 2021 08:26:25 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E3FD4C000D for ; Thu, 16 Sep 2021 08:26:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id DFD67406E2 for ; Thu, 16 Sep 2021 08:26:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wgyMLnGbl2YC for ; Thu, 16 Sep 2021 08:26:22 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by smtp4.osuosl.org (Postfix) with ESMTPS id 07C14406DF for ; Thu, 16 Sep 2021 08:26:21 +0000 (UTC) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H996q084QzbmXv; Thu, 16 Sep 2021 16:22:11 +0800 (CST) Received: from dggpemm100004.china.huawei.com (7.185.36.189) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:17 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100004.china.huawei.com (7.185.36.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:16 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2308.008; Thu, 16 Sep 2021 09:26:14 +0100 From: Shameerali Kolothum Thodi To: Jon Nettleton Subject: RE: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Topic: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Index: AQHXidEiKr58723PTUGGkSglF1QKPatlAmqAgDJmwoCAACN+gIAO55oggAAG1QCAABhrQA== Date: Thu, 16 Sep 2021 08:26:14 +0000 Message-ID: References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-3-shameerali.kolothum.thodi@huawei.com> <20210805160319.GB23085@lpieralisi> <5d9bebdf-6eb5-49a0-2e8f-490df2d6754d@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.83.177] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: Will Deacon , Steven Price , ACPI Devel Maling List , Linux IOMMU , wanghuiqiang , "Guohanjun \(Hanjun Guo\)" , yangyicong , Sami Mujawar , Robin Murphy , linux-arm-kernel X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > -----Original Message----- > From: Jon Nettleton [mailto:jon@solid-run.com] > Sent: 16 September 2021 08:52 > To: Shameerali Kolothum Thodi > Cc: Robin Murphy ; Lorenzo Pieralisi > ; Laurentiu Tudor ; > linux-arm-kernel ; ACPI Devel Maling > List ; Linux IOMMU > ; Joerg Roedel ; Will > Deacon ; wanghuiqiang ; > Guohanjun (Hanjun Guo) ; Steven Price > ; Sami Mujawar ; Eric > Auger ; yangyicong > Subject: Re: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing > > On Thu, Sep 16, 2021 at 9:26 AM Shameerali Kolothum Thodi > wrote: > > > > > > > > > -----Original Message----- > > > From: Jon Nettleton [mailto:jon@solid-run.com] > > > Sent: 06 September 2021 20:51 > > > To: Robin Murphy > > > Cc: Lorenzo Pieralisi ; Shameerali > > > Kolothum Thodi ; Laurentiu > > > Tudor ; linux-arm-kernel > > > ; ACPI Devel Maling List > > > ; Linux IOMMU > > > ; Linuxarm ; > > > Joerg Roedel ; Will Deacon ; > > > wanghuiqiang ; Guohanjun (Hanjun Guo) > > > ; Steven Price ; Sami > > > Mujawar ; Eric Auger > ; > > > yangyicong > > > Subject: Re: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node > > > parsing > > > > > [...] > > > > > > > > > > > > On the prot value assignment based on the remapping flag, I'd > > > > > like to hear Robin/Joerg's opinion, I'd avoid being in a > > > > > situation where "normally" this would work but then we have to quirk > it. > > > > > > > > > > Is this a valid assumption _always_ ? > > > > > > > > No. Certainly applying IOMMU_CACHE without reference to the > > > > device's _CCA attribute or how CPUs may be accessing a shared > > > > buffer could lead to a loss of coherency. At worst, applying > > > > IOMMU_MMIO to a device-private buffer *could* cause the device to > > > > lose coherency with itself if the memory underlying the RMR may > > > > have allocated into system caches. Note that the expected use for > > > > non-remappable RMRs is the device holding some sort of long-lived > > > > private data in system RAM - the MSI doorbell trick is far more of a niche > hack really. > > > > > > > > At the very least I think we need to refer to the device's memory > > > > access properties here. > > > > > > > > Jon, Laurentiu - how do RMRs correspond to the EFI memory map on > > > > your firmware? I'm starting to think that as long as the > > > > underlying memory is described appropriately there then we should > > > > be able to infer correct attributes from the EFI memory type and flags. > > > > > > The devices are all cache coherent and marked as _CCA, 1. The > > > Memory regions are in the virt table as > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE. > > > > > > The current chicken and egg problem we have is that during the > > > fsl-mc-bus initialization we call > > > > > > error = acpi_dma_configure_id(&pdev->dev, DEV_DMA_COHERENT, > > > &mc_stream_id); > > > > > > which gets deferred because the SMMU has not been initialized yet. > > > Then we initialize the RMR tables but there is no device reference > > > there to be able to query device properties, only the stream id. > > > After the IORT tables are parsed and the SMMU is setup, on the > > > second device probe we associate everything based on the stream id > > > and the fsl-mc-bus device is able to claim its 1-1 DMA mappings. > > > > Can we solve this order problem by delaying the > > iommu_alloc_resv_region() to the iommu_dma_get_rmr_resv_regions(dev, > > list) ? We could invoke > > device_get_dma_attr() from there which I believe will return the _CCA > attribute. > > > > Or is that still early to invoke that? > > That looks like it should work. Do we then also need to parse through the > VirtualMemoryTable matching the start and end addresses to determine the > other memory attributes like MMIO? Yes. But that looks tricky as I can't find that readily available on Arm, like the efi_mem_attributes(). I will take a look. Please let me know if there is one or any other easy way to retrieve it. Thanks, Shameer > > -Jon > > > > > Thanks, > > Shameer > > > > > cat /sys/kernel/iommu_groups/0/reserved_regions > > > 0x0000000001000000 0x0000000010ffffff direct-relaxable > > > 0x0000000008000000 0x00000000080fffff msi > > > 0x000000080c000000 0x000000081bffffff direct-relaxable > > > 0x0000001c00000000 0x0000001c001fffff direct-relaxable > > > 0x0000002080000000 0x000000209fffffff direct-relaxable > > > > > > -Jon > > > > > > > > > > > Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 449A2C433F5 for ; Thu, 16 Sep 2021 08:28:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECDF660F44 for ; Thu, 16 Sep 2021 08:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ECDF660F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tyUUvjBswAq82rsAAfeS5bZiyDE+cfmY9/iW9LNTjkQ=; b=WxxOhrsn4yQ8hM igFbEcCDXrXBSfGkOXq1kKqbAwtGgz+Cm9Qy16LQMx9lPzM6/chHn3odc0t76im7bDMYpKsC1vt90 6TIhHEviPbRbslWvk1miiOIXejdaDw70/nw0RxrAD7DG9KdLG9FtC011O/bJ4vbEORTw8IszUcnB5 zAfHmr4xvWgHwkwCqsaQrVXw06yUJ6HybZ2p770ITM5R5laY7tldqoW1OEldfi5Xkj7K0TI0RMG4F czGHg/DN3T9mXPzZLImq4pqnaFMT0ZWH5fxxuK/crOwHHd3umt4WMc0XSaIL52JjbQm8KCWwfGn3Z n6gKPEy8wAy82UAhye8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQmiz-00AYLp-Ue; Thu, 16 Sep 2021 08:26:30 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQmiv-00AYKv-6o for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 08:26:27 +0000 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H996q084QzbmXv; Thu, 16 Sep 2021 16:22:11 +0800 (CST) Received: from dggpemm100004.china.huawei.com (7.185.36.189) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:17 +0800 Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by dggpemm100004.china.huawei.com (7.185.36.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 16:26:16 +0800 Received: from lhreml710-chm.china.huawei.com ([169.254.81.184]) by lhreml710-chm.china.huawei.com ([169.254.81.184]) with mapi id 15.01.2308.008; Thu, 16 Sep 2021 09:26:14 +0100 From: Shameerali Kolothum Thodi To: Jon Nettleton CC: Robin Murphy , Lorenzo Pieralisi , Laurentiu Tudor , linux-arm-kernel , "ACPI Devel Maling List" , Linux IOMMU , Joerg Roedel , "Will Deacon" , wanghuiqiang , "Guohanjun (Hanjun Guo)" , Steven Price , Sami Mujawar , Eric Auger , yangyicong Subject: RE: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Topic: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Thread-Index: AQHXidEiKr58723PTUGGkSglF1QKPatlAmqAgDJmwoCAACN+gIAO55oggAAG1QCAABhrQA== Date: Thu, 16 Sep 2021 08:26:14 +0000 Message-ID: References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <20210805080724.480-3-shameerali.kolothum.thodi@huawei.com> <20210805160319.GB23085@lpieralisi> <5d9bebdf-6eb5-49a0-2e8f-490df2d6754d@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.83.177] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_012625_664434_8C54B7A3 X-CRM114-Status: GOOD ( 37.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Jon Nettleton [mailto:jon@solid-run.com] > Sent: 16 September 2021 08:52 > To: Shameerali Kolothum Thodi > Cc: Robin Murphy ; Lorenzo Pieralisi > ; Laurentiu Tudor ; > linux-arm-kernel ; ACPI Devel Maling > List ; Linux IOMMU > ; Joerg Roedel ; Will > Deacon ; wanghuiqiang ; > Guohanjun (Hanjun Guo) ; Steven Price > ; Sami Mujawar ; Eric > Auger ; yangyicong > Subject: Re: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing > > On Thu, Sep 16, 2021 at 9:26 AM Shameerali Kolothum Thodi > wrote: > > > > > > > > > -----Original Message----- > > > From: Jon Nettleton [mailto:jon@solid-run.com] > > > Sent: 06 September 2021 20:51 > > > To: Robin Murphy > > > Cc: Lorenzo Pieralisi ; Shameerali > > > Kolothum Thodi ; Laurentiu > > > Tudor ; linux-arm-kernel > > > ; ACPI Devel Maling List > > > ; Linux IOMMU > > > ; Linuxarm ; > > > Joerg Roedel ; Will Deacon ; > > > wanghuiqiang ; Guohanjun (Hanjun Guo) > > > ; Steven Price ; Sami > > > Mujawar ; Eric Auger > ; > > > yangyicong > > > Subject: Re: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node > > > parsing > > > > > [...] > > > > > > > > > > > > On the prot value assignment based on the remapping flag, I'd > > > > > like to hear Robin/Joerg's opinion, I'd avoid being in a > > > > > situation where "normally" this would work but then we have to quirk > it. > > > > > > > > > > Is this a valid assumption _always_ ? > > > > > > > > No. Certainly applying IOMMU_CACHE without reference to the > > > > device's _CCA attribute or how CPUs may be accessing a shared > > > > buffer could lead to a loss of coherency. At worst, applying > > > > IOMMU_MMIO to a device-private buffer *could* cause the device to > > > > lose coherency with itself if the memory underlying the RMR may > > > > have allocated into system caches. Note that the expected use for > > > > non-remappable RMRs is the device holding some sort of long-lived > > > > private data in system RAM - the MSI doorbell trick is far more of a niche > hack really. > > > > > > > > At the very least I think we need to refer to the device's memory > > > > access properties here. > > > > > > > > Jon, Laurentiu - how do RMRs correspond to the EFI memory map on > > > > your firmware? I'm starting to think that as long as the > > > > underlying memory is described appropriately there then we should > > > > be able to infer correct attributes from the EFI memory type and flags. > > > > > > The devices are all cache coherent and marked as _CCA, 1. The > > > Memory regions are in the virt table as > ARM_MEMORY_REGION_ATTRIBUTE_DEVICE. > > > > > > The current chicken and egg problem we have is that during the > > > fsl-mc-bus initialization we call > > > > > > error = acpi_dma_configure_id(&pdev->dev, DEV_DMA_COHERENT, > > > &mc_stream_id); > > > > > > which gets deferred because the SMMU has not been initialized yet. > > > Then we initialize the RMR tables but there is no device reference > > > there to be able to query device properties, only the stream id. > > > After the IORT tables are parsed and the SMMU is setup, on the > > > second device probe we associate everything based on the stream id > > > and the fsl-mc-bus device is able to claim its 1-1 DMA mappings. > > > > Can we solve this order problem by delaying the > > iommu_alloc_resv_region() to the iommu_dma_get_rmr_resv_regions(dev, > > list) ? We could invoke > > device_get_dma_attr() from there which I believe will return the _CCA > attribute. > > > > Or is that still early to invoke that? > > That looks like it should work. Do we then also need to parse through the > VirtualMemoryTable matching the start and end addresses to determine the > other memory attributes like MMIO? Yes. But that looks tricky as I can't find that readily available on Arm, like the efi_mem_attributes(). I will take a look. Please let me know if there is one or any other easy way to retrieve it. Thanks, Shameer > > -Jon > > > > > Thanks, > > Shameer > > > > > cat /sys/kernel/iommu_groups/0/reserved_regions > > > 0x0000000001000000 0x0000000010ffffff direct-relaxable > > > 0x0000000008000000 0x00000000080fffff msi > > > 0x000000080c000000 0x000000081bffffff direct-relaxable > > > 0x0000001c00000000 0x0000001c001fffff direct-relaxable > > > 0x0000002080000000 0x000000209fffffff direct-relaxable > > > > > > -Jon > > > > > > > > > > > Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel