* [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32()
@ 2022-04-24 7:44 Philipp Hortmann
2022-04-24 7:44 ` [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16 Philipp Hortmann
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace macro VNSvInPortW with ioread16 and VNSvInPortD with ioread32.
Avoid cast of the return value is possible with one exception.
The name of macro and the arguments use CamelCase which
is not accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix all issues.
This patch series is new but the first and last patch are already in V4.
Tested with vt6655 on mini PCI Module
Transferred this patch over wlan connection of vt6655
Philipp Hortmann (5):
staging: vt6655: Replace VNSvInPortW with ioread16
staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
staging: vt6655: Replace MACvReadISR with VNSvInPortD
staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi
staging: vt6655: Replace VNSvInPortD with ioread32
drivers/staging/vt6655/card.c | 4 ++--
drivers/staging/vt6655/device_main.c | 6 +++---
drivers/staging/vt6655/mac.h | 28 +++++++++++-----------------
drivers/staging/vt6655/rf.c | 2 +-
drivers/staging/vt6655/upc.h | 6 ------
5 files changed, 17 insertions(+), 29 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
@ 2022-04-24 7:44 ` Philipp Hortmann
2022-04-24 7:44 ` [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Philipp Hortmann
` (3 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace macro VNSvInPortW with ioread16.
The name of macro and the arguments use CamelCase which
is not accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
V1 -> V2: This patch was 5/7 and is now 4/6
V2 -> V3: Changed from
"Rename macros VNSvInPortB,W,D with CamelCase ..." to
Replace VNSvInPortW with ioread16
This patch was 4/6 and is now 2/7
V3 -> V4: added Tab so that \ is inline with above and below lines
---
drivers/staging/vt6655/mac.h | 4 ++--
drivers/staging/vt6655/upc.h | 3 ---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 7970a42ee6e6..4c6739862188 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -547,7 +547,7 @@ do { \
#define MACvWordRegBitsOn(iobase, byRegOfs, wBits) \
do { \
unsigned short wData; \
- VNSvInPortW(iobase + byRegOfs, &wData); \
+ wData = ioread16(iobase + byRegOfs); \
VNSvOutPortW(iobase + byRegOfs, wData | (wBits)); \
} while (0)
@@ -561,7 +561,7 @@ do { \
#define MACvWordRegBitsOff(iobase, byRegOfs, wBits) \
do { \
unsigned short wData; \
- VNSvInPortW(iobase + byRegOfs, &wData); \
+ wData = ioread16(iobase + byRegOfs); \
VNSvOutPortW(iobase + byRegOfs, wData & ~(wBits)); \
} while (0)
diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
index d2c1528c8e1b..4d09cf18ebe0 100644
--- a/drivers/staging/vt6655/upc.h
+++ b/drivers/staging/vt6655/upc.h
@@ -20,9 +20,6 @@
/* For memory mapped IO */
-#define VNSvInPortW(dwIOAddress, pwData) \
- (*(pwData) = ioread16(dwIOAddress))
-
#define VNSvInPortD(dwIOAddress, pdwData) \
(*(pdwData) = ioread32(dwIOAddress))
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
2022-04-24 7:44 ` [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16 Philipp Hortmann
@ 2022-04-24 7:44 ` Philipp Hortmann
2022-04-26 9:38 ` Greg Kroah-Hartman
2022-04-24 7:44 ` [PATCH 3/5] staging: vt6655: Replace MACvReadISR " Philipp Hortmann
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace macro MACvReadMIBCounter with VNSvInPortD.
Last patch within this patch series will replace all macros
VNSvInPortD with ioread32. The names of macros and the arguments
use CamelCase which is not accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/vt6655/device_main.c | 2 +-
drivers/staging/vt6655/mac.h | 3 ---
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 08b955c71b3c..7cceb57a5139 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1042,7 +1042,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
spin_lock_irqsave(&priv->lock, flags);
/* Read low level stats */
- MACvReadMIBCounter(priv->port_offset, &mib_counter);
+ VNSvInPortD(priv->port_offset + MAC_REG_MIBCNTR, &mib_counter);
low_stats->dot11RTSSuccessCount += mib_counter & 0xff;
low_stats->dot11RTSFailureCount += (mib_counter >> 8) & 0xff;
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 4c6739862188..74b45e1f0963 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -684,9 +684,6 @@ do { \
#define MACvSelectPage1(iobase) \
VNSvOutPortB(iobase + MAC_REG_PAGE1SEL, 1)
-#define MACvReadMIBCounter(iobase, pdwCounter) \
- VNSvInPortD(iobase + MAC_REG_MIBCNTR, pdwCounter)
-
#define MACvEnableProtectMD(iobase) \
do { \
unsigned long dwOrgValue; \
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/5] staging: vt6655: Replace MACvReadISR with VNSvInPortD
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
2022-04-24 7:44 ` [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16 Philipp Hortmann
2022-04-24 7:44 ` [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Philipp Hortmann
@ 2022-04-24 7:44 ` Philipp Hortmann
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
2022-04-24 7:44 ` [PATCH 5/5] staging: vt6655: Replace VNSvInPortD with ioread32 Philipp Hortmann
4 siblings, 0 replies; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace macro MACvReadISR with VNSvInPortD.
Last patch within this patch series will replace all macros
VNSvInPortD with ioread32. The names of macros and the arguments
use CamelCase which is not accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/vt6655/device_main.c | 4 ++--
drivers/staging/vt6655/mac.h | 3 ---
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 7cceb57a5139..c21787f32252 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1029,7 +1029,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
u32 isr;
unsigned long flags;
- MACvReadISR(priv->port_offset, &isr);
+ VNSvInPortD(priv->port_offset + MAC_REG_ISR, &isr);
if (isr == 0)
return;
@@ -1116,7 +1116,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
ieee80211_queue_stopped(priv->hw, 0))
ieee80211_wake_queues(priv->hw);
- MACvReadISR(priv->port_offset, &isr);
+ VNSvInPortD(priv->port_offset + MAC_REG_ISR, &isr);
MACvReceive0(priv->port_offset);
MACvReceive1(priv->port_offset);
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 74b45e1f0963..5aaa0de20e67 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -666,9 +666,6 @@ do { \
VNSvOutPortB(iobase + MAC_REG_STICKHW, byOrgValue); \
} while (0)
-#define MACvReadISR(iobase, pdwValue) \
- VNSvInPortD(iobase + MAC_REG_ISR, pdwValue)
-
#define MACvWriteISR(iobase, dwValue) \
VNSvOutPortD(iobase + MAC_REG_ISR, dwValue)
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
` (2 preceding siblings ...)
2022-04-24 7:44 ` [PATCH 3/5] staging: vt6655: Replace MACvReadISR " Philipp Hortmann
@ 2022-04-24 7:44 ` Philipp Hortmann
2022-04-24 11:27 ` kernel test robot
` (2 more replies)
2022-04-24 7:44 ` [PATCH 5/5] staging: vt6655: Replace VNSvInPortD with ioread32 Philipp Hortmann
4 siblings, 3 replies; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace two macros VNSvInPortD (32 Bit reads) with one ioread64_lo_hi.
The names of macro and the arguments use CamelCase which is not
accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
Used this code for testing:
VNSvInPortD(iobase + MAC_REG_TSFCNTR, (u32 *)pqwCurrTSF);
VNSvInPortD(iobase + MAC_REG_TSFCNTR + 4, (u32 *)pqwCurrTSF + 1);
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF *pqwCurrTSF: %llx", *pqwCurrTSF);
dev_info(&priv->pcid->dev, "CARDbGetCurrentTSF temp_ph: %llx",
ioread64_lo_hi(iobase + MAC_REG_TSFCNTR));
output:
[ +0.000085] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 117e7e
[ +0.000005] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 117e7e
[ +0.000009] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 39756d7f
[ +0.000005] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 39756d7f
[ +0.000009] vt6655 0000:01:05.0: CARDbGetCurrentTSF *pqwCurrTSF: 39756d8d
[ +0.000004] vt6655 0000:01:05.0: CARDbGetCurrentTSF temp_ph: 39756d8d
---
drivers/staging/vt6655/card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 022310af5485..5da25140ed4b 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -30,6 +30,7 @@
#include "desc.h"
#include "rf.h"
#include "power.h"
+#include <linux/io.h>
/*--------------------- Static Definitions -------------------------*/
@@ -753,8 +754,7 @@ bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF)
}
if (ww == W_MAX_TIMEOUT)
return false;
- VNSvInPortD(iobase + MAC_REG_TSFCNTR, (u32 *)pqwCurrTSF);
- VNSvInPortD(iobase + MAC_REG_TSFCNTR + 4, (u32 *)pqwCurrTSF + 1);
+ *pqwCurrTSF = ioread64_lo_hi(iobase + MAC_REG_TSFCNTR);
return true;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/5] staging: vt6655: Replace VNSvInPortD with ioread32
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
` (3 preceding siblings ...)
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
@ 2022-04-24 7:44 ` Philipp Hortmann
4 siblings, 0 replies; 10+ messages in thread
From: Philipp Hortmann @ 2022-04-24 7:44 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, linux-staging, linux-kernel
Replace macro VNSvInPortD with ioread32.
The name of macro and the arguments use CamelCase which
is not accepted by checkpatch.pl
Since there are more than one checkpatch issue per line,
more steps are rquired to fix.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
V1 -> V2: This patch was 5/7 and is now 4/6
V2 -> V3: Inserted patch that was before in a different way in
"Rename macros VNSvInPortB,W,D with CamelCase ..."
This patch was part of 4/6 and is now 3/7
V3 -> V4: Removed casting of the output variable
---
drivers/staging/vt6655/device_main.c | 6 +++---
drivers/staging/vt6655/mac.h | 18 +++++++++---------
drivers/staging/vt6655/rf.c | 2 +-
drivers/staging/vt6655/upc.h | 3 ---
4 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index c21787f32252..12fd825c23fe 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1029,7 +1029,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
u32 isr;
unsigned long flags;
- VNSvInPortD(priv->port_offset + MAC_REG_ISR, &isr);
+ isr = ioread32(priv->port_offset + MAC_REG_ISR);
if (isr == 0)
return;
@@ -1042,7 +1042,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
spin_lock_irqsave(&priv->lock, flags);
/* Read low level stats */
- VNSvInPortD(priv->port_offset + MAC_REG_MIBCNTR, &mib_counter);
+ mib_counter = ioread32(priv->port_offset + MAC_REG_MIBCNTR);
low_stats->dot11RTSSuccessCount += mib_counter & 0xff;
low_stats->dot11RTSFailureCount += (mib_counter >> 8) & 0xff;
@@ -1116,7 +1116,7 @@ static void vnt_interrupt_process(struct vnt_private *priv)
ieee80211_queue_stopped(priv->hw, 0))
ieee80211_wake_queues(priv->hw);
- VNSvInPortD(priv->port_offset + MAC_REG_ISR, &isr);
+ isr = ioread32(priv->port_offset + MAC_REG_ISR);
MACvReceive0(priv->port_offset);
MACvReceive1(priv->port_offset);
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 5aaa0de20e67..5b684194745c 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -618,7 +618,7 @@ do { \
#define MACvReceive0(iobase) \
do { \
unsigned long dwData; \
- VNSvInPortD(iobase + MAC_REG_RXDMACTL0, &dwData); \
+ dwData = ioread32(iobase + MAC_REG_RXDMACTL0); \
if (dwData & DMACTL_RUN) \
VNSvOutPortD(iobase + MAC_REG_RXDMACTL0, DMACTL_WAKE); \
else \
@@ -628,7 +628,7 @@ do { \
#define MACvReceive1(iobase) \
do { \
unsigned long dwData; \
- VNSvInPortD(iobase + MAC_REG_RXDMACTL1, &dwData); \
+ dwData = ioread32(iobase + MAC_REG_RXDMACTL1); \
if (dwData & DMACTL_RUN) \
VNSvOutPortD(iobase + MAC_REG_RXDMACTL1, DMACTL_WAKE); \
else \
@@ -638,7 +638,7 @@ do { \
#define MACvTransmit0(iobase) \
do { \
unsigned long dwData; \
- VNSvInPortD(iobase + MAC_REG_TXDMACTL0, &dwData); \
+ dwData = ioread32(iobase + MAC_REG_TXDMACTL0); \
if (dwData & DMACTL_RUN) \
VNSvOutPortD(iobase + MAC_REG_TXDMACTL0, DMACTL_WAKE); \
else \
@@ -648,7 +648,7 @@ do { \
#define MACvTransmitAC0(iobase) \
do { \
unsigned long dwData; \
- VNSvInPortD(iobase + MAC_REG_AC0DMACTL, &dwData); \
+ dwData = ioread32(iobase + MAC_REG_AC0DMACTL); \
if (dwData & DMACTL_RUN) \
VNSvOutPortD(iobase + MAC_REG_AC0DMACTL, DMACTL_WAKE); \
else \
@@ -684,7 +684,7 @@ do { \
#define MACvEnableProtectMD(iobase) \
do { \
unsigned long dwOrgValue; \
- VNSvInPortD(iobase + MAC_REG_ENCFG, &dwOrgValue); \
+ dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
dwOrgValue = dwOrgValue | ENCFG_PROTECTMD; \
VNSvOutPortD(iobase + MAC_REG_ENCFG, dwOrgValue); \
} while (0)
@@ -692,7 +692,7 @@ do { \
#define MACvDisableProtectMD(iobase) \
do { \
unsigned long dwOrgValue; \
- VNSvInPortD(iobase + MAC_REG_ENCFG, &dwOrgValue); \
+ dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
dwOrgValue = dwOrgValue & ~ENCFG_PROTECTMD; \
VNSvOutPortD(iobase + MAC_REG_ENCFG, dwOrgValue); \
} while (0)
@@ -700,7 +700,7 @@ do { \
#define MACvEnableBarkerPreambleMd(iobase) \
do { \
unsigned long dwOrgValue; \
- VNSvInPortD(iobase + MAC_REG_ENCFG, &dwOrgValue); \
+ dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
dwOrgValue = dwOrgValue | ENCFG_BARKERPREAM; \
VNSvOutPortD(iobase + MAC_REG_ENCFG, dwOrgValue); \
} while (0)
@@ -708,7 +708,7 @@ do { \
#define MACvDisableBarkerPreambleMd(iobase) \
do { \
unsigned long dwOrgValue; \
- VNSvInPortD(iobase + MAC_REG_ENCFG, &dwOrgValue); \
+ dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
dwOrgValue = dwOrgValue & ~ENCFG_BARKERPREAM; \
VNSvOutPortD(iobase + MAC_REG_ENCFG, dwOrgValue); \
} while (0)
@@ -716,7 +716,7 @@ do { \
#define MACvSetBBType(iobase, byTyp) \
do { \
unsigned long dwOrgValue; \
- VNSvInPortD(iobase + MAC_REG_ENCFG, &dwOrgValue); \
+ dwOrgValue = ioread32(iobase + MAC_REG_ENCFG); \
dwOrgValue = dwOrgValue & ~ENCFG_BBTYPE_MASK; \
dwOrgValue = dwOrgValue | (unsigned long)byTyp; \
VNSvOutPortD(iobase + MAC_REG_ENCFG, dwOrgValue); \
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 4498c9d400f2..036f48572334 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -175,7 +175,7 @@ bool IFRFbWriteEmbedded(struct vnt_private *priv, unsigned long dwData)
/* W_MAX_TIMEOUT is the timeout period */
for (ww = 0; ww < W_MAX_TIMEOUT; ww++) {
- VNSvInPortD(iobase + MAC_REG_IFREGCTL, &dwValue);
+ dwValue = ioread32(iobase + MAC_REG_IFREGCTL);
if (dwValue & IFREGCTL_DONE)
break;
}
diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
index 4d09cf18ebe0..a5b74aaadcd3 100644
--- a/drivers/staging/vt6655/upc.h
+++ b/drivers/staging/vt6655/upc.h
@@ -20,9 +20,6 @@
/* For memory mapped IO */
-#define VNSvInPortD(dwIOAddress, pdwData) \
- (*(pdwData) = ioread32(dwIOAddress))
-
#define VNSvOutPortB(dwIOAddress, byData) \
iowrite8((u8)(byData), dwIOAddress)
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
@ 2022-04-24 11:27 ` kernel test robot
2022-04-24 14:40 ` kernel test robot
2022-04-26 9:31 ` Greg Kroah-Hartman
2 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-24 11:27 UTC (permalink / raw)
To: Philipp Hortmann, Forest Bond, Greg Kroah-Hartman, linux-staging,
linux-kernel
Cc: kbuild-all
Hi Philipp,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Hortmann/staging-vt6655-Replace-macro-VNSvInPortW-D-with-ioread16-32/20220424-154730
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1efba7ef1d7da5944493728c5375fef5b2130de4
config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220424/202204241941.XzwKN0gg-lkp@intel.com/config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6e7e66f536e6d9d9eef8e7786de652b2702e1ee8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Philipp-Hortmann/staging-vt6655-Replace-macro-VNSvInPortW-D-with-ioread16-32/20220424-154730
git checkout 6e7e66f536e6d9d9eef8e7786de652b2702e1ee8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/staging/vt6655/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/vt6655/card.c: In function 'CARDbGetCurrentTSF':
>> drivers/staging/vt6655/card.c:757:23: error: implicit declaration of function 'ioread64_lo_hi' [-Werror=implicit-function-declaration]
757 | *pqwCurrTSF = ioread64_lo_hi(iobase + MAC_REG_TSFCNTR);
| ^~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/ioread64_lo_hi +757 drivers/staging/vt6655/card.c
730
731 /*
732 * Description: Read NIC TSF counter
733 * Get local TSF counter
734 *
735 * Parameters:
736 * In:
737 * priv - The adapter to be read
738 * Out:
739 * qwCurrTSF - Current TSF counter
740 *
741 * Return Value: true if success; otherwise false
742 */
743 bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF)
744 {
745 void __iomem *iobase = priv->port_offset;
746 unsigned short ww;
747 unsigned char data;
748
749 MACvRegBitsOn(iobase, MAC_REG_TFTCTL, TFTCTL_TSFCNTRRD);
750 for (ww = 0; ww < W_MAX_TIMEOUT; ww++) {
751 data = ioread8(iobase + MAC_REG_TFTCTL);
752 if (!(data & TFTCTL_TSFCNTRRD))
753 break;
754 }
755 if (ww == W_MAX_TIMEOUT)
756 return false;
> 757 *pqwCurrTSF = ioread64_lo_hi(iobase + MAC_REG_TSFCNTR);
758
759 return true;
760 }
761
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
2022-04-24 11:27 ` kernel test robot
@ 2022-04-24 14:40 ` kernel test robot
2022-04-26 9:31 ` Greg Kroah-Hartman
2 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2022-04-24 14:40 UTC (permalink / raw)
To: Philipp Hortmann, Forest Bond, Greg Kroah-Hartman, linux-staging,
linux-kernel
Cc: llvm, kbuild-all
Hi Philipp,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Hortmann/staging-vt6655-Replace-macro-VNSvInPortW-D-with-ioread16-32/20220424-154730
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1efba7ef1d7da5944493728c5375fef5b2130de4
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220424/202204242226.Y6Amb3he-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/6e7e66f536e6d9d9eef8e7786de652b2702e1ee8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Philipp-Hortmann/staging-vt6655-Replace-macro-VNSvInPortW-D-with-ioread16-32/20220424-154730
git checkout 6e7e66f536e6d9d9eef8e7786de652b2702e1ee8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/staging/vt6655/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/staging/vt6655/card.c:757:16: error: call to undeclared function 'ioread64_lo_hi'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
*pqwCurrTSF = ioread64_lo_hi(iobase + MAC_REG_TSFCNTR);
^
1 error generated.
vim +/ioread64_lo_hi +757 drivers/staging/vt6655/card.c
730
731 /*
732 * Description: Read NIC TSF counter
733 * Get local TSF counter
734 *
735 * Parameters:
736 * In:
737 * priv - The adapter to be read
738 * Out:
739 * qwCurrTSF - Current TSF counter
740 *
741 * Return Value: true if success; otherwise false
742 */
743 bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF)
744 {
745 void __iomem *iobase = priv->port_offset;
746 unsigned short ww;
747 unsigned char data;
748
749 MACvRegBitsOn(iobase, MAC_REG_TFTCTL, TFTCTL_TSFCNTRRD);
750 for (ww = 0; ww < W_MAX_TIMEOUT; ww++) {
751 data = ioread8(iobase + MAC_REG_TFTCTL);
752 if (!(data & TFTCTL_TSFCNTRRD))
753 break;
754 }
755 if (ww == W_MAX_TIMEOUT)
756 return false;
> 757 *pqwCurrTSF = ioread64_lo_hi(iobase + MAC_REG_TSFCNTR);
758
759 return true;
760 }
761
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
2022-04-24 11:27 ` kernel test robot
2022-04-24 14:40 ` kernel test robot
@ 2022-04-26 9:31 ` Greg Kroah-Hartman
2 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-26 9:31 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: Forest Bond, linux-staging, linux-kernel
On Sun, Apr 24, 2022 at 09:44:22AM +0200, Philipp Hortmann wrote:
> Replace two macros VNSvInPortD (32 Bit reads) with one ioread64_lo_hi.
I would stick to the 2 reads just to ensure that it works properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
2022-04-24 7:44 ` [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Philipp Hortmann
@ 2022-04-26 9:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-04-26 9:38 UTC (permalink / raw)
To: Philipp Hortmann; +Cc: Forest Bond, linux-staging, linux-kernel
On Sun, Apr 24, 2022 at 09:44:11AM +0200, Philipp Hortmann wrote:
> Replace macro MACvReadMIBCounter with VNSvInPortD.
> Last patch within this patch series will replace all macros
> VNSvInPortD with ioread32. The names of macros and the arguments
> use CamelCase which is not accepted by checkpatch.pl
No need to say "last patch" as that will not make sense when these are
in the tree, right?
>
> Since there are more than one checkpatch issue per line,
> more steps are rquired to fix.
This sentance also is not needed.
So the changelog can just say:
Replace macro MACvReadMIBCounter with VNSvInPortD and as it was
the only user, it can now be removed.
Same comments on the other changes in this series, but I did take the
first patch, it made sense on its own.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-04-26 9:38 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
2022-04-24 7:44 ` [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16 Philipp Hortmann
2022-04-24 7:44 ` [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Philipp Hortmann
2022-04-26 9:38 ` Greg Kroah-Hartman
2022-04-24 7:44 ` [PATCH 3/5] staging: vt6655: Replace MACvReadISR " Philipp Hortmann
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
2022-04-24 11:27 ` kernel test robot
2022-04-24 14:40 ` kernel test robot
2022-04-26 9:31 ` Greg Kroah-Hartman
2022-04-24 7:44 ` [PATCH 5/5] staging: vt6655: Replace VNSvInPortD with ioread32 Philipp Hortmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.