From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A16CC433C1 for ; Fri, 26 Mar 2021 12:03:03 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0A8F961A45 for ; Fri, 26 Mar 2021 12:03:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A8F961A45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4F4E40685; Fri, 26 Mar 2021 13:03:01 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id C03124067B for ; Fri, 26 Mar 2021 13:02:59 +0100 (CET) IronPort-SDR: AfFO91ZhoCxrvVjrw5SV60bXNnn9UP3khJWIDcRLae+k1Ti2AJYF5j5rwWxR3K8fNtMpG4PpiB 52cwya/Bx/eA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="276273518" X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="276273518" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 05:02:58 -0700 IronPort-SDR: ekfcr+Ft1SOAVKvqdwBcZUfhINuDGlit9mtjvHl63xxbXOJQtQ4NoutWD9Mo7dlw8qJ07QSHRP oyuaRwFnKN4w== X-IronPort-AV: E=Sophos;i="5.81,280,1610438400"; d="scan'208";a="375463022" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.231.99]) ([10.213.231.99]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 05:02:56 -0700 To: Tyler Retzlaff , Thomas Monjalon Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com, Shepard Siegel , David Marchand References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com> <5945384.p3lA8Brad8@thomas> <20210324162441.GA14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 26 Mar 2021 12:02:55 +0000 MIME-Version: 1.0 In-Reply-To: <20210324162441.GA14991@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 4:24 PM, Tyler Retzlaff wrote: > On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: >> 24/03/2021 12:27, Ferruh Yigit: >>> >>> But not sure how to manage the same problem for whole project, if install all >>> headers in one patch, or add them gradually via separate patches by time ... >> >> We did a cleanup in ethdev but not in other driver classes. >> When the cleanup will be done gradually, the headers >> must move in this new category driver_sdk_headers. > > yes, some headers are not installed now. so they need only to have > their api marked __rte_internal and installed (since there should be no > external consumer as a function of not being installed) > > the more difficult case is where headers were installed but the api were > not marked __rte_internal and appear in the stable version.map. for > those i guess deprecation notice has to be issued before marking as > internal. > Are you referring to any specific APIs, can you share list of them?