From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CD3C433EF for ; Wed, 4 May 2022 14:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351522AbiEDO4a (ORCPT ); Wed, 4 May 2022 10:56:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245006AbiEDO43 (ORCPT ); Wed, 4 May 2022 10:56:29 -0400 X-Greylist: delayed 25244 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 04 May 2022 07:52:51 PDT Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A521B120A9; Wed, 4 May 2022 07:52:51 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id D5E7C419C2; Wed, 4 May 2022 14:52:45 +0000 (UTC) Message-ID: Date: Wed, 4 May 2022 23:52:43 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/4] MAINTAINERS: Add entries for Apple SoC cpufreq driver Content-Language: es-ES To: Viresh Kumar Cc: "Rafael J. Wysocki" , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Ulf Hansson , Marc Zyngier , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220504075153.185208-1-marcan@marcan.st> <20220504075153.185208-2-marcan@marcan.st> <20220504101750.wmuicq3dytnxrw5o@vireshk-i7> From: Hector Martin In-Reply-To: <20220504101750.wmuicq3dytnxrw5o@vireshk-i7> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2022 19.17, Viresh Kumar wrote: > On 04-05-22, 16:51, Hector Martin wrote: >> Splitting this commit, as usual, to facilitate merges via the SoC tree. >> >> Signed-off-by: Hector Martin >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index edc96cdb85e8..39bfa478fe55 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1835,6 +1835,7 @@ T: git https://github.com/AsahiLinux/linux.git >> F: Documentation/devicetree/bindings/arm/apple.yaml >> F: Documentation/devicetree/bindings/arm/apple/* >> F: Documentation/devicetree/bindings/clock/apple,nco.yaml >> +F: Documentation/devicetree/bindings/cpufreq/apple,soc-cpufreq.yaml >> F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml >> F: Documentation/devicetree/bindings/interrupt-controller/apple,* >> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml >> @@ -1844,6 +1845,7 @@ F: Documentation/devicetree/bindings/power/apple* >> F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> F: arch/arm64/boot/dts/apple/ >> F: drivers/clk/clk-apple-nco.c >> +F: drivers/cpufreq/apple-soc-cpufreq.c >> F: drivers/i2c/busses/i2c-pasemi-core.c >> F: drivers/i2c/busses/i2c-pasemi-platform.c >> F: drivers/irqchip/irq-apple-aic.c > > This should be the last patch instead, or should at least be added > after the files are merged first. If someone checks out at this > commit, the files won't be available but still linked here. Isn't that backwards? If someone touches the files, we want them to be able to get_maintainer.pl, so the MAINTAINERS entries should come first. It doesn't really cause any issues if there are entries that point at files that don't exist yet, right? Though this is mostly a moot point because the purpose of splitting this out is so we can merge this one patch through the SoC tree, at which point the ordering isn't guaranteed (unless the whole series goes through SoC). It's a minor issue though; we've done it like this for other series and it hasn't caused anyone trouble. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21895C433FE for ; Wed, 4 May 2022 14:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hjlzRjrVXBxdH0pQvMuMLMDVK1e3Sr9yhbuahvxtDrc=; b=lXkBiZi0Fd8zNf gK9o4tuHUSBy/qXCl18/FKBI9QiEzVXngNU27ei3W/Sv5jw4fzSaOaXNegcBeljUzdKEY9aE13EG/ 6obXCBpjb7j/MGGc2v4p24ekJQcd29ekcsX2TQs/zHmz2W3sp6CkFEUqyHgMn17U3n0bAG5LxjnLy o08rgr/SN5YcvoxXHzwiSgmDxK8VlqcSmqKMK+FKtPf3JoA/gphmkW3NJowVwp1gwHWHtYAmFxCaW 9XA3fJaBXlev7VhbtA9IRXe9Y8ohkp2BZQLgyDArcDkoW5ltZ46IkY6beRx9AIe13R+/IqXSzl643 oh9cDF5WoWJlk+2ZB2jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmGNA-00BIe7-Li; Wed, 04 May 2022 14:53:00 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmGN7-00BIcN-Gs for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 14:52:59 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id D5E7C419C2; Wed, 4 May 2022 14:52:45 +0000 (UTC) Message-ID: Date: Wed, 4 May 2022 23:52:43 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/4] MAINTAINERS: Add entries for Apple SoC cpufreq driver Content-Language: es-ES To: Viresh Kumar Cc: "Rafael J. Wysocki" , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Ulf Hansson , Marc Zyngier , Mark Kettenis , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220504075153.185208-1-marcan@marcan.st> <20220504075153.185208-2-marcan@marcan.st> <20220504101750.wmuicq3dytnxrw5o@vireshk-i7> From: Hector Martin In-Reply-To: <20220504101750.wmuicq3dytnxrw5o@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_075257_733576_C17FA352 X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/05/2022 19.17, Viresh Kumar wrote: > On 04-05-22, 16:51, Hector Martin wrote: >> Splitting this commit, as usual, to facilitate merges via the SoC tree. >> >> Signed-off-by: Hector Martin >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index edc96cdb85e8..39bfa478fe55 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1835,6 +1835,7 @@ T: git https://github.com/AsahiLinux/linux.git >> F: Documentation/devicetree/bindings/arm/apple.yaml >> F: Documentation/devicetree/bindings/arm/apple/* >> F: Documentation/devicetree/bindings/clock/apple,nco.yaml >> +F: Documentation/devicetree/bindings/cpufreq/apple,soc-cpufreq.yaml >> F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml >> F: Documentation/devicetree/bindings/interrupt-controller/apple,* >> F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml >> @@ -1844,6 +1845,7 @@ F: Documentation/devicetree/bindings/power/apple* >> F: Documentation/devicetree/bindings/watchdog/apple,wdt.yaml >> F: arch/arm64/boot/dts/apple/ >> F: drivers/clk/clk-apple-nco.c >> +F: drivers/cpufreq/apple-soc-cpufreq.c >> F: drivers/i2c/busses/i2c-pasemi-core.c >> F: drivers/i2c/busses/i2c-pasemi-platform.c >> F: drivers/irqchip/irq-apple-aic.c > > This should be the last patch instead, or should at least be added > after the files are merged first. If someone checks out at this > commit, the files won't be available but still linked here. Isn't that backwards? If someone touches the files, we want them to be able to get_maintainer.pl, so the MAINTAINERS entries should come first. It doesn't really cause any issues if there are entries that point at files that don't exist yet, right? Though this is mostly a moot point because the purpose of splitting this out is so we can merge this one patch through the SoC tree, at which point the ordering isn't guaranteed (unless the whole series goes through SoC). It's a minor issue though; we've done it like this for other series and it hasn't caused anyone trouble. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel