From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165870AbdEYWOs (ORCPT ); Thu, 25 May 2017 18:14:48 -0400 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:55170 "EHLO gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425288AbdEYWMR (ORCPT ); Thu, 25 May 2017 18:12:17 -0400 From: Chris Packham To: Boris Brezillon CC: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Thomas Petazzoni , "ezequiel.garcia@free-electrons.com" , Gregory Clement Subject: Re: pxa3xx-nand failing to find device on linux-next Thread-Topic: pxa3xx-nand failing to find device on linux-next Thread-Index: AQHS04VCDrK5tOKlGkCrPkXEtQfG7A== Date: Thu, 25 May 2017 22:12:12 +0000 Message-ID: References: <2a79405e219b4c37ba00defbe4a0dfe4@svr-chch-ex1.atlnz.lc> <20170524132301.12ad33d8@bbrezillon> <20170524132508.420614c7@bbrezillon> <20170525003646.276516d0@bbrezillon> <69dfc0d5ca774efb8c92e9ec635f68ec@svr-chch-ex1.atlnz.lc> <20170525081747.4c86164c@bbrezillon> Accept-Language: en-NZ, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [2001:df5:b000:22:dc9a:6619:9edb:2094] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4PMEtNN025484 On 25/05/17 18:19, Boris Brezillon wrote: > Le Wed, 24 May 2017 22:58:53 +0000, > Chris Packham a écrit : > >> On 25/05/17 10:36, Boris Brezillon wrote: >>> Le Wed, 24 May 2017 22:03:52 +0000, >>> Chris Packham a écrit : >>> >>>> On 24/05/17 23:25, Boris Brezillon wrote: >>>>> On Wed, 24 May 2017 13:23:01 +0200 >>>>> Boris Brezillon wrote: >>>>> >>>>>> Hi Chris, >>>>>> >>>>>> On Wed, 24 May 2017 09:36:56 +0000 >>>>>> Chris Packham wrote: >>>>>> >>>>>>> On 23/05/17 17:27, Chris Packham wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I'm doing some testing on linux-next and I'm finding that my nand flash >>>>>>>> has disappeared. >>>>>>>> >>>>>>>> pxa3xx-nand f10d0000.flash: This platform can't do DMA on this device >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee >>>>>>>> On-die ECC forcefully enabled, not supported >>>>>>>> nand: No NAND device found >>>>>>>> pxa3xx-nand f10d0000.flash: failed to scan nand at cs 0 >>>>>>>> >>>>>>>> This was working around 4.11. I'll try to do some more digging tomorrow >>>>>>>> to narrow down a failure point but I thought I'd send this out now just >>>>>>>> in case it rings any bells. >>>>>>>> >>>>>>>> The board I'm using (DB-88F6820-AMC) is unfortunately out-of tree but it >>>>>>>> should be pretty close to the armada-388-db. I can make my dts available >>>>>>>> if it's helpful. >>>>>>> >>>>>>> Still works on 4.12-rc2. Fails on next-20170524. >>>>>>> >>>>>>> This appears to be due to commit b566d9c055de ("mtd: nand: add support >>>>>>> for Micron on-die ECC"). Which based on the description seems intentional. >>>>>>> >>>>>>> Since I have access to a hardware platform that has a micron flash with >>>>>>> ECC forcefully enabled how can I help to get this implemented. >>>>>> >>>>>> Can you try with this patch applied [1]? >>>>> >>>>> Sorry, wrong patch. Can you try this one [1] instead? >>>>> >>>>> [1]http://code.bulix.org/pkfhmi-135875 >>>>> >>>> >>>> With the patch above the chip is detected but ubifs is unhappy >>> >>> Hm, weird. And if you revert my both Thomas patch and mine, what do you >>> get? >> >> Seems to work just fine. > > Okay. Let's try with something simpler then. Can you test the following > patch? > > --->8--- > From 0a0eaa39ea9b19191ae0c31ff3625c224a8a55f2 Mon Sep 17 00:00:00 2001 > From: Boris Brezillon > Date: Thu, 25 May 2017 08:15:15 +0200 > Subject: [PATCH] mtd: nand: pxa3xx: Implement failing > ->onfi_{set,get}_features() stubs > > Implement stubs returning -ENOTSUPP for ->onfi_{set,get}_features() so > that we don't let the core think we are supporting the GET/SET FEATURES > operation. > > Signed-off-by: Boris Brezillon > --- Yep that seems to work. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dE14q-0006sy-A8 for linux-mtd@lists.infradead.org; Thu, 25 May 2017 22:17:55 +0000 From: Chris Packham To: Boris Brezillon CC: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Thomas Petazzoni , "ezequiel.garcia@free-electrons.com" , Gregory Clement Subject: Re: pxa3xx-nand failing to find device on linux-next Date: Thu, 25 May 2017 22:12:12 +0000 Message-ID: References: <2a79405e219b4c37ba00defbe4a0dfe4@svr-chch-ex1.atlnz.lc> <20170524132301.12ad33d8@bbrezillon> <20170524132508.420614c7@bbrezillon> <20170525003646.276516d0@bbrezillon> <69dfc0d5ca774efb8c92e9ec635f68ec@svr-chch-ex1.atlnz.lc> <20170525081747.4c86164c@bbrezillon> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 25/05/17 18:19, Boris Brezillon wrote:=0A= > Le Wed, 24 May 2017 22:58:53 +0000,=0A= > Chris Packham a =E9crit :=0A= > =0A= >> On 25/05/17 10:36, Boris Brezillon wrote:=0A= >>> Le Wed, 24 May 2017 22:03:52 +0000,=0A= >>> Chris Packham a =E9crit :=0A= >>> =0A= >>>> On 24/05/17 23:25, Boris Brezillon wrote:=0A= >>>>> On Wed, 24 May 2017 13:23:01 +0200=0A= >>>>> Boris Brezillon wrote:=0A= >>>>> =0A= >>>>>> Hi Chris,=0A= >>>>>>=0A= >>>>>> On Wed, 24 May 2017 09:36:56 +0000=0A= >>>>>> Chris Packham wrote:=0A= >>>>>> =0A= >>>>>>> On 23/05/17 17:27, Chris Packham wrote:=0A= >>>>>>>> Hi,=0A= >>>>>>>>=0A= >>>>>>>> I'm doing some testing on linux-next and I'm finding that my nand = flash=0A= >>>>>>>> has disappeared.=0A= >>>>>>>>=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: This platform can't do DMA on this dev= ice=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee=0A= >>>>>>>> On-die ECC forcefully enabled, not supported=0A= >>>>>>>> nand: No NAND device found=0A= >>>>>>>> pxa3xx-nand f10d0000.flash: failed to scan nand at cs 0=0A= >>>>>>>>=0A= >>>>>>>> This was working around 4.11. I'll try to do some more digging tom= orrow=0A= >>>>>>>> to narrow down a failure point but I thought I'd send this out now= just=0A= >>>>>>>> in case it rings any bells.=0A= >>>>>>>>=0A= >>>>>>>> The board I'm using (DB-88F6820-AMC) is unfortunately out-of tree = but it=0A= >>>>>>>> should be pretty close to the armada-388-db. I can make my dts ava= ilable=0A= >>>>>>>> if it's helpful.=0A= >>>>>>>=0A= >>>>>>> Still works on 4.12-rc2. Fails on next-20170524.=0A= >>>>>>>=0A= >>>>>>> This appears to be due to commit b566d9c055de ("mtd: nand: add supp= ort=0A= >>>>>>> for Micron on-die ECC"). Which based on the description seems inten= tional.=0A= >>>>>>>=0A= >>>>>>> Since I have access to a hardware platform that has a micron flash = with=0A= >>>>>>> ECC forcefully enabled how can I help to get this implemented.=0A= >>>>>>=0A= >>>>>> Can you try with this patch applied [1]?=0A= >>>>>=0A= >>>>> Sorry, wrong patch. Can you try this one [1] instead?=0A= >>>>>=0A= >>>>> [1]http://code.bulix.org/pkfhmi-135875=0A= >>>>> =0A= >>>>=0A= >>>> With the patch above the chip is detected but ubifs is unhappy=0A= >>>=0A= >>> Hm, weird. And if you revert my both Thomas patch and mine, what do you= =0A= >>> get?=0A= >>=0A= >> Seems to work just fine.=0A= > =0A= > Okay. Let's try with something simpler then. Can you test the following= =0A= > patch?=0A= > =0A= > --->8---=0A= > From 0a0eaa39ea9b19191ae0c31ff3625c224a8a55f2 Mon Sep 17 00:00:00 2001= =0A= > From: Boris Brezillon =0A= > Date: Thu, 25 May 2017 08:15:15 +0200=0A= > Subject: [PATCH] mtd: nand: pxa3xx: Implement failing=0A= > ->onfi_{set,get}_features() stubs=0A= > =0A= > Implement stubs returning -ENOTSUPP for ->onfi_{set,get}_features() so=0A= > that we don't let the core think we are supporting the GET/SET FEATURES= =0A= > operation.=0A= > =0A= > Signed-off-by: Boris Brezillon =0A= > ---=0A= =0A= Yep that seems to work.=0A= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris.Packham@alliedtelesis.co.nz (Chris Packham) Date: Thu, 25 May 2017 22:12:12 +0000 Subject: pxa3xx-nand failing to find device on linux-next References: <2a79405e219b4c37ba00defbe4a0dfe4@svr-chch-ex1.atlnz.lc> <20170524132301.12ad33d8@bbrezillon> <20170524132508.420614c7@bbrezillon> <20170525003646.276516d0@bbrezillon> <69dfc0d5ca774efb8c92e9ec635f68ec@svr-chch-ex1.atlnz.lc> <20170525081747.4c86164c@bbrezillon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25/05/17 18:19, Boris Brezillon wrote: > Le Wed, 24 May 2017 22:58:53 +0000, > Chris Packham a ?crit : > >> On 25/05/17 10:36, Boris Brezillon wrote: >>> Le Wed, 24 May 2017 22:03:52 +0000, >>> Chris Packham a ?crit : >>> >>>> On 24/05/17 23:25, Boris Brezillon wrote: >>>>> On Wed, 24 May 2017 13:23:01 +0200 >>>>> Boris Brezillon wrote: >>>>> >>>>>> Hi Chris, >>>>>> >>>>>> On Wed, 24 May 2017 09:36:56 +0000 >>>>>> Chris Packham wrote: >>>>>> >>>>>>> On 23/05/17 17:27, Chris Packham wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I'm doing some testing on linux-next and I'm finding that my nand flash >>>>>>>> has disappeared. >>>>>>>> >>>>>>>> pxa3xx-nand f10d0000.flash: This platform can't do DMA on this device >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ef >>>>>>>> pxa3xx-nand f10d0000.flash: non-supported command ee >>>>>>>> On-die ECC forcefully enabled, not supported >>>>>>>> nand: No NAND device found >>>>>>>> pxa3xx-nand f10d0000.flash: failed to scan nand at cs 0 >>>>>>>> >>>>>>>> This was working around 4.11. I'll try to do some more digging tomorrow >>>>>>>> to narrow down a failure point but I thought I'd send this out now just >>>>>>>> in case it rings any bells. >>>>>>>> >>>>>>>> The board I'm using (DB-88F6820-AMC) is unfortunately out-of tree but it >>>>>>>> should be pretty close to the armada-388-db. I can make my dts available >>>>>>>> if it's helpful. >>>>>>> >>>>>>> Still works on 4.12-rc2. Fails on next-20170524. >>>>>>> >>>>>>> This appears to be due to commit b566d9c055de ("mtd: nand: add support >>>>>>> for Micron on-die ECC"). Which based on the description seems intentional. >>>>>>> >>>>>>> Since I have access to a hardware platform that has a micron flash with >>>>>>> ECC forcefully enabled how can I help to get this implemented. >>>>>> >>>>>> Can you try with this patch applied [1]? >>>>> >>>>> Sorry, wrong patch. Can you try this one [1] instead? >>>>> >>>>> [1]http://code.bulix.org/pkfhmi-135875 >>>>> >>>> >>>> With the patch above the chip is detected but ubifs is unhappy >>> >>> Hm, weird. And if you revert my both Thomas patch and mine, what do you >>> get? >> >> Seems to work just fine. > > Okay. Let's try with something simpler then. Can you test the following > patch? > > --->8--- > From 0a0eaa39ea9b19191ae0c31ff3625c224a8a55f2 Mon Sep 17 00:00:00 2001 > From: Boris Brezillon > Date: Thu, 25 May 2017 08:15:15 +0200 > Subject: [PATCH] mtd: nand: pxa3xx: Implement failing > ->onfi_{set,get}_features() stubs > > Implement stubs returning -ENOTSUPP for ->onfi_{set,get}_features() so > that we don't let the core think we are supporting the GET/SET FEATURES > operation. > > Signed-off-by: Boris Brezillon > --- Yep that seems to work.