From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FBCC433F5 for ; Sun, 5 Sep 2021 08:07:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE896054F for ; Sun, 5 Sep 2021 08:07:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DE896054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:32960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMnBa-0000y9-O8 for qemu-devel@archiver.kernel.org; Sun, 05 Sep 2021 04:07:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMnAY-0008CP-PS for qemu-devel@nongnu.org; Sun, 05 Sep 2021 04:06:26 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:36840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMnAX-0007A2-Eq for qemu-devel@nongnu.org; Sun, 05 Sep 2021 04:06:26 -0400 Received: by mail-wr1-x433.google.com with SMTP id q14so4932893wrp.3 for ; Sun, 05 Sep 2021 01:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NDPMJH+s/pOyzHmbw7BfF0p7wQATXYlu60PxgPi5ic0=; b=heesdtxes7+6wxiRklucHOBkApuTigFB7UYlVFSyKhwCxCFKtXxe4Z4ahjwAnehxiG kJe4Y+7IIS+of87PSPkRY3bDwhusAuf5OafmDBYiG5uwq5TIW7SUxjryyr1weZBzT4rn E5d516kKTF5fPVFNFtk1wflz8NHFldZt4cfuLo/0b+2FDy+UsdqPR6lTzsGKW84OuT1s 0g2Nsrepkv/R/WmIUmR5XgIGny5XwUTTSQmAfs8AVwckMElSZqyXMtOq9ytn1G/BELrO vawKK7qx+M61p9JKw+F61FWQyHFq4WmpS9gQn8PEUObFUMi+2yjM6mRhB3KZV9BgTnnC rUwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NDPMJH+s/pOyzHmbw7BfF0p7wQATXYlu60PxgPi5ic0=; b=qk4Ywn/5ngzy8qv4/xLjFlYb3TEUC4fPCxJXdv9zra36afhy9CUAUqZLUWOIgMEYhN nhQwKbWo6qHbNVnfJu7/ishwc1vKBM455lVvXzNxD/YjSiz2Mm5rJUXV42jTUiD9Ucsv FuWKqtVNdFRnq4hbYDDdjCR9yXmdjWenUe/7jDgeDAMoAd37wY4VJCm4Po7G4Q8QPEG2 5vi84I+291s0Oi06eMCR3lW57zAn4tDQEpqn7UUj82Ap9udkIP3k3FcUnhQiVtrUL2Z6 6qWWTb+VpXac8sC8Piq0igrj0mePBK0PAEK57I0oE+ryc3SRn12ZIByNXVbGvQJDbNQ9 0tng== X-Gm-Message-State: AOAM533qlMlObv7XZWg+lYRXsGXOAiflhiPh7XCtEk61U8YdFJaTxiNn dmD+A0XWpk1Zt9FSOC6NSizg5Q== X-Google-Smtp-Source: ABdhPJyxvY9GLQbgtst208f2NeHrRkjsb8nL0BWVxyy/W3B/wMbH86oplAD6zWdyBpgvfH3m66aulg== X-Received: by 2002:a05:6000:352:: with SMTP id e18mr7192619wre.238.1630829183691; Sun, 05 Sep 2021 01:06:23 -0700 (PDT) Received: from [192.168.8.105] (206.red-2-143-78.dynamicip.rima-tde.net. [2.143.78.206]) by smtp.gmail.com with ESMTPSA id k1sm4257817wrz.61.2021.09.05.01.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Sep 2021 01:06:23 -0700 (PDT) Subject: Re: [PATCH v10 02/16] target/riscv: fix clzw implementation to operate on arg1 To: Philipp Tomsich , qemu-devel@nongnu.org References: <20210904203516.2570119-1-philipp.tomsich@vrull.eu> <20210904203516.2570119-3-philipp.tomsich@vrull.eu> From: Richard Henderson Message-ID: Date: Sun, 5 Sep 2021 10:06:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210904203516.2570119-3-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -58 X-Spam_score: -5.9 X-Spam_bar: ----- X-Spam_report: (-5.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.832, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kito Cheng , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/4/21 10:35 PM, Philipp Tomsich wrote: > The refactored gen_clzw() uses ret as its argument, instead of arg1. > Fix it. > > Signed-off-by: Philipp Tomsich > --- > > Changes in v10: > - New patch, fixing regressions discovered with x264_r. Fixes: 60903915050 ("target/riscv: Add DisasExtend to gen_unary") Reviewed-by: Richard Henderson r~