From: "Zhao, Yakui" <yakui.zhao@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"Chen, Jason CJ" <jason.cj.chen@intel.com>
Subject: Re: [RFC PATCH v5 4/4] x86/acrn: Add hypercall for ACRN guest
Date: Sun, 28 Apr 2019 09:56:35 +0800 [thread overview]
Message-ID: <e04c43cf-029b-d459-e9d9-1a1f5c403dab@intel.com> (raw)
In-Reply-To: <20190427085816.GB12360@zn.tnic>
On 2019年04月27日 16:58, Borislav Petkov wrote:
> On Fri, Apr 26, 2019 at 11:18:48AM +0800, Zhao, Yakui wrote:
>> It seems that it is seldom used in kernel although the explicit register
>> variable is supported by GCC and makes the code look simpler. And it seems
>> that the explicit register variable is not suppoorted by CLAG.
>
> The more reason not to do it this way. Also, the "register" variable
> specification is not very widespread in x86 when you look at
>
> $ git grep -E "register\s.*asm" arch/x86/
>
> output.
Yes. The explicit register variable is not very videspread for arch/x86.
So the register variable will be removed for ACRN hypercall.
>
>> So the explicit register variable will be removed. I will follow the asm
>> code from Borislav. Of course one minor change is that the "movq" is used
>> instead of "mov".
>
> Does that matter if your destination register is 64-bit?
Thanks for the reminder about the access width.
It is 64-bit register. What I said is the "movq", not "movl".
(I understand that movl is incorrect for 64-bit register).
Thanks
Yakui
next prev parent reply other threads:[~2019-04-28 1:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 0:54 [RFC PATCH v5 0/4] x86: Add the support of ACRN guest under x86 Zhao Yakui
2019-04-24 0:54 ` [RFC PATCH v5 1/4] x86/Kconfig: Add new config symbol to unify conditional definition of hv_irq_callback_count Zhao Yakui
2019-04-24 0:54 ` [RFC PATCH v5 2/4] x86: Add the support of Linux guest on ACRN hypervisor Zhao Yakui
2019-04-24 0:54 ` [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector Zhao Yakui
2019-04-25 7:17 ` Ingo Molnar
2019-04-25 12:42 ` Zhao, Yakui
2019-04-25 19:45 ` Ingo Molnar
2019-04-26 1:46 ` Zhao, Yakui
2019-04-26 5:57 ` Ingo Molnar
2019-04-24 0:54 ` [RFC PATCH v5 4/4] x86/acrn: Add hypercall for ACRN guest Zhao Yakui
2019-04-25 7:07 ` Ingo Molnar
2019-04-25 10:16 ` Zhao, Yakui
2019-04-25 11:00 ` Borislav Petkov
2019-04-26 3:18 ` Zhao, Yakui
2019-04-27 8:58 ` Borislav Petkov
2019-04-28 1:56 ` Zhao, Yakui [this message]
2019-04-28 10:03 ` Borislav Petkov
2019-04-29 1:24 ` Zhao, Yakui
2019-04-29 7:36 ` Borislav Petkov
2019-04-29 9:52 ` Zhao, Yakui
2019-04-24 22:20 ` [RFC PATCH v5 0/4] x86: Add the support of ACRN guest under x86 Thomas Gleixner
2019-04-25 5:44 ` Zhao, Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e04c43cf-029b-d459-e9d9-1a1f5c403dab@intel.com \
--to=yakui.zhao@intel.com \
--cc=bp@alien8.de \
--cc=jason.cj.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.