From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7DB0C433DF for ; Tue, 28 Jul 2020 20:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDEDD206D8 for ; Tue, 28 Jul 2020 20:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729236AbgG1U7u (ORCPT ); Tue, 28 Jul 2020 16:59:50 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:34489 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728728AbgG1U7t (ORCPT ); Tue, 28 Jul 2020 16:59:49 -0400 Received: from dante.cb.ettle ([143.159.226.70]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.179]) with ESMTPSA (Nemesis) id 1N4Q4m-1kk9592UdC-011ScG; Tue, 28 Jul 2020 22:57:57 +0200 Message-ID: Subject: Re: rtsx_pci not restoring ASPM state after suspend/resume From: James Ettle To: Bjorn Helgaas Cc: =?UTF-8?Q?=E5=90=B3=E6=98=8A=E6=BE=84?= Ricky , Rui Feng , Arnd Bergmann , Greg Kroah-Hartman , Len Brown , Puranjay Mohan , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jacopo De Simoi Date: Tue, 28 Jul 2020 21:57:55 +0100 In-Reply-To: <20200727214712.GA1777201@bjorn-Precision-5520> References: <20200727214712.GA1777201@bjorn-Precision-5520> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:ngSr6pffow2MrQKByZsOgkOjw+48NYsh/QNN7LLUjsPAUCqjVX8 tL1Q5y77Y/Bs2y+PjxM3AhKLg7QCGAYBHkpKPbeoKgVN8NP/QG2k/yRXk5++m3OetQh41Ya DJ9/QeTBamu7kmt8fHgxdHGFq50o1X95ELCiESFFKaeYfotykVdh+uABvrcDJjdSac5fzVX uWHE9VjHfUjE5Zz/8vLvw== X-UI-Out-Filterresults: notjunk:1;V03:K0:I1+llK0lwZA=:1+7ikQm0qnZ3cRtuwgvMtX xVzHZJ6LvJC74PFGUjYCPmw3FKUWyqLBJQMp0zpRCSj43yEiwBsyFbTfNv/B+8Wkoeb2zzpGy GhCVDU1/m5pBYkJzF5gawSoJPIOSgVbY8K4iIJ8e3ByWO/wY1J9sVydnsXDsmzq2o3orfIp+s 50xonzRQw0XJL9rMHfWjydEYRz9FG6NsVB/KHtktEgtGHm+8enL+TvaG0aAbE5brVgZC2DH5z cGXfdFdylZrWxk+mK6tOFGIL00ZAd/mJZXBuh+/yk8SWyDUMT8OXVumjEISQygo28sh5Mdj4g 6q+2OjpjYZrPlpdmN1gug540sln/YMFlpaNsl1ci+K9wFPQ693Lob5A0XUH6IXnyhOGPncsMF mepD7X7E1QWOxMLXlolu1pbD6gsLlvTzysFnnJwx1OzY2y/G/lFbu/kQtLnOHX/iy/SZ0iZFp ag4VHsTYBGUZI37IKeyDAECD86XZXh9VWLQvyUF6V0oWqcq4zcdcnQyiHpHufB9cHzLJGVqcA ZDImJnreNYTTQQwYM7odkgnMyEax4axPqNweoGdeNYPREP4LTFloRFh1cMF6G/8j6jRIIA/S0 Cmz91i9mqs40hGtCEieLqMhsU+wMUeJh9F2xtQESk0x9s13MWs1FSEsATuc2f24eyjJrjsK5g fNP9TRaWl6HKmE5bGCZnu57fruv4HdDYBE6bxQhETFzgoydlWx6F//luMGPvEZOJ5R8nyNpI8 /Kndv/TTIPcPa7eLH/79LABiQ7hmWKL78/+LDZ4n+myEyIxCUlF7OuwDPad+K+NIMN/6kX4pv +aHhPB53pBMOfBaOpK99C/NMnnrsHscaKPHzeQ9xAqLMczpHuD5o03ee0Gd1y7kt4ZFjDhg Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-07-27 at 16:47 -0500, Bjorn Helgaas wrote: > > I don't see anything in rtsx that enables L0s. Can you collect the > dmesg log when booting with "pci=earlydump"? That will show whether > the BIOS left it this way. The PCI core isn't supposed to do this, > so > if it did, we need to fix that. > dmesg log attached to the bugzilla as: https://bugzilla.kernel.org/attachment.cgi?id=290655 (to keep everything in one place). Thanks, -James