From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [Bug 199643] New: UBSAN: Undefined behaviour in
 ./include/net/route.h:240:2
Date: Thu, 7 Jun 2018 17:28:59 -0700
Message-ID: <e05416a5-b4fe-6e9f-cefc-86848fb146cf@gmail.com>
References: <20180508.001251.2189714817072679386.davem@davemloft.net>
 <b0e36641-b84f-0bde-4c2d-125a412b5bb2@gmail.com>
 <20180607170623.6e5d56b5@cakuba.netronome.com>
 <20180607.201142.389815374334636334.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dsahern@gmail.com, stephen@networkplumber.org,
        netdev@vger.kernel.org
To: David Miller <davem@davemloft.net>, jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f41.google.com ([74.125.83.41]:46647 "EHLO
        mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752300AbeFHA3B (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 7 Jun 2018 20:29:01 -0400
Received: by mail-pg0-f41.google.com with SMTP id d2-v6so5525587pga.13
        for <netdev@vger.kernel.org>; Thu, 07 Jun 2018 17:29:01 -0700 (PDT)
In-Reply-To: <20180607.201142.389815374334636334.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/07/2018 05:11 PM, David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Thu, 7 Jun 2018 17:06:23 -0700
> 
>> [  293.213661]  ip_send_unicast_reply+0x1b67/0x1d0e
> 
> This calls ip_setup_cork() which can NULL out the 'rt' route
> pointer.  Hmmm... :-/
> 


UBSAN seems unhappy  with dst being NULL in :

dst_release(&rt->dst);

But the code obviously is ready for dst being NULL, it is even documented :)