From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01A97C433FE for ; Mon, 7 Dec 2020 10:24:00 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F0A52311A for ; Mon, 7 Dec 2020 10:23:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F0A52311A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.46112.81792 (Exim 4.92) (envelope-from ) id 1kmDgG-0005ch-Sh; Mon, 07 Dec 2020 10:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 46112.81792; Mon, 07 Dec 2020 10:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDgG-0005ca-Ny; Mon, 07 Dec 2020 10:23:44 +0000 Received: by outflank-mailman (input) for mailman id 46112; Mon, 07 Dec 2020 10:23:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmDgF-0005cU-So for xen-devel@lists.xenproject.org; Mon, 07 Dec 2020 10:23:43 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 179f1264-87fb-4104-b38d-51b17b54ac20; Mon, 07 Dec 2020 10:23:43 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E444AC90; Mon, 7 Dec 2020 10:23:42 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 179f1264-87fb-4104-b38d-51b17b54ac20 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607336622; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQnepCiatrE8sJzTWk61do2J/pPpjtZ2Ei47QgkZUTM=; b=KnPyb8/oUA3AGG3RmXwfs2LZ/TfWPyU6an5SHK7SxPjNLmkAC/InvtijVoEvi+1CmBEpai OmLlsDv3PqTesY9Cg3ODnsgmAjut/y+l/KLQ3OtNY0gYUeHIYPcEBE4glx693aK2RwnLlf 3rgOB1w1yQUVSwioZgrERK1NOEkl5Ao= Subject: Re: [PATCH v2 7/8] lib: move bsearch code To: Julien Grall Cc: George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Andrew Cooper References: <87a20884-5a76-a664-dcc9-bd4becee40b3@suse.com> <44ffc041-cacd-468e-a835-f5b2048bb201@xen.org> <2cf3a90d-f463-41f8-f861-6ef00279b204@suse.com> <2419eccf-c696-6aa1-ada4-0f7bd6bc5657@xen.org> <77534dc3-bdd6-f884-99e3-90dc9b02a81f@citrix.com> <59a4e1c1-ea39-1846-92ae-92560db4b1fb@xen.org> From: Jan Beulich Message-ID: Date: Mon, 7 Dec 2020 11:23:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <59a4e1c1-ea39-1846-92ae-92560db4b1fb@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 24.11.2020 17:57, Julien Grall wrote: > On 24/11/2020 00:40, Andrew Cooper wrote: >> On a totally separate point,  I wonder if we'd be better off compiling >> with -fgnu89-inline because I can't see any case we're we'd want the C99 >> inline semantics anywhere in Xen. > > This was one of my point above. It feels that if we want to use the > behavior in Xen, then it should be everywhere rather than just this helper. I'll be committing the series up to patch 6 in a minute. It remains unclear to me whether your responses on this sub-thread are meant to be an objection, or just a comment. Andrew gave his R-b despite this separate consideration, and I now also have an ack from Wei for the entire series. Please clarify. Or actually I only thought I could commit a fair initial part of the series - I'm still lacking Arm-side acks for patches 2 and 3 here. Jan