From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8006BC4363C for ; Mon, 21 Sep 2020 20:35:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23983218AC for ; Mon, 21 Sep 2020 20:35:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="T1FQV4tp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23983218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKSWO-0001Sd-9C; Mon, 21 Sep 2020 20:34:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKSWM-0001S7-RS for xen-devel@lists.xenproject.org; Mon, 21 Sep 2020 20:34:46 +0000 X-Inumbo-ID: 72ba40b8-b8e2-4a29-aebd-e653223906f3 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 72ba40b8-b8e2-4a29-aebd-e653223906f3; Mon, 21 Sep 2020 20:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1600720486; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ZYUvee04j2heAqbtOalg6aDsC6imyQhcvAD3gz1E+5M=; b=T1FQV4tpA0XBbOl0eh3SEZqNVLzefR1JMOgH6NO5QuaS7Ot9Xje1fOmY I5XdNJMYTIABmuwT1E9sCldO+CmOmUeIKXpk8HhTHZSxuGUkC3GIgiD61 +Pq0jB/g9j1iGlN/VLMZoJwiL09nJGC5KOLHYIn4F12gpj6PUw5r8B6PA s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: UklDgMt6pD81Ss8zhelVfAFz+UVPlrEj+1sCKY4EkayatPC8e9nMsk0dz9HBmeVArhaA3LDeqO YWVyF4g9v+fAmMnV2LrsgoN8b3gh4wZI6A72VwSGfU61sV6o6N2ejA1lGObDGjdfh3zZS2KBaj e0zTvXeBXRyV+jzbS4i4Revy0+Q/FmqvJetqHXiV/RhHbzf3hTwPmipcXoJzByw6lj0mmi+Pp4 jsm3lHrdbzWpCKHNqDuzNlPYJ+ezLfU47Ikav6ET3+dAX6P0tJ/BMNB8hn/S92KS6INTZCdqrs fnA= X-SBRS: 2.7 X-MesageID: 27537140 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,287,1596513600"; d="scan'208";a="27537140" Subject: Re: [PATCH v4 3/4] xen: Remove mfn_to_gmfn macro To: Julien Grall , CC: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , "Jan Beulich" , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu References: <20200921180214.4842-1-julien@xen.org> <20200921180214.4842-4-julien@xen.org> From: Andrew Cooper Message-ID: Date: Mon, 21 Sep 2020 21:34:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200921180214.4842-4-julien@xen.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To FTLPEX02CL05.citrite.net (10.13.108.178) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21/09/2020 19:02, Julien Grall wrote: > From: Julien Grall > > On x86, mfn_to_gmfn can be replaced with mfn_to_gfn. On Arm, there are > no more call to mfn_to_gmfn, so the helper can be dropped. The previous patch dropped the mfn_to_gmfn() call from the domain shared info path, but without a hunk adjusting the innards of memory_exchange(), this is going to break the x86 build. > At the same time rework a comment in Arm code that does not make sense. > > Signed-off-by: Julien Grall To save a round trip, Acked-by: Andrew Cooper with the appropriate hunk to memory_exchange(). Alternatively, it might make sense to fold the adjustment into patch 1 which is perhaps more obvious, given the insertion of an is_pv_domain() check. ~Andrew