From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C92FCC433F5 for ; Mon, 22 Nov 2021 08:52:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234704AbhKVIzq (ORCPT ); Mon, 22 Nov 2021 03:55:46 -0500 Received: from mga14.intel.com ([192.55.52.115]:59390 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238906AbhKVIzp (ORCPT ); Mon, 22 Nov 2021 03:55:45 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="234983988" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="234983988" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:39 -0800 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="739117842" Received: from djcarton-mobl.ger.corp.intel.com (HELO [10.252.21.92]) ([10.252.21.92]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:36 -0800 Message-ID: Date: Mon, 22 Nov 2021 08:52:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() Content-Language: en-GB To: Dan Carpenter , Jani Nikula Cc: Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , Maarten Lankhorst , =?UTF-8?Q?Christian_K=c3=b6nig?= , Jason Ekstrand , Oak Zeng , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org References: <20211122061438.GA2492@kili> From: Matthew Auld In-Reply-To: <20211122061438.GA2492@kili> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 22/11/2021 07:41, Dan Carpenter wrote: > This function returns a bool type so returning -EBUSY is equivalent to > returning true. It should return false instead. > > Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") > Signed-off-by: Dan Carpenter Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B06C9C433EF for ; Mon, 22 Nov 2021 08:52:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B45266E888; Mon, 22 Nov 2021 08:52:40 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09CD66E885; Mon, 22 Nov 2021 08:52:40 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="234983987" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="234983987" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:39 -0800 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="739117842" Received: from djcarton-mobl.ger.corp.intel.com (HELO [10.252.21.92]) ([10.252.21.92]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:36 -0800 Message-ID: Date: Mon, 22 Nov 2021 08:52:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() Content-Language: en-GB To: Dan Carpenter , Jani Nikula References: <20211122061438.GA2492@kili> From: Matthew Auld In-Reply-To: <20211122061438.GA2492@kili> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , kernel-janitors@vger.kernel.org, Jason Ekstrand , =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , David Airlie , =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org, Oak Zeng , dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 22/11/2021 07:41, Dan Carpenter wrote: > This function returns a bool type so returning -EBUSY is equivalent to > returning true. It should return false instead. > > Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") > Signed-off-by: Dan Carpenter Reviewed-by: Matthew Auld From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F07EC433EF for ; Mon, 22 Nov 2021 08:52:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C32836E885; Mon, 22 Nov 2021 08:52:41 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09CD66E885; Mon, 22 Nov 2021 08:52:40 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="234983987" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="234983987" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:39 -0800 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="739117842" Received: from djcarton-mobl.ger.corp.intel.com (HELO [10.252.21.92]) ([10.252.21.92]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 00:52:36 -0800 Message-ID: Date: Mon, 22 Nov 2021 08:52:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-GB To: Dan Carpenter , Jani Nikula References: <20211122061438.GA2492@kili> From: Matthew Auld In-Reply-To: <20211122061438.GA2492@kili> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , David Airlie , =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 22/11/2021 07:41, Dan Carpenter wrote: > This function returns a bool type so returning -EBUSY is equivalent to > returning true. It should return false instead. > > Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") > Signed-off-by: Dan Carpenter Reviewed-by: Matthew Auld