From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C349CC6FD18 for ; Wed, 29 Mar 2023 23:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230290AbjC2X6n (ORCPT ); Wed, 29 Mar 2023 19:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbjC2X6n (ORCPT ); Wed, 29 Mar 2023 19:58:43 -0400 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8049759E7 for ; Wed, 29 Mar 2023 16:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680134322; x=1711670322; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=l3K4Kt/FO4iBIKq8VgAcGfFNIvXYccX/xQem9blms08=; b=iN0/9zeAznYhbUZXkkd5ZwXC51rfovnITWRz+bWxbNSb2sbSOSV9Nnu1 RYpRsLsotdDxFPkUFGgnq06TIlHvUvzB0u3jjV0ljmrP39jJa/TCPukb+ jtfIfMygyzY9Ws2dmcvn3iU3hxZe3bRIZf4HIve+9KO/b7z6xZz7oZMtj KxdfYIsfqK/BS/UsXPf/xpnJcmQecrGpm9tZyER6HQGHo8eb208SUEfdi WgdKqtOavQMJ22WPcbaPluttjUtp96muWXIgZw9JgDyxeO+vDRXnvHvX9 sHMhNWTZjlV1hQ3THym0RSFAqwqrLrHZERPTKnmUsKt0FfLWDnwKaKpxH A==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="338905088" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:58:40 +0800 IronPort-SDR: c5/XjCdv6OGi/jw5Ym165Ewiaho195qgSxT8yQPJkIo0/vpcVHYbcTEo1uF9IzXmx4A8sjSwvy Umw1gYLp9KqaQgDwKVtVwmq8u+yVYXpz2an+J0uzb/LP4oLEsvMBgNPZJo/PCqPzTM2CstKHGX AKwLSUzlx/mKz/ouRKaZm8Zt2JUvHGG3k7DanmXMePt2e4wNrZ/x3hviATskAvATLpIFV/hkH2 re31vGh2n1PU+09F99/Zq3SPMEfp/4uPEYJAGxPRxJTa0cV3tjzZu3hj8NxjAhAdhI00h7Jhss Lf0= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:14:49 -0700 IronPort-SDR: 9Sgk0a3t/mF800LtGJapz0Wczdh5hGcXYy+o2O27DoLU7stVIKHNPvqXQZ7mk/ve9JpHoUKMLD qorzqWUT1VQEEu4+Hq3erG9LJwRFs7GJFniDdMWTlOyyd7R/RnyywOISiyNMcUkuybhGgx/EoP uuaAkUncMDW7/H7k43m1jxpXVya2DnTQyQSPjqGmr8ssnsdfDt/VIDar/lmDB+FBXFEl7TxwaS WRZLCtP526BWSUrERDw0gDX7wWIZSByctvmBSV/j/vaZWFEf2sXz0Ma7o2a0dKlkIVNyhnT+2X Yd0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:58:41 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn3RN22RCz1RtW5 for ; Wed, 29 Mar 2023 16:58:40 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680134319; x=1682726320; bh=l3K4Kt/FO4iBIKq8VgAcGfFNIvXYccX/xQe m9blms08=; b=Z/xEynILGjmaBwHeY3zVoiULWBo3e30fvx6iPr3Zx6Wj7JD/AeL AlMf5sdtT16U+2fy8eU1VAKFPpBudi6kurLPAGIzKE9drC6EeQeqgjCFT9E4ojVy TQQB5cTsm8u17203jJLawINrINsD7UcNkKFsfaNP554pst6fe7CQNFLH/4gnZpHW cIc0ZPn8qBqY/PUa8EZzINk2DyDa38pZrA2IHJhRPZg8wTakQ8CRn+WKb8IUyz/t SBylBZXjhtrWwGcmAPksFGN22jMLMsZOAJeZ+IGqQ1Xj5XyaZ0SgGrhmF2I15zcu VVtWA4JMjP+QyIuov+vQWELqF/Tx0+aFYxg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rbWKEU4AeiWM for ; Wed, 29 Mar 2023 16:58:39 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn3RJ0pDLz1RtVm; Wed, 29 Mar 2023 16:58:35 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:58:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 19/19] block: mark bio_add_page as __must_check Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 3/30/23 02:06, Johannes Thumshirn wrote: > Now that all users of bio_add_page check for the return value, mark > bio_add_page as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6A14C6FD18 for ; Wed, 29 Mar 2023 23:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680134331; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=obeKMuYLkVtRZfNQlhp1iH4aY8lDdvr1tVS5i9STI80=; b=gd8djh7zGwEV60BjYQ4+5tLS8NWOnNcBJnRAFjNAmnAXY2C5AMpGKgB3HnEoRZmqz62LHJ XCOPIIzVp0Ms5cNanpKWjivuY8g+6qHl1nNFNjD6w3hzkPoYhVm1LkItik6KVjgCzqaMRS JKwGal2uKGqCOlVMdVC0oGkYRjAoJXI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-360-uN8aqJ7yOFyJFBd1sc4GtQ-1; Wed, 29 Mar 2023 19:58:48 -0400 X-MC-Unique: uN8aqJ7yOFyJFBd1sc4GtQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78C6E3C0DDA1; Wed, 29 Mar 2023 23:58:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B76CC15BA0; Wed, 29 Mar 2023 23:58:46 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E97781946588; Wed, 29 Mar 2023 23:58:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6CCA21946587 for ; Wed, 29 Mar 2023 23:58:44 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 48EF214171BE; Wed, 29 Mar 2023 23:58:44 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4137F14171BB for ; Wed, 29 Mar 2023 23:58:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2C8C8533E3 for ; Wed, 29 Mar 2023 23:58:43 +0000 (UTC) Received: from esa4.hgst.iphmx.com (esa4.hgst.iphmx.com [216.71.154.42]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-UtHhIqbEN6eHZAEw3CLH_Q-2; Wed, 29 Mar 2023 19:58:42 -0400 X-MC-Unique: UtHhIqbEN6eHZAEw3CLH_Q-2 X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="225114696" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:58:40 +0800 IronPort-SDR: x3doMzz7xm9MN4i3nVzE18qTYEmK4qiPQtm2WQNu/8YM9nwKwaS2YrQeiTaV4QeJBnYE0xCEfG xxWYKGg0WhRzkQZKbwzGSNFaNb5fVL+FmqH1jPbU7aBsKjdefCbkKq0wwS5Y5yY2F2lLwbkiop vTgh8GUi7eUpkSOuKoG18lzKNzg2o4W1oeiGafhwwFDv5raL4lq9yJODCPQcQ/OOUorcBmSugk MiQN26RBBiJAVqUeGQAxifiPxvjqvAFiaIvccGQ/vNzHcqOdNfA+XgxfRNlFFynFjnkdZYgbq9 cNQ= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:09:08 -0700 IronPort-SDR: gq/x/u73oljyyaAsiDRrbdhgmrjXlmbRWmeR9bzoqAEUP2Phv9j6PsLfPeCvjMxVMm0f/kcqom pZu2Dada3+sHfkeHlv3ISrlgquyn9imtIDQYIhROpIgyv+MLLc0UgG8dWNdLRLGzOMjZBRxukX qivoil9cGQAPp5SsmfsvlRbaOwSZkDQ9hDT8FnG7EfKgjql9j4z7qNTFT4xlUfB+JYhLQ6wmgf Ap5sbaKUqVNWUi6buZhnu1BRLKBF4V3ZRCTW7K49Sl/Bj9juzwSJBaur4fxPYwwRsG0Wn5DvYs Ynw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:58:41 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn3RM6LRHz1RtVv for ; Wed, 29 Mar 2023 16:58:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KgGBuEmA6BSH for ; Wed, 29 Mar 2023 16:58:39 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn3RJ0pDLz1RtVm; Wed, 29 Mar 2023 16:58:35 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:58:35 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Johannes Thumshirn , Jens Axboe References: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Subject: Re: [dm-devel] [PATCH 19/19] block: mark bio_add_page as __must_check X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-raid@vger.kernel.org, jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Chaitanya Kulkarni , Andreas Gruenbacher , Song Liu , Dave Kleikamp , Mike Snitzer , Matthew Wilcox , Ming Lei , linux-block@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, David Sterba , linux-fsdevel@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org, Bob Peterson Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 3/30/23 02:06, Johannes Thumshirn wrote: > Now that all users of bio_add_page check for the return value, mark > bio_add_page as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Date: Thu, 30 Mar 2023 08:58:35 +0900 Subject: [Cluster-devel] [PATCH 19/19] block: mark bio_add_page as __must_check In-Reply-To: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> References: <350bd9c62ce575267a2b38625ab767c332429bc1.1680108414.git.johannes.thumshirn@wdc.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 3/30/23 02:06, Johannes Thumshirn wrote: > Now that all users of bio_add_page check for the return value, mark > bio_add_page as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research