All of lore.kernel.org
 help / color / mirror / Atom feed
From: VenomVendor <info@venomvendor.com>
To: git@vger.kernel.org
Subject: committer-date-is-author-date flag removes email in "Commit"
Date: Fri, 23 Oct 2020 11:18:51 +0530	[thread overview]
Message-ID: <e08df0d5792ab70a9158be32cfa28696@venomvendor.com> (raw)

committer-date-is-author-date flag removes email in "Commit"


What did you do before the bug happened? (Steps to reproduce your issue)
* Create empty repo using `git init`
* Make few commits, at least two
* execute `git log --format=fuller`
* Notice the log, with "Author", "AuthorDate", "Commit", "CommitDate"
* Note, "Commit"
* execute `git rebase --committer-date-is-author-date HEAD~1`
* execute `git log --format=fuller`
* Note, email from "Commit" is empty <>


What did you expect to happen? (Expected behavior)
* Email must not be removed.

What happened instead? (Actual behavior)
* email got removed/replaced with empty `< >`

What's different between what you expected and what actually happened?

Expected:
```
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:05 2020 -0200
Commit:     VenomVendor <info@VenomVendor.com>
CommitDate: Thu Oct 22 19:41:05 2020 -0200
```

Happened (Missing email in Commit)
```
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:05 2020 -0200
Commit:     VenomVendor <>
CommitDate: Thu Oct 22 19:41:05 2020 -0200
```

Anything else you want to add:

```
$ cd ~

$ mkdir committer-date-is-author-date-bug

$ cd committer-date-is-author-date-bug

$ git --version
git version 2.29.0

$ git init
Initialized empty Git repository in 
~/committer-date-is-author-date-bug/.git/

$ git log --format=fuller
fatal: your current branch 'master' does not have any commits yet


$ TEXT=1; echo "${TEXT}" > sample.txt && git add . && git commit -m 
"${TEXT}"
[master (root-commit) 20731cb] 1
  1 file changed, 1 insertion(+)
  create mode 100644 sample.txt


$ TEXT=2; echo "${TEXT}" > sample.txt && git add . && git commit -m 
"${TEXT}"
[master e3d8ce8] 2
  1 file changed, 1 insertion(+), 1 deletion(-)


$ TEXT=3; echo "${TEXT}" > sample.txt && git add . && git commit -m 
"${TEXT}"
[master 30f2b84] 3
  1 file changed, 1 insertion(+), 1 deletion(-)


$ git log --format=fuller
commit 30f2b84e360d2ea79fe3355b5fbfa5cdb401c65f (HEAD -> master)
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:05 2020 -0200
Commit:     VenomVendor <info@VenomVendor.com>
CommitDate: Thu Oct 22 19:41:05 2020 -0200

     3

commit e3d8ce88ea25b14cf2840ccd41cebc8f68663b8e
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:02 2020 -0200
Commit:     VenomVendor <info@VenomVendor.com>
CommitDate: Thu Oct 22 19:41:02 2020 -0200

     2

commit 20731cb051e42dd5435dec4157aa58203e5fc60d
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:40:59 2020 -0200
Commit:     VenomVendor <info@VenomVendor.com>
CommitDate: Thu Oct 22 19:40:59 2020 -0200

     1


$ git rebase --committer-date-is-author-date HEAD~2
Current branch master is up to date, rebase forced.
Successfully rebased and updated refs/heads/master.


$ git log --format=fuller
commit be24ee5cd9b76b0f11599b4f8af2609f6c5f3b06 (HEAD -> master)
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:05 2020 -0200
Commit:     VenomVendor <>
CommitDate: Thu Oct 22 19:41:05 2020 -0200

     3

commit c45d01b6969281d11fc78f60cb0c4d830f216892
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:41:02 2020 -0200
Commit:     VenomVendor <>
CommitDate: Thu Oct 22 19:41:02 2020 -0200

     2

commit 20731cb051e42dd5435dec4157aa58203e5fc60d
Author:     VenomVendor <info@VenomVendor.com>
AuthorDate: Thu Oct 22 19:40:59 2020 -0200
Commit:     VenomVendor <info@VenomVendor.com>
CommitDate: Thu Oct 22 19:40:59 2020 -0200

     1
```

Please review the rest of the bug report below.
You can delete any lines you don't wish to share.


[System Info]
git version:
git version 2.29.0
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh
uname: Darwin 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 
PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
compiler info: clang: 12.0.0 (clang-1200.0.32.2)
libc info: no libc information available
$SHELL (typically, interactive shell): /bin/zsh


[Enabled Hooks]

-VenomVendor

             reply	other threads:[~2020-10-23  6:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  5:48 VenomVendor [this message]
2020-10-23  7:07 ` committer-date-is-author-date flag removes email in "Commit" Jeff King
2020-10-23  7:08   ` [PATCH 1/3] t3436: check --committer-date-is-author-date result more carefully Jeff King
2020-10-23 10:10     ` Phillip Wood
2020-10-23  7:09   ` [PATCH 2/3] am: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23  7:26     ` [PATCH 4/3] am, sequencer: stop parsing our own committer ident Jeff King
2020-10-23  7:45       ` Jeff King
2020-10-23 17:29         ` Taylor Blau
2020-10-26 16:25         ` Johannes Schindelin
2020-10-27  7:23           ` Jeff King
2020-10-23 14:06       ` Phillip Wood
2020-10-26 17:12       ` Junio C Hamano
2020-10-27  7:24         ` Jeff King
2020-10-23  7:10   ` [PATCH 3/3] rebase: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23 15:23   ` committer-date-is-author-date flag removes email in "Commit" Junio C Hamano
2020-10-23 17:32     ` Phillip Wood
2020-10-23 17:59       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e08df0d5792ab70a9158be32cfa28696@venomvendor.com \
    --to=info@venomvendor.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.