All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	Tom O'Rourke <Tom.O'Rourke@intel.com>
Subject: Re: [PATCH v4 24/26] drm/i915/slpc: Enable SLPC, where supported
Date: Thu, 15 Sep 2016 16:13:14 +0530	[thread overview]
Message-ID: <e08ecfa8-d939-4851-734a-7e4edf48f93c@intel.com> (raw)
In-Reply-To: <20160909164539.GG20027@nuc-i3427.alporthouse.com>



On 9/9/2016 10:15 PM, Chris Wilson wrote:
> On Fri, Sep 09, 2016 at 06:21:43PM +0530, Sagar Arun Kamble wrote:
>> From: Tom O'Rourke <Tom.O'Rourke@intel.com>
>>
>> This patch makes SLPC enabled by default on
>> platforms with hardware/firmware support.
>>
>> v1: Removing warning "enable_slpc < 0" as it is
>> set to -1 with this patch now. This was caught by CI BAT.
>>
>> Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
>> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_params.c | 4 ++--
>>   drivers/gpu/drm/i915/intel_guc.h   | 1 -
>>   2 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
>> index 72b3097..7b3b3fd 100644
>> --- a/drivers/gpu/drm/i915/i915_params.c
>> +++ b/drivers/gpu/drm/i915/i915_params.c
>> @@ -36,7 +36,7 @@ struct i915_params i915 __read_mostly = {
>>   	.enable_dc = -1,
>>   	.enable_fbc = -1,
>>   	.enable_execlists = -1,
>> -	.enable_slpc = 0,
>> +	.enable_slpc = -1,
>>   	.enable_hangcheck = true,
>>   	.enable_ppgtt = -1,
>>   	.enable_psr = -1,
>> @@ -135,7 +135,7 @@ MODULE_PARM_DESC(enable_execlists,
>>   module_param_named_unsafe(enable_slpc, i915.enable_slpc, int, 0400);
>>   MODULE_PARM_DESC(enable_slpc,
>>   	"Override single-loop-power-controller (slpc) usage. "
>> -	"(-1=auto, 0=disabled [default], 1=enabled)");
>> +	"(-1=auto [default], 0=disabled, 1=enabled)");
>>   
>>   module_param_named_unsafe(enable_psr, i915.enable_psr, int, 0600);
>>   MODULE_PARM_DESC(enable_psr, "Enable PSR "
>> diff --git a/drivers/gpu/drm/i915/intel_guc.h b/drivers/gpu/drm/i915/intel_guc.h
>> index 6e24e60..e9e1163 100644
>> --- a/drivers/gpu/drm/i915/intel_guc.h
>> +++ b/drivers/gpu/drm/i915/intel_guc.h
>> @@ -151,7 +151,6 @@ struct intel_guc {
>>   
>>   static inline int intel_slpc_enabled(void)
>>   {
>> -	WARN_ON(i915.enable_slpc < 0);
> Remove this from the original path, and make it return a bool, since
> i915.enable_slpc is always sanitized.
>
> The this patch simply becomes flipping the switch.
Will update this.
> -Chris
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-09-15 10:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 12:51 [PATCH v4 00/26] Add support for GuC-based SLPC Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 01/26] drm/i915: Remove RPM suspend dependency on rps.enabled and related changes Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 02/26] drm/i915/slpc: Expose guc functions for use with SLPC Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 03/26] drm/i915/slpc: Add has_slpc capability flag Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 04/26] drm/i915/slpc: Add SKL SLPC Support Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 05/26] drm/i915/slpc: Add enable_slpc module parameter Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 06/26] drm/i915/slpc: Sanitize SLPC version Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 07/26] drm/i915/slpc: Use intel_slpc_* functions if supported Sagar Arun Kamble
2016-09-09 17:20   ` Chris Wilson
2016-09-15 10:40     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 08/26] drm/i915/slpc: Enable SLPC in guc " Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 09/26] drm/i915/slpc: If using SLPC, do not set frequency Sagar Arun Kamble
2016-09-09 17:21   ` Chris Wilson
2016-09-15 10:41     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 10/26] drm/i915/slpc: Allocate/Release/Initialize SLPC shared data Sagar Arun Kamble
2016-09-09 17:08   ` Chris Wilson
2016-09-15 10:41     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 11/26] drm/i915/slpc: Update sysfs/debugfs interfaces for frequency parameters Sagar Arun Kamble
2016-09-09 17:13   ` Chris Wilson
2016-09-15 10:41     ` Kamble, Sagar A
2016-09-15 12:00       ` Chris Wilson
2016-09-09 12:51 ` [PATCH v4 12/26] drm/i915/slpc: Send reset event Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 13/26] drm/i915/slpc: Send shutdown event Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 14/26] drm/i915/slpc: Add slpc_status enum values Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 15/26] drm/i915/slpc: Add parameter unset/set/get functions Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 16/26] drm/i915/slpc: Add slpc support for max/min freq Sagar Arun Kamble
2016-09-09 16:49   ` Chris Wilson
2016-09-15 10:42     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 17/26] drm/i915/slpc: Add enable/disable debugfs for slpc Sagar Arun Kamble
2016-09-09 16:54   ` Chris Wilson
2016-09-15 10:42     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 18/26] drm/i915/slpc: Add i915_slpc_info to debugfs Sagar Arun Kamble
2016-09-09 17:14   ` Chris Wilson
2016-09-15 10:43     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 19/26] drm/i915/slpc: Add Broxton SLPC support Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 20/26] drm/i915/slpc: Only Enable GTPERF, Disable DCC, Balancer, IBC, FPS Stall Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 21/26] drm/i915/slpc: Update freq min/max softlimits Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 22/26] drm/i915/slpc: Check GuC load status in SLPC active check Sagar Arun Kamble
2016-09-09 12:51 ` [PATCH v4 23/26] drm/i915/slpc: Keep RP SW Mode enabled while disabling rps Sagar Arun Kamble
2016-09-09 16:58   ` Chris Wilson
2016-09-15 10:44     ` Kamble, Sagar A
2016-09-09 12:51 ` [PATCH v4 24/26] drm/i915/slpc: Enable SLPC, where supported Sagar Arun Kamble
2016-09-09 16:45   ` Chris Wilson
2016-09-15 10:43     ` Kamble, Sagar A [this message]
2016-09-09 12:51 ` [PATCH v4 25/26] drm/i915: Add sysfs interface to know the HW requested frequency Sagar Arun Kamble
2016-09-09 16:43   ` Chris Wilson
2016-09-15 10:44     ` Kamble, Sagar A
2016-09-15 12:01       ` Chris Wilson
2016-09-09 12:51 ` [PATCH v4 26/26] drm/i915: Mark GuC load status as PENDING in i915_drm_resume_early Sagar Arun Kamble
2016-09-09 16:59   ` Chris Wilson
2016-09-09 13:24 ` ✓ Fi.CI.BAT: success for Add support for GuC-based SLPC (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e08ecfa8-d939-4851-734a-7e4edf48f93c@intel.com \
    --to=sagar.a.kamble@intel.com \
    --cc=Tom.O'Rourke@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.