From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2]) by mail.openembedded.org (Postfix) with ESMTP id B920674C00 for ; Fri, 8 Jun 2018 06:33:25 +0000 (UTC) Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w586XMVd005820 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Jun 2018 08:33:22 +0200 Received: from [192.168.253.100] ([163.242.57.90]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTPS id w586XLGu022940 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 8 Jun 2018 08:33:22 +0200 To: Alexander Kanavin , "openembedded-core@lists.openembedded.org" References: <20180607072501.27158-1-andrej.valek@siemens.com> <20180607073209.27240-1-andrej.valek@siemens.com> <59452b23-7470-588c-75fb-7445aaa13ba1@linux.intel.com> From: Andrej Valek Openpgp: preference=signencrypt Message-ID: Date: Fri, 8 Jun 2018 08:33:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <59452b23-7470-588c-75fb-7445aaa13ba1@linux.intel.com> Subject: Re: [PATCH v2] feat(openssl-1.1): rework packaging X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 06:33:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Alex, On 06/07/18 15:13, Alexander Kanavin wrote: > On 06/07/2018 10:32 AM, Andrej Valek wrote: >> -do_install_append_class-native () { >> # Install a custom version of c_rehash that can handle sysroots properly. >> # This version is used for example when installing ca-certificates during >> # image creation. >> install -Dm 0755 ${WORKDIR}/openssl-c_rehash.sh ${D}${bindir}/c_rehash >> sed -i -e 's,/etc/openssl,${sysconfdir}/ssl,g' ${D}${bindir}/c_rehash > > Why is this merged into the main do_install()? Please explain. c_rehash was not working on target exactly as on native. (Same perl erros). So I have copied this stuff from 1.0.2, it is working on both platforms as well. > >> + # Create SSL structure >> + install -d ${D}${sysconfdir}/ssl/ >> + mv ${D}${libdir}/ssl-1.1/openssl.cnf \ >> + ${D}${libdir}/ssl-1.1/certs \ >> + ${D}${libdir}/ssl-1.1/private \ >> + \ >> + ${D}${sysconfdir}/ssl/ >> + ln -sf ${sysconfdir}/ssl/certs ${D}${libdir}/ssl-1.1/certs >> + ln -sf ${sysconfdir}/ssl/private ${D}${libdir}/ssl-1.1/private >> + ln -sf ${sysconfdir}/ssl/openssl.cnf ${D}${libdir}/ssl-1.1/openssl.cnf > > Please explain this change as well. Resend the patch with the > explanations included in the commit log or (better), the recipe itself. During splitting to packages I have compared files with 1.0.2 and I wanted to have same file structure. Anyway Debian is using this location without modification and You don't like it, so I will revert it. But note that bash-completion has the /etc path for openssl.cnf as default search path... . > > I would like to keep the new openssl recipe short and simple, and so > anything that adds lines and complication should be well justified. :) > > Alex > BR, Andrej