From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28BEC64E7C for ; Wed, 2 Dec 2020 14:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97899221EB for ; Wed, 2 Dec 2020 14:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388988AbgLBOKU (ORCPT ); Wed, 2 Dec 2020 09:10:20 -0500 Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]:59723 "EHLO lb1-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389011AbgLBOKU (ORCPT ); Wed, 2 Dec 2020 09:10:20 -0500 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id kSp0kEZ3PN7XgkSp3ktOxl; Wed, 02 Dec 2020 15:09:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1606918174; bh=8It+mUhWcNhF0vzprQdPV2Le0KNPLwCD1U2+v68bzUo=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=vXCSGQe7jYBcuWZBYxKr7+xUM8qqIvOPES4wii+Mj/wKErDcYpT98eOqP5nLVNl1F +DPLfKDIsbHytSY0smL6jKSr0E9Um8Q0tf3SMHOQy+WApnrhuoB7tnMeLOr5CQkQkv G4ixqlPOy2QOC9axIDZLYzyQrh4saIehyRU+uZHrATWOn0sBmB14MLJzPg9M+0ZSjU 9tr6uHCnRHH3kY7HMDeF5kLID3yPxpGGCh8R5Uxg1huU38zxnsUn80ja5tT7l3bztz Lsgm3afZ2/t9H48AJh+Pcc2UpLiLZb11TNl0dyD2LIYYJqxvO1mipVJi7hQAILubld W+FkKGe5cirpw== Subject: Re: [PATCH 1/4] v4l2-ctrl: Make display delay and display enable std controls To: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Kyungmin Park , Kamil Debski , Ezequiel Garcia , Nicolas Dufresne , Marek Szyprowski References: <20201109173541.10016-1-stanimir.varbanov@linaro.org> <20201109173541.10016-2-stanimir.varbanov@linaro.org> From: Hans Verkuil Message-ID: Date: Wed, 2 Dec 2020 15:09:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201109173541.10016-2-stanimir.varbanov@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfH4z1F2rSCh2o7ovDglbE7I63h5pvR0H4mAQBXX/CsvJ5Ai4XMH7fKhDjKKSS6Wubw6B6axvK3MnaxI+Z5fYdTMVz8rVmsKZhmxMavbwNcupviDfc6vf 4bRzpJBgOGj8aH+6/9Tv/HpValbnVb/TjYR8ASRh2ejbVVLR/JGbrGmvVOaw1yVE8QQ8we3EJyBCzRgZqcAjiK7K22P1TcIWYgMw7epXSl7KW6o/PxVWYZ8F +yz70WxsT+0wgx2qLiQsRpeGOWjAU2FYvgyWcKsE550ZBXhqcdEwhonkJVg3btdO9h+ITaTvMnyfB2syuLBCbtyDho5Unvbh8jMyUxophvHTtjOB8Fffckyy ddhg+CqkQX/qTBR75JGikszM5/awJ4uh9aoGIPL2h1f4s/5X9GO/8dWPoPhLOPX1NOj+iFrEAGlDxxDKQGYOjcCdBzKSbKI71A91YW++Qs5SVoC0e5Nis09Z oDdsquDlsjYoeVRdqzg+1Ov/DgOvLMsfduopx5rZu7FApqHaJC74eairhQmCuws9nGzn8tCNP9wxPJsZUsSvgSWt3X++Pdb0JuvCQA== Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 09/11/2020 18:35, Stanimir Varbanov wrote: > Make display delay and display delay enable MFC controls standard v4l > controls. This will allow reuse of the controls for other decoder > drivers. Also the new proposed controls are now codec agnostic because > they could be used for any codec. > > Signed-off-by: Stanimir Varbanov > --- > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 15 +++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ > include/uapi/linux/v4l2-controls.h | 2 ++ > 3 files changed, 21 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > index ce728c757eaf..82c9cda40270 100644 > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > @@ -679,6 +679,21 @@ enum v4l2_mpeg_video_frame_skip_mode - > otherwise the decoder expects a single frame in per buffer. > Applicable to the decoder, all codecs. > > +``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE (boolean)`` I'd use _DEC_ instead of _DECODER_. > + If the display delay is enabled then the decoder is forced to return > + a CAPTURE buffer (decoded frame) after processing a certain number > + of OUTPUT buffers. The delay can be set through > + ``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY``. This > + feature can be used for example for generating thumbnails of videos. > + Applicable to the decoder. Hmm. Is this: "after processing the first 'display delay' number of OUTPUT buffers." Or is this: "every 'display delay' number of OUTPUT buffers." I.e., is it a one-shot thing or a periodical thing? If it is a one-shot thing, then this should probably be a button type, not a boolean. > + > +``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY (integer)`` > + Display delay value for decoder. The decoder is forced to > + return a decoded frame after the set 'display delay' number of > + frames. If this number is low it may result in frames returned out > + of display order, in addition the hardware may still be using the > + returned buffer as a reference picture for subsequent frames. Can this be 0? And if so, what does that mean? > + > ``V4L2_CID_MPEG_VIDEO_H264_VUI_SAR_ENABLE (boolean)`` > Enable writing sample aspect ratio in the Video Usability > Information. Applicable to the H264 encoder. > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index bd7f330c941c..4a21802e026b 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -874,6 +874,8 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_MPEG_VIDEO_HEADER_MODE: return "Sequence Header Mode"; > case V4L2_CID_MPEG_VIDEO_MAX_REF_PIC: return "Max Number of Reference Pics"; > case V4L2_CID_MPEG_VIDEO_FRAME_SKIP_MODE: return "Frame Skip Mode"; > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY: return "Display Delay"; > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE: return "Display Delay Enable"; > case V4L2_CID_MPEG_VIDEO_H263_I_FRAME_QP: return "H263 I-Frame QP Value"; > case V4L2_CID_MPEG_VIDEO_H263_P_FRAME_QP: return "H263 P-Frame QP Value"; > case V4L2_CID_MPEG_VIDEO_H263_B_FRAME_QP: return "H263 B-Frame QP Value"; > @@ -1221,6 +1223,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > case V4L2_CID_FLASH_READY: > case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER: > case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE: > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE: > case V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_MB_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM: > @@ -1256,6 +1259,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > break; > case V4L2_CID_MPEG_VIDEO_MV_H_SEARCH_RANGE: > case V4L2_CID_MPEG_VIDEO_MV_V_SEARCH_RANGE: > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY: > *type = V4L2_CTRL_TYPE_INTEGER; > break; > case V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME: > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 7035f4fb182c..d6b19f8d0022 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -773,6 +773,8 @@ enum v4l2_mpeg_video_frame_skip_mode { > V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_LEVEL_LIMIT = 1, > V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_BUF_LIMIT = 2, > }; > +#define V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY (V4L2_CID_MPEG_BASE + 647) > +#define V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE (V4L2_CID_MPEG_BASE + 648) This will need to be rebased once this PR is merged: https://patchwork.linuxtv.org/project/linux-media/patch/d68da172-b251-000f-653d-38a8a4c7b715@xs4all.nl/ > > /* MPEG-class control IDs specific to the CX2341x driver as defined by V4L2 */ > #define V4L2_CID_MPEG_CX2341X_BASE (V4L2_CTRL_CLASS_MPEG | 0x1000) > Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA152C64E7B for ; Wed, 2 Dec 2020 14:11:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EE8421D7F for ; Wed, 2 Dec 2020 14:11:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EE8421D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=djLVVKzEGpLKUneC4MPbMKCHYi/jD3ZA48En/zts5Rk=; b=TgmD2yNdB9dxeBGD+QZsNGezy RiOxFbY99sQiwBc2ggT/1SGJ2S9jf85qhxBrCseA6fVv/lHSebpVywKgOd1HmH1nHE30pDCLXfDP1 SG3OUzvDj+Jq9nBHN1bZROSrP4xfJKTMTQw2RR+80ITMjIa3hIe4cIq3VcJfZgSx9oyvsz2iv6Fkv dbaI4n/Y5A8w/KaORpcjwL7DIdLD2rY0bSrPBI1aVKn7R47Qup4VSQFbT2FDDYIBLX/XnNn+p1jQS WwuZC+2M9EFqrWNtSBaaSFi/ielhW+ER+YQzADA+n1aWeTDCSgfQgy2RQJ2T+nAiY5oPhF8MYpMDj Xy7NU7l1w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSpS-0000ae-FM; Wed, 02 Dec 2020 14:09:58 +0000 Received: from lb1-smtp-cloud7.xs4all.net ([194.109.24.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkSpE-0000Sh-S7 for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 14:09:46 +0000 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id kSp0kEZ3PN7XgkSp3ktOxl; Wed, 02 Dec 2020 15:09:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1606918174; bh=8It+mUhWcNhF0vzprQdPV2Le0KNPLwCD1U2+v68bzUo=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=vXCSGQe7jYBcuWZBYxKr7+xUM8qqIvOPES4wii+Mj/wKErDcYpT98eOqP5nLVNl1F +DPLfKDIsbHytSY0smL6jKSr0E9Um8Q0tf3SMHOQy+WApnrhuoB7tnMeLOr5CQkQkv G4ixqlPOy2QOC9axIDZLYzyQrh4saIehyRU+uZHrATWOn0sBmB14MLJzPg9M+0ZSjU 9tr6uHCnRHH3kY7HMDeF5kLID3yPxpGGCh8R5Uxg1huU38zxnsUn80ja5tT7l3bztz Lsgm3afZ2/t9H48AJh+Pcc2UpLiLZb11TNl0dyD2LIYYJqxvO1mipVJi7hQAILubld W+FkKGe5cirpw== Subject: Re: [PATCH 1/4] v4l2-ctrl: Make display delay and display enable std controls To: Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20201109173541.10016-1-stanimir.varbanov@linaro.org> <20201109173541.10016-2-stanimir.varbanov@linaro.org> From: Hans Verkuil Message-ID: Date: Wed, 2 Dec 2020 15:09:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201109173541.10016-2-stanimir.varbanov@linaro.org> Content-Language: en-US X-CMAE-Envelope: MS4xfH4z1F2rSCh2o7ovDglbE7I63h5pvR0H4mAQBXX/CsvJ5Ai4XMH7fKhDjKKSS6Wubw6B6axvK3MnaxI+Z5fYdTMVz8rVmsKZhmxMavbwNcupviDfc6vf 4bRzpJBgOGj8aH+6/9Tv/HpValbnVb/TjYR8ASRh2ejbVVLR/JGbrGmvVOaw1yVE8QQ8we3EJyBCzRgZqcAjiK7K22P1TcIWYgMw7epXSl7KW6o/PxVWYZ8F +yz70WxsT+0wgx2qLiQsRpeGOWjAU2FYvgyWcKsE550ZBXhqcdEwhonkJVg3btdO9h+ITaTvMnyfB2syuLBCbtyDho5Unvbh8jMyUxophvHTtjOB8Fffckyy ddhg+CqkQX/qTBR75JGikszM5/awJ4uh9aoGIPL2h1f4s/5X9GO/8dWPoPhLOPX1NOj+iFrEAGlDxxDKQGYOjcCdBzKSbKI71A91YW++Qs5SVoC0e5Nis09Z oDdsquDlsjYoeVRdqzg+1Ov/DgOvLMsfduopx5rZu7FApqHaJC74eairhQmCuws9nGzn8tCNP9wxPJsZUsSvgSWt3X++Pdb0JuvCQA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_090945_172824_8E8732AE X-CRM114-Status: GOOD ( 26.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kyungmin Park , Nicolas Dufresne , Ezequiel Garcia , Kamil Debski , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/11/2020 18:35, Stanimir Varbanov wrote: > Make display delay and display delay enable MFC controls standard v4l > controls. This will allow reuse of the controls for other decoder > drivers. Also the new proposed controls are now codec agnostic because > they could be used for any codec. > > Signed-off-by: Stanimir Varbanov > --- > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 15 +++++++++++++++ > drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ > include/uapi/linux/v4l2-controls.h | 2 ++ > 3 files changed, 21 insertions(+) > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > index ce728c757eaf..82c9cda40270 100644 > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > @@ -679,6 +679,21 @@ enum v4l2_mpeg_video_frame_skip_mode - > otherwise the decoder expects a single frame in per buffer. > Applicable to the decoder, all codecs. > > +``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE (boolean)`` I'd use _DEC_ instead of _DECODER_. > + If the display delay is enabled then the decoder is forced to return > + a CAPTURE buffer (decoded frame) after processing a certain number > + of OUTPUT buffers. The delay can be set through > + ``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY``. This > + feature can be used for example for generating thumbnails of videos. > + Applicable to the decoder. Hmm. Is this: "after processing the first 'display delay' number of OUTPUT buffers." Or is this: "every 'display delay' number of OUTPUT buffers." I.e., is it a one-shot thing or a periodical thing? If it is a one-shot thing, then this should probably be a button type, not a boolean. > + > +``V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY (integer)`` > + Display delay value for decoder. The decoder is forced to > + return a decoded frame after the set 'display delay' number of > + frames. If this number is low it may result in frames returned out > + of display order, in addition the hardware may still be using the > + returned buffer as a reference picture for subsequent frames. Can this be 0? And if so, what does that mean? > + > ``V4L2_CID_MPEG_VIDEO_H264_VUI_SAR_ENABLE (boolean)`` > Enable writing sample aspect ratio in the Video Usability > Information. Applicable to the H264 encoder. > diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c > index bd7f330c941c..4a21802e026b 100644 > --- a/drivers/media/v4l2-core/v4l2-ctrls.c > +++ b/drivers/media/v4l2-core/v4l2-ctrls.c > @@ -874,6 +874,8 @@ const char *v4l2_ctrl_get_name(u32 id) > case V4L2_CID_MPEG_VIDEO_HEADER_MODE: return "Sequence Header Mode"; > case V4L2_CID_MPEG_VIDEO_MAX_REF_PIC: return "Max Number of Reference Pics"; > case V4L2_CID_MPEG_VIDEO_FRAME_SKIP_MODE: return "Frame Skip Mode"; > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY: return "Display Delay"; > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE: return "Display Delay Enable"; > case V4L2_CID_MPEG_VIDEO_H263_I_FRAME_QP: return "H263 I-Frame QP Value"; > case V4L2_CID_MPEG_VIDEO_H263_P_FRAME_QP: return "H263 P-Frame QP Value"; > case V4L2_CID_MPEG_VIDEO_H263_B_FRAME_QP: return "H263 B-Frame QP Value"; > @@ -1221,6 +1223,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > case V4L2_CID_FLASH_READY: > case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER: > case V4L2_CID_MPEG_VIDEO_DECODER_SLICE_INTERFACE: > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE: > case V4L2_CID_MPEG_VIDEO_FRAME_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_MB_RC_ENABLE: > case V4L2_CID_MPEG_VIDEO_H264_8X8_TRANSFORM: > @@ -1256,6 +1259,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum v4l2_ctrl_type *type, > break; > case V4L2_CID_MPEG_VIDEO_MV_H_SEARCH_RANGE: > case V4L2_CID_MPEG_VIDEO_MV_V_SEARCH_RANGE: > + case V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY: > *type = V4L2_CTRL_TYPE_INTEGER; > break; > case V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME: > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 7035f4fb182c..d6b19f8d0022 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -773,6 +773,8 @@ enum v4l2_mpeg_video_frame_skip_mode { > V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_LEVEL_LIMIT = 1, > V4L2_MPEG_VIDEO_FRAME_SKIP_MODE_BUF_LIMIT = 2, > }; > +#define V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY (V4L2_CID_MPEG_BASE + 647) > +#define V4L2_CID_MPEG_VIDEO_DECODER_DISPLAY_DELAY_ENABLE (V4L2_CID_MPEG_BASE + 648) This will need to be rebased once this PR is merged: https://patchwork.linuxtv.org/project/linux-media/patch/d68da172-b251-000f-653d-38a8a4c7b715@xs4all.nl/ > > /* MPEG-class control IDs specific to the CX2341x driver as defined by V4L2 */ > #define V4L2_CID_MPEG_CX2341X_BASE (V4L2_CTRL_CLASS_MPEG | 0x1000) > Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel