From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BF5C04EB9 for ; Mon, 3 Dec 2018 09:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E128720851 for ; Mon, 3 Dec 2018 09:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E128720851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbeLCJaY (ORCPT ); Mon, 3 Dec 2018 04:30:24 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:47122 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725888AbeLCJaY (ORCPT ); Mon, 3 Dec 2018 04:30:24 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id AB17A60574A8D; Mon, 3 Dec 2018 17:30:08 +0800 (CST) Received: from [127.0.0.1] (10.142.63.192) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.408.0; Mon, 3 Dec 2018 17:30:03 +0800 CC: , USB , devicetree , Linux Kernel Mailing List , Suzhuangluan , Kongfei , Felipe Balbi , "Greg Kroah-Hartman" , "Krogerus, Heikki" Subject: Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code. To: Andy Shevchenko References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-10-chenyu56@huawei.com> From: Chen Yu Message-ID: Date: Mon, 3 Dec 2018 17:30:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.63.192] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/12/3 17:15, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: >> >> The Type-C drivers use USB role switch API to inform the >> system about the negotiated data role, so registering a role >> switch in the DRD code in order to support platforms with >> USB Type-C connectors. > >> + pr_info("%s:set role %d\n", __func__, role); > > Noise! > >> + return role; >> + > > Redundant blank line. > >> +} > OK. Thanks! Chen Yu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Yu Subject: Re: [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code. Date: Mon, 3 Dec 2018 17:30:02 +0800 Message-ID: References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-10-chenyu56@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: wangbinghui@hisilicon.com, USB , devicetree , Linux Kernel Mailing List , Suzhuangluan , Kongfei , Felipe Balbi , Greg Kroah-Hartman , "Krogerus, Heikki" List-Id: devicetree@vger.kernel.org On 2018/12/3 17:15, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: >> >> The Type-C drivers use USB role switch API to inform the >> system about the negotiated data role, so registering a role >> switch in the DRD code in order to support platforms with >> USB Type-C connectors. > >> + pr_info("%s:set role %d\n", __func__, role); > > Noise! > >> + return role; >> + > > Redundant blank line. > >> +} > OK. Thanks! Chen Yu From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,09/12] usb: dwc3: Registering a role switch in the DRD code. From: Yu Chen Message-Id: Date: Mon, 3 Dec 2018 17:30:02 +0800 To: Andy Shevchenko Cc: wangbinghui@hisilicon.com, USB , devicetree , Linux Kernel Mailing List , Suzhuangluan , Kongfei , Felipe Balbi , Greg Kroah-Hartman , "Krogerus, Heikki" List-ID: T24gMjAxOC8xMi8zIDE3OjE1LCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gT24gTW9uLCBEZWMg MywgMjAxOCBhdCA1OjQ3IEFNIFl1IENoZW4gPGNoZW55dTU2QGh1YXdlaS5jb20+IHdyb3RlOgo+ Pgo+PiBUaGUgVHlwZS1DIGRyaXZlcnMgdXNlIFVTQiByb2xlIHN3aXRjaCBBUEkgdG8gaW5mb3Jt IHRoZQo+PiBzeXN0ZW0gYWJvdXQgdGhlIG5lZ290aWF0ZWQgZGF0YSByb2xlLCBzbyByZWdpc3Rl cmluZyBhIHJvbGUKPj4gc3dpdGNoIGluIHRoZSBEUkQgY29kZSBpbiBvcmRlciB0byBzdXBwb3J0 IHBsYXRmb3JtcyB3aXRoCj4+IFVTQiBUeXBlLUMgY29ubmVjdG9ycy4KPiAKPj4gKyAgICAgICBw cl9pbmZvKCIlczpzZXQgcm9sZSAlZFxuIiwgX19mdW5jX18sIHJvbGUpOwo+IAo+IE5vaXNlIQo+ IAo+PiArICAgICAgIHJldHVybiByb2xlOwo+PiArCj4gCj4gUmVkdW5kYW50IGJsYW5rIGxpbmUu Cj4gCj4+ICt9Cj4gCk9LLiBUaGFua3MhCgpDaGVuIFl1Cg==