From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28501C433DB for ; Mon, 15 Feb 2021 20:27:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A19564DEC for ; Mon, 15 Feb 2021 20:27:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A19564DEC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBkTK-00057g-3z for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 15:27:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBkSY-0004cF-MU for qemu-devel@nongnu.org; Mon, 15 Feb 2021 15:27:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBkSW-00079m-JD for qemu-devel@nongnu.org; Mon, 15 Feb 2021 15:27:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613420823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CpEmzBFfhY2btzMgtfUqPH/L+lZjtQVJXUsZo8Pyu2M=; b=M3LnL0V3+2TG302gZMw3z+1fzh5112GPn8aD0hKTxxUPx3XgHIP9d9GYRy6fm4072Z1Zpm l9RKHa3qa5kQmaceeUUskJ6J+GMaiQJumhEdwLzuq5bPVUK+GN39qr8Q0BaQJiuI52bKQs 5b6E6xFEJCko5NdvK3m3LClsjUsRtJA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-aJYJiiZJO52Gd3s59tBCGA-1; Mon, 15 Feb 2021 15:27:01 -0500 X-MC-Unique: aJYJiiZJO52Gd3s59tBCGA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C1046D4F3; Mon, 15 Feb 2021 20:27:00 +0000 (UTC) Received: from [10.3.113.98] (ovpn-113-98.phx2.redhat.com [10.3.113.98]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F41C2BFEC; Mon, 15 Feb 2021 20:26:59 +0000 (UTC) Subject: Re: [PULL 3/5] qemu-iotests: 300: Add test case for modifying persistence of bitmap To: John Snow , Kevin Wolf References: <20210212232134.1462756-1-eblake@redhat.com> <20210212232134.1462756-4-eblake@redhat.com> <20210215123152.GM7226@merkur.fritz.box> <0cd1617d-b22f-4ce1-38c2-df8822c3fbbe@redhat.com> <20210215170902.GS7226@merkur.fritz.box> <42192dc8-329c-ef2d-d8f7-3d02ae9d2c85@redhat.com> <0138182f-0e17-f225-0060-85f1776f26dc@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Mon, 15 Feb 2021 14:26:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <0138182f-0e17-f225-0060-85f1776f26dc@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Krempa , qemu-devel@nongnu.org, "open list:Block layer core" , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/15/21 1:00 PM, John Snow wrote: > On 2/15/21 1:25 PM, Eric Blake wrote: >> -BlockBitmapMapping = List[Dict[str, Union[str, List[Dict[str, str]]]]] >> +BlockBitmapMapping = List[Dict[str, >> +                               Union[str, >> +                                     List[Dict[str, >> +                                               Union[str, Dict[str, >> bool]]]]]]] > > That looks *very* beefy. > > Is the Union because that union is valid for every key, or because every > key has a potentially different value that is specific to that key? > > if it's the latter, I'd ditch the Union and just go with: > > Dict[str, object], or > Dict[str, Any] > > object: will allow any type, but keeps strict checking enabled. If you > try to use that value later on without a cast, mypy will warn you if you > are using it in a manner not guaranteed by the "object" type. Can be > useful if you are passing values to a function that already does RTTI to > determine behavior. We're in luck; both 297 and 300 still pass with this applied on top of my previous attempt: diff --git i/tests/qemu-iotests/300 w/tests/qemu-iotests/300 index 7501bd1018e2..adb927629747 100755 --- i/tests/qemu-iotests/300 +++ w/tests/qemu-iotests/300 @@ -22,7 +22,7 @@ import os import random import re -from typing import Dict, List, Optional, Union +from typing import Dict, List, Optional import iotests @@ -30,10 +30,7 @@ import iotests # pylint: disable=wrong-import-order import qemu -BlockBitmapMapping = List[Dict[str, - Union[str, - List[Dict[str, - Union[str, Dict[str, bool]]]]]]] +BlockBitmapMapping = List[Dict[str, object]] mig_sock = os.path.join(iotests.sock_dir, 'mig_sock') > > Any: Also allows any type, but enables gradual typing. If you later > "assume" the type of this value, mypy will say nothing. Can be useful > when you've just got a job to do and the right tool would have been a > recursive type or a TypedDict (unavailable in Python 3.6.) I'm not too worried about needing to further enhance the type-checking on an individual iotest. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org