All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gitlab-ci: Display Avocado log content when tests timeout
@ 2021-02-15 17:14 Philippe Mathieu-Daudé
  2021-02-15 17:49 ` Wainer dos Santos Moschetta
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-15 17:14 UTC (permalink / raw)
  To: qemu-devel
  Cc: Willian Rampazzo, Alex Bennée, Thomas Huth,
	Philippe Mathieu-Daudé,
	Wainer dos Santos Moschetta

Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs
of failed acceptances") we display the log content of failing tests
(Avocado "FAIL" event).

Since we are also interested in tests timeouting, update our global
Avocado config to display log content for the "INTERRUPT" event,
"possible when the timeout is reached" (See [*]).

[*] https://avocado-framework.readthedocs.io/en/latest/guides/writer/chapters/writing.html#test-statuses

Suggested-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 7adb9a4cef0..234cead60c2 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -64,7 +64,7 @@ include:
     - echo "[datadir.paths]" > ~/.config/avocado/avocado.conf
     - echo "cache_dirs = ['${CI_PROJECT_DIR}/avocado-cache']"
            >> ~/.config/avocado/avocado.conf
-    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL"]'
+    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL", "INTERRUPT"]'
            >> ~/.config/avocado/avocado.conf
     - if [ -d ${CI_PROJECT_DIR}/avocado-cache ]; then
         du -chs ${CI_PROJECT_DIR}/avocado-cache ;
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gitlab-ci: Display Avocado log content when tests timeout
  2021-02-15 17:14 [PATCH] gitlab-ci: Display Avocado log content when tests timeout Philippe Mathieu-Daudé
@ 2021-02-15 17:49 ` Wainer dos Santos Moschetta
  2021-02-15 18:27 ` Willian Rampazzo
  2021-02-17 12:07 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Wainer dos Santos Moschetta @ 2021-02-15 17:49 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel
  Cc: Willian Rampazzo, Thomas Huth, Alex Bennée


On 2/15/21 2:14 PM, Philippe Mathieu-Daudé wrote:
> Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs
> of failed acceptances") we display the log content of failing tests
> (Avocado "FAIL" event).
>
> Since we are also interested in tests timeouting, update our global
> Avocado config to display log content for the "INTERRUPT" event,
> "possible when the timeout is reached" (See [*]).
>
> [*] https://avocado-framework.readthedocs.io/en/latest/guides/writer/chapters/writing.html#test-statuses
>
> Suggested-by: Willian Rampazzo <willianr@redhat.com>
Good idea.
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   .gitlab-ci.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 7adb9a4cef0..234cead60c2 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -64,7 +64,7 @@ include:
>       - echo "[datadir.paths]" > ~/.config/avocado/avocado.conf
>       - echo "cache_dirs = ['${CI_PROJECT_DIR}/avocado-cache']"
>              >> ~/.config/avocado/avocado.conf
> -    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL"]'
> +    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL", "INTERRUPT"]'
>              >> ~/.config/avocado/avocado.conf
>       - if [ -d ${CI_PROJECT_DIR}/avocado-cache ]; then
>           du -chs ${CI_PROJECT_DIR}/avocado-cache ;



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gitlab-ci: Display Avocado log content when tests timeout
  2021-02-15 17:14 [PATCH] gitlab-ci: Display Avocado log content when tests timeout Philippe Mathieu-Daudé
  2021-02-15 17:49 ` Wainer dos Santos Moschetta
@ 2021-02-15 18:27 ` Willian Rampazzo
  2021-02-17 12:07 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Willian Rampazzo @ 2021-02-15 18:27 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Willian Rampazzo, Thomas Huth, Alex Bennée, qemu-devel,
	Wainer dos Santos Moschetta

On Mon, Feb 15, 2021 at 2:14 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs
> of failed acceptances") we display the log content of failing tests
> (Avocado "FAIL" event).
>
> Since we are also interested in tests timeouting, update our global
> Avocado config to display log content for the "INTERRUPT" event,
> "possible when the timeout is reached" (See [*]).
>
> [*] https://avocado-framework.readthedocs.io/en/latest/guides/writer/chapters/writing.html#test-statuses
>
> Suggested-by: Willian Rampazzo <willianr@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gitlab-ci: Display Avocado log content when tests timeout
  2021-02-15 17:14 [PATCH] gitlab-ci: Display Avocado log content when tests timeout Philippe Mathieu-Daudé
  2021-02-15 17:49 ` Wainer dos Santos Moschetta
  2021-02-15 18:27 ` Willian Rampazzo
@ 2021-02-17 12:07 ` Alex Bennée
  2 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2021-02-17 12:07 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Willian Rampazzo, Thomas Huth, qemu-devel, Wainer dos Santos Moschetta


Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Since commit ba2232bae6d ("gitlab-ci: Refactor code that show logs
> of failed acceptances") we display the log content of failing tests
> (Avocado "FAIL" event).
>
> Since we are also interested in tests timeouting, update our global
> Avocado config to display log content for the "INTERRUPT" event,
> "possible when the timeout is reached" (See [*]).
>
> [*] https://avocado-framework.readthedocs.io/en/latest/guides/writer/chapters/writing.html#test-statuses
>
> Suggested-by: Willian Rampazzo <willianr@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued to testing/next, thanks.

> ---
>  .gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 7adb9a4cef0..234cead60c2 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -64,7 +64,7 @@ include:
>      - echo "[datadir.paths]" > ~/.config/avocado/avocado.conf
>      - echo "cache_dirs = ['${CI_PROJECT_DIR}/avocado-cache']"
>             >> ~/.config/avocado/avocado.conf
> -    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL"]'
> +    - echo -e '[job.output.testlogs]\nstatuses = ["FAIL", "INTERRUPT"]'
>             >> ~/.config/avocado/avocado.conf
>      - if [ -d ${CI_PROJECT_DIR}/avocado-cache ]; then
>          du -chs ${CI_PROJECT_DIR}/avocado-cache ;


-- 
Alex Bennée


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-17 12:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 17:14 [PATCH] gitlab-ci: Display Avocado log content when tests timeout Philippe Mathieu-Daudé
2021-02-15 17:49 ` Wainer dos Santos Moschetta
2021-02-15 18:27 ` Willian Rampazzo
2021-02-17 12:07 ` Alex Bennée

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.