From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E06C433EF for ; Wed, 23 Mar 2022 03:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231250AbiCWDJp (ORCPT ); Tue, 22 Mar 2022 23:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241416AbiCWDJf (ORCPT ); Tue, 22 Mar 2022 23:09:35 -0400 Received: from 189.cn (ptr.189.cn [183.61.185.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8730B2459C; Tue, 22 Mar 2022 20:08:02 -0700 (PDT) HMM_SOURCE_IP: 10.64.8.31:51852.492916150 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.31]) by 189.cn (HERMES) with SMTP id CB0F11002BB; Wed, 23 Mar 2022 11:07:58 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-b7fbf7d79-bwdqx with ESMTP id 73c6cd2c2177406cb813e64aa6784a6a for jiaxun.yang@flygoat.com; Wed, 23 Mar 2022 11:08:01 CST X-Transaction-ID: 73c6cd2c2177406cb813e64aa6784a6a X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Sender: 15330273260@189.cn Message-ID: Date: Wed, 23 Mar 2022 11:07:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Content-Language: en-US To: Jiaxun Yang , Maxime Ripard , Thomas Zimmermann , Roland Scheidegger , Zack Rusin , Christian Gmeiner , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer , Dan Carpenter , Krzysztof Kozlowski , Andrey Zhizhikin , Sam Ravnborg , "David S . Miller" , Lucas Stach , Maarten Lankhorst , Ilia Mirkin , Qing Zhang , suijingfeng Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, chenhuacai@kernel.org, Tiezhu Yang , liyi@loongson.cn References: <20220321162916.1116541-1-15330273260@189.cn> <20220321162916.1116541-3-15330273260@189.cn> <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com> <2c671752-6684-f87b-7b2d-90568d36adde@189.cn> <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/3/23 10:29, Jiaxun Yang wrote: > > > 在 2022/3/23 1:53, Sui Jingfeng 写道: >> Hi, Jiaxun >> >> Build all dts into vmlinuz will make the vmlinuz bigger and bigger. >> How does the kernel get the dtb is another big issue, either from >> built-in >> dtb or pass from the firmware(pmon and uefi etc). This should be >> solved with another patch carefully. Providing board specific dts >> helps to code review, it helps reviewers understand that there are >> variant boards and have to be express with different OF graph. > Hi, > > I insist my taste on those code. If the only intention is to demonstrate > the usage of the driver then please just leave them in dt document > or commit message. > >> >> Now, there are about 6 dts under arch/mips/boot/dts/loongson/, >> Suppose loongson have 1000+ different board, do you want built all >> of them into vmlinuz? > Note that we are supporting all those boards on "platform" bias. Which > means if they share similar design then they will use the same DTS. > If we have a new design then unfortunately our kernel binary must grow. > > For those who intended to build a size-optimized kernel they will be > able to disable unused DTS in Kconfig. > > If you want to blame somebody for the problem then please don't > blame us. We tried very hard to fit all those stuff into kernel's model > of devices. You should blame those who did the initial design of > Loongson's boot interface that failed to introduce a proper way > to describe the platform. > >> >> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver, >> pwm driver, clk driver, can you pay more attention to salve those >> problems, please ? > Are you trying to make a TODO list for your colleague :-) > > We , community developers, don't owe you anything. So please > don't expect anything from us. I lost access to most Loongson > devices since I'm currently study abroad, but I'm determined to > keep platform code in a good shape. That's my duty as a maintainer. > > Thanks. > - Jiaxun Providing a few board specific dts doesn't hurt anybody. Can we leave the problem(passing correct dts to the kernel) untouched and solve it in the feature with a another patch, ok? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E483C433F5 for ; Wed, 23 Mar 2022 03:08:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C07110E18E; Wed, 23 Mar 2022 03:08:06 +0000 (UTC) Received: from 189.cn (ptr.189.cn [183.61.185.101]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C24A10E18E for ; Wed, 23 Mar 2022 03:08:04 +0000 (UTC) HMM_SOURCE_IP: 10.64.8.31:51852.492916150 HMM_ATTACHE_NUM: 0000 HMM_SOURCE_TYPE: SMTP Received: from clientip-114.242.206.180 (unknown [10.64.8.31]) by 189.cn (HERMES) with SMTP id CB0F11002BB; Wed, 23 Mar 2022 11:07:58 +0800 (CST) Received: from ([114.242.206.180]) by gateway-151646-dep-b7fbf7d79-bwdqx with ESMTP id 73c6cd2c2177406cb813e64aa6784a6a for jiaxun.yang@flygoat.com; Wed, 23 Mar 2022 11:08:01 CST X-Transaction-ID: 73c6cd2c2177406cb813e64aa6784a6a X-Real-From: 15330273260@189.cn X-Receive-IP: 114.242.206.180 X-MEDUSA-Status: 0 Message-ID: Date: Wed, 23 Mar 2022 11:07:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Content-Language: en-US To: Jiaxun Yang , Maxime Ripard , Thomas Zimmermann , Roland Scheidegger , Zack Rusin , Christian Gmeiner , David Airlie , Daniel Vetter , Rob Herring , Thomas Bogendoerfer , Dan Carpenter , Krzysztof Kozlowski , Andrey Zhizhikin , Sam Ravnborg , "David S . Miller" , Lucas Stach , Maarten Lankhorst , Ilia Mirkin , Qing Zhang , suijingfeng References: <20220321162916.1116541-1-15330273260@189.cn> <20220321162916.1116541-3-15330273260@189.cn> <2644866a-8db2-923e-4227-2aa6d8e375fe@flygoat.com> <2c671752-6684-f87b-7b2d-90568d36adde@189.cn> <005099b5-33ed-4cb7-f8e4-10e1de780311@flygoat.com> <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> From: Sui Jingfeng <15330273260@189.cn> In-Reply-To: <87d4f869-2ae8-f8d3-a55f-1a563cb21115@flygoat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, liyi@loongson.cn, chenhuacai@kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tiezhu Yang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2022/3/23 10:29, Jiaxun Yang wrote: > > > 在 2022/3/23 1:53, Sui Jingfeng 写道: >> Hi, Jiaxun >> >> Build all dts into vmlinuz will make the vmlinuz bigger and bigger. >> How does the kernel get the dtb is another big issue, either from >> built-in >> dtb or pass from the firmware(pmon and uefi etc). This should be >> solved with another patch carefully. Providing board specific dts >> helps to code review, it helps reviewers understand that there are >> variant boards and have to be express with different OF graph. > Hi, > > I insist my taste on those code. If the only intention is to demonstrate > the usage of the driver then please just leave them in dt document > or commit message. > >> >> Now, there are about 6 dts under arch/mips/boot/dts/loongson/, >> Suppose loongson have 1000+ different board, do you want built all >> of them into vmlinuz? > Note that we are supporting all those boards on "platform" bias. Which > means if they share similar design then they will use the same DTS. > If we have a new design then unfortunately our kernel binary must grow. > > For those who intended to build a size-optimized kernel they will be > able to disable unused DTS in Kconfig. > > If you want to blame somebody for the problem then please don't > blame us. We tried very hard to fit all those stuff into kernel's model > of devices. You should blame those who did the initial design of > Loongson's boot interface that failed to introduce a proper way > to describe the platform. > >> >> Besides, ls7a1000 and ls2k1000 lack a i2c driver, gpio driver, >> pwm driver, clk driver, can you pay more attention to salve those >> problems, please ? > Are you trying to make a TODO list for your colleague :-) > > We , community developers, don't owe you anything. So please > don't expect anything from us. I lost access to most Loongson > devices since I'm currently study abroad, but I'm determined to > keep platform code in a good shape. That's my duty as a maintainer. > > Thanks. > - Jiaxun Providing a few board specific dts doesn't hurt anybody. Can we leave the problem(passing correct dts to the kernel) untouched and solve it in the feature with a another patch, ok?