From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E42C07E96 for ; Thu, 8 Jul 2021 07:36:51 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 9775261CE0 for ; Thu, 8 Jul 2021 07:36:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9775261CE0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0FC94069C; Thu, 8 Jul 2021 09:36:49 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 97D4A40687 for ; Thu, 8 Jul 2021 09:36:48 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D61F17F523; Thu, 8 Jul 2021 10:36:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D61F17F523 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625729807; bh=dD5ltQMQy0ubyHsTMhXc/GBFwUaRQdB5NPvc8Hxi+60=; h=Subject:To:References:From:Date:In-Reply-To; b=IscA6L41JaQbji93cUZEmNYyrEPFjpPlCOZWwzIrUqN3OzDoAuhMJmOAfP7UMI7Hi HiIp46q+S+te6ONknGsKEOzr/VdRLj+pfYe/70mSwTI1AZLxjFMH89O9a6FxA5l8g7 9sLqSec939SFKNXMV9zcR93B6ku1QqzCrmue6md4= To: Jiawen Wu , dev@dpdk.org References: <20210706095545.10776-1-jiawenwu@trustnetic.com> <20210706095545.10776-15-jiawenwu@trustnetic.com> <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru> <001f01d773bf$c175ce70$44616b50$@trustnetic.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 8 Jul 2021 10:36:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <001f01d773bf$c175ce70$44616b50$@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/8/21 9:09 AM, Jiawen Wu wrote: > On July 7, 2021 10:05 PM, Andrew Rybchenko wrote: >> On 7/6/21 12:55 PM, Jiawen Wu wrote: >>> Setup MSI-X interrupt, complete PHY configuration and set device link >>> speed to start device. Disable interrupt, stop hardware and clear >>> queues to stop device. >>> >>> Signed-off-by: Jiawen Wu >> >> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see >> Documentation/timers/timers-howto.rst >> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70: >> + msleep(1); >> >> Any comments? >> > > This depends on the design of the hardware. Isn't is a problem if sleep will be longer in fact?