From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/6] drm/i915: Try harder on multifunction SDVO DDC Date: Thu, 16 Jun 2011 21:58:42 +0100 Message-ID: References: <1308256588-8026-1-git-send-email-ajax@redhat.com> <1308256588-8026-4-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A8B89E759 for ; Thu, 16 Jun 2011 13:58:46 -0700 (PDT) In-Reply-To: <1308256588-8026-4-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rolf Eike Beer Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Rolf, This looks to be the missing ingredient for your board. Can you please give it a test? -Chris On Thu, 16 Jun 2011 16:36:26 -0400, Adam Jackson wrote: > The comment was wrong, bus 0 is the SPD ROM, as we discovered in > 14571b4 and b108333. > > Signed-off-by: Adam Jackson > --- > drivers/gpu/drm/i915/intel_sdvo.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index 6d3dd09..193919e 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -1313,11 +1313,8 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) > if (edid == NULL && intel_sdvo_multifunc_encoder(intel_sdvo)) { > u8 ddc, saved_ddc = intel_sdvo->ddc_bus; > > - /* > - * Don't use the 1 as the argument of DDC bus switch to get > - * the EDID. It is used for SDVO SPD ROM. > - */ > - for (ddc = intel_sdvo->ddc_bus >> 1; ddc > 1; ddc >>= 1) { > + /* Skip bus 0, it's the SDVO SPD ROM */ > + for (ddc = intel_sdvo->ddc_bus >> 1; ddc > 0; ddc >>= 1) { > intel_sdvo->ddc_bus = ddc; > edid = intel_sdvo_get_edid(connector); > if (edid) > -- > 1.7.5.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Chris Wilson, Intel Open Source Technology Centre