From: "Christian König" <christian.koenig@amd.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
matthew.auld@intel.com
Subject: Re: Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)
Date: Wed, 23 Mar 2022 16:19:17 +0100 [thread overview]
Message-ID: <e0de20aa-fcd9-f847-783d-cd4794ca05be@amd.com> (raw)
In-Reply-To: <CAPj87rMETV9UkpbGRYAT3mjVhRtW75m0e9OLON6_+gdcD0Fo2Q@mail.gmail.com>
Am 23.03.22 um 15:00 schrieb Daniel Stone:
> On Wed, 23 Mar 2022 at 08:19, Christian König <christian.koenig@amd.com> wrote:
>> Am 23.03.22 um 09:10 schrieb Paul Menzel:
>>> Sorry, I disagree. The motivation needs to be part of the commit
>>> message. For example see recent discussion on the LWN article
>>> *Donenfeld: Random number generator enhancements for Linux 5.17 and
>>> 5.18* [1].
>>>
>>> How much the commit message should be extended, I do not know, but the
>>> current state is insufficient (too terse).
>> Well the key point is it's not about you to judge that.
>>
>> If you want to complain about the commit message then come to me with
>> that and don't request information which isn't supposed to be publicly
>> available.
>>
>> So to make it clear: The information is intentionally hold back and not
>> made public.
> In that case, the code isn't suitable to be merged into upstream
> trees; it can be resubmitted when it can be explained.
Well what Paul is requesting here are business information, not
technical information.
In other words we perfectly explained why it is technically necessary
already which is sufficient.
Regards,
Christian.
>
> Cheers,
> Daniel
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
Arunpravin Paneer Selvam <arunpravin.paneerselvam@amd.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
matthew.auld@intel.com
Subject: Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)
Date: Wed, 23 Mar 2022 16:19:17 +0100 [thread overview]
Message-ID: <e0de20aa-fcd9-f847-783d-cd4794ca05be@amd.com> (raw)
In-Reply-To: <CAPj87rMETV9UkpbGRYAT3mjVhRtW75m0e9OLON6_+gdcD0Fo2Q@mail.gmail.com>
Am 23.03.22 um 15:00 schrieb Daniel Stone:
> On Wed, 23 Mar 2022 at 08:19, Christian König <christian.koenig@amd.com> wrote:
>> Am 23.03.22 um 09:10 schrieb Paul Menzel:
>>> Sorry, I disagree. The motivation needs to be part of the commit
>>> message. For example see recent discussion on the LWN article
>>> *Donenfeld: Random number generator enhancements for Linux 5.17 and
>>> 5.18* [1].
>>>
>>> How much the commit message should be extended, I do not know, but the
>>> current state is insufficient (too terse).
>> Well the key point is it's not about you to judge that.
>>
>> If you want to complain about the commit message then come to me with
>> that and don't request information which isn't supposed to be publicly
>> available.
>>
>> So to make it clear: The information is intentionally hold back and not
>> made public.
> In that case, the code isn't suitable to be merged into upstream
> trees; it can be resubmitted when it can be explained.
Well what Paul is requesting here are business information, not
technical information.
In other words we perfectly explained why it is technically necessary
already which is sufficient.
Regards,
Christian.
>
> Cheers,
> Daniel
next prev parent reply other threads:[~2022-03-23 15:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 6:25 [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu Arunpravin Paneer Selvam
2022-03-23 6:25 ` Arunpravin Paneer Selvam
2022-03-23 6:25 ` [Intel-gfx] " Arunpravin Paneer Selvam
2022-03-23 6:42 ` Paul Menzel
2022-03-23 6:42 ` Paul Menzel
2022-03-23 6:42 ` [Intel-gfx] " Paul Menzel
2022-03-23 7:42 ` Christian König
2022-03-23 7:42 ` Christian König
2022-03-23 7:42 ` [Intel-gfx] " Christian König
2022-03-23 8:10 ` Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu) Paul Menzel
2022-03-23 8:10 ` Paul Menzel
2022-03-23 8:10 ` [Intel-gfx] " Paul Menzel
2022-03-23 8:18 ` Christian König
2022-03-23 8:18 ` Christian König
2022-03-23 8:18 ` [Intel-gfx] " Christian König
2022-03-23 14:00 ` Daniel Stone
2022-03-23 14:00 ` [Intel-gfx] " Daniel Stone
2022-03-23 14:42 ` Alex Deucher
2022-03-23 14:42 ` [Intel-gfx] " Alex Deucher
2022-03-23 15:03 ` Daniel Stone
2022-03-23 15:03 ` [Intel-gfx] " Daniel Stone
2022-03-23 15:14 ` Alex Deucher
2022-03-23 15:14 ` [Intel-gfx] " Alex Deucher
2022-03-23 15:24 ` Daniel Stone
2022-03-23 15:24 ` [Intel-gfx] " Daniel Stone
2022-03-23 15:32 ` Christian König
2022-03-23 15:32 ` Christian König
2022-03-24 10:30 ` [Intel-gfx] " Daniel Vetter
2022-03-24 10:30 ` Daniel Vetter
2022-03-25 15:56 ` Commit messages Paul Menzel
2022-03-25 15:56 ` [Intel-gfx] " Paul Menzel
2022-03-23 15:19 ` Christian König [this message]
2022-03-23 15:19 ` [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu) Christian König
2022-03-23 7:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/amdgpu: add drm buddy support to amdgpu (rev2) Patchwork
2022-03-23 7:37 ` [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu Christian König
2022-03-23 7:37 ` [Intel-gfx] " Christian König
2022-03-23 7:37 ` Christian König
[not found] ` <MN2PR12MB4342B7FD0CC5C480DEEF8A77E41D9@MN2PR12MB4342.namprd12.prod.outlook.com>
2022-03-29 11:19 ` Arunpravin Paneer Selvam
2022-03-29 11:19 ` Arunpravin Paneer Selvam
2022-03-29 11:19 ` [Intel-gfx] " Arunpravin Paneer Selvam
2022-03-29 11:24 ` Christian König
2022-03-29 11:24 ` Christian König
2022-03-29 11:24 ` [Intel-gfx] " Christian König
2022-03-29 16:00 ` Arunpravin Paneer Selvam
2022-03-29 16:00 ` Arunpravin Paneer Selvam
2022-03-29 16:00 ` [Intel-gfx] " Arunpravin Paneer Selvam
2022-03-29 19:18 ` Arunpravin Paneer Selvam
2022-03-29 19:18 ` Arunpravin Paneer Selvam
2022-03-29 19:18 ` [Intel-gfx] " Arunpravin Paneer Selvam
2022-03-30 6:53 ` Christian König
2022-03-30 6:53 ` Christian König
2022-03-30 6:53 ` [Intel-gfx] " Christian König
2022-03-23 11:26 ` kernel test robot
2022-03-23 11:26 ` [Intel-gfx] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0de20aa-fcd9-f847-783d-cd4794ca05be@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arunpravin.paneerselvam@amd.com \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.