From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D768AC433DB for ; Wed, 3 Feb 2021 18:20:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E110260295 for ; Wed, 3 Feb 2021 18:20:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E110260295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7Mlm-0001Tq-G5 for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 13:20:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7MEj-0005Qb-LH for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:46:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l7MEi-0007t1-1J for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:46:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612374398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+0ZXIFDEkX8SG5LCJGOs3M0cM2KDSPKGjyLqJlmWoJM=; b=QL+akd3BcphHsxvKiykAya3HVo8kEicVm9h1Tz29CcH29JmPf3Z8TT2Zi5Crj9REk7Vo9d N7lXAHSLJ/nAxCfnUNjkbdzK/bthCQ9NxxmfBM4ddO+7pgpHEjvtYkDH0fUV+yCoubDzsp XNUhsVF4joc3JyfXPa1id/nQc4io7cI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-174-QMNbTndBMveXBCas7fsS3Q-1; Wed, 03 Feb 2021 12:46:36 -0500 X-MC-Unique: QMNbTndBMveXBCas7fsS3Q-1 Received: by mail-ed1-f70.google.com with SMTP id ay16so308745edb.2 for ; Wed, 03 Feb 2021 09:46:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+0ZXIFDEkX8SG5LCJGOs3M0cM2KDSPKGjyLqJlmWoJM=; b=H1eMf/9+LuP0+gw6VYYmXDSiMUfJPZQVu3lgCyL666iGQQP+FDxroi52NJHJD3rJps zkwxUEodnbC4OZnDxhPDdV+dZf30HaccLYlzPQMDIVN3pgyo7JMzh4dA3iHow2D19D4d zmeFD9FDIw7j8nEE5wQcDhR3DHrbnhpv3U8cHrKIDefm4GmKNdR3VzInoGX/j1FJQAdY R+IpgvzZVSjUAB9ZD/VP5AHC+Vb+B7klSj/9SPUJspiZngDYdOWRUHtLwOLWcdFpaIti QYg0tJCU6IVKnkBHiPjn9yEfSvfWL2U4C4rgvxDNmMG4xyAgqHtq3w4IJ8evLMb6p31m 2jug== X-Gm-Message-State: AOAM532Yl6TQWcKBV8pDv6p6JsIXm+adGR79Xkha9ciOfPW6NIxGAA4A OeUp9PLYdx/B6rxaMEBJum9wYsiQ8Is4MDkU90C/JDUZNMgXIUU1FUGC5IjAbGld19i65BVA7QV cJpmXtp8bPFM/Los= X-Received: by 2002:aa7:ca55:: with SMTP id j21mr4157653edt.172.1612374395351; Wed, 03 Feb 2021 09:46:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDI0H9/pXMYjrgIs5Dr9DHnZENIud5j4/NlTpHKaxVGOTchLGTUlUoM3KnAU+11aDAIKQs8Q== X-Received: by 2002:aa7:ca55:: with SMTP id j21mr4157626edt.172.1612374395161; Wed, 03 Feb 2021 09:46:35 -0800 (PST) Received: from [192.168.1.36] (107.red-83-59-163.dynamicip.rima-tde.net. [83.59.163.107]) by smtp.gmail.com with ESMTPSA id u18sm1307020ejc.76.2021.02.03.09.46.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 09:46:34 -0800 (PST) Subject: Re: [PATCH 19/22] Acceptance Tests: add port redirection for ssh by default To: Cleber Rosa , qemu-devel@nongnu.org References: <20210203172357.1422425-1-crosa@redhat.com> <20210203172357.1422425-20-crosa@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 3 Feb 2021 18:46:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210203172357.1422425-20-crosa@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.178, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Beraldo Leal , Wainer dos Santos Moschetta , John Snow , Thomas Huth , Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Eric Auger , Willian Rampazzo , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aurelien Jarno , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/3/21 6:23 PM, Cleber Rosa wrote: > For users of the LinuxTest class, let's set up the VM with the port > redirection for SSH, instead of requiring each test to set the same > arguments. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/avocado_qemu/__init__.py | 2 ++ > tests/acceptance/virtiofs_submounts.py | 4 ---- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py > index 5f4dd6b9ec..89669cc604 100644 > --- a/tests/acceptance/avocado_qemu/__init__.py > +++ b/tests/acceptance/avocado_qemu/__init__.py > @@ -301,6 +301,8 @@ class LinuxTest(Test, LinuxSSHMixIn): > super(LinuxTest, self).setUp() > self.vm.add_args('-smp', '2') > self.vm.add_args('-m', '1024') > + self.vm.add_args('-netdev', 'user,id=vnet,hostfwd=:127.0.0.1:0-:22', > + '-device', 'virtio-net,netdev=vnet') You need a machine with a virtio-bus to be able to plug a virtio device, not all provide one.