From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31506C32751 for ; Wed, 31 Jul 2019 06:54:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05C6C20693 for ; Wed, 31 Jul 2019 06:54:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="evXEg1Zu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387664AbfGaGyj (ORCPT ); Wed, 31 Jul 2019 02:54:39 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:51394 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387622AbfGaGyi (ORCPT ); Wed, 31 Jul 2019 02:54:38 -0400 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 99908A415D; Wed, 31 Jul 2019 08:54:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1564556075; bh=ThsOhNRIajeNUym+bp8b02ILLZbpBe61k5u1jccGA4k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=evXEg1ZuUxWP5CJvP5psdM7di4WpQYJivbeMTIixKqBCqE5GLn7H9RwcZR32Y9oyR 0CL+5q84x8jCK4nU/WyASAM7NFAPO22oFL030wS+cqdlLl2hNMzqijqHnL2zdoe7F+ JULn9s28Y+22TEIhoV6IwIT/mB9rauMJ3VqlXPhw= Subject: Re: [PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards To: Philippe Schenker , "festevam@gmail.com" Cc: "stefan@agner.ch" , Marcel Ziswiler , "kernel@pengutronix.de" , Max Krummenacher , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "s.hauer@pengutronix.de" , "robh+dt@kernel.org" , "linux-imx@nxp.com" References: <20190730144649.19022-1-dev@pschenker.ch> <20190730144649.19022-13-dev@pschenker.ch> <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: Date: Wed, 31 Jul 2019 08:54:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31. 07. 19 8:43, Philippe Schenker wrote: > On Tue, 2019-07-30 at 17:46 -0300, Fabio Estevam wrote: >> On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: >> >>> + /* Atmel maxtouch controller */ >>> + atmel_mxt_ts: atmel_mxt_ts@4a { >> >> Generic node names, please: >> >> touchscreen@4a >> >>> + compatible = "atmel,maxtouch"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_pcap_1>; >>> + reg = <0x4a>; >>> + interrupt-parent = <&gpio1>; >>> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* SODIMM 28 */ >>> + reset-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; /* SODIMM 30 */ >>> + status = "disabled"; >>> + }; >>> + >>> + /* >>> + * the PCAPs use SODIMM 28/30, also used for PWM, PWM, aka >>> pwm1, >>> + * pwm4. So if you enable one of the PCAP controllers disable the >>> pwms. >>> + */ >>> + pcap: pcap@10 { >> >> touchscreen@10 >> >>> + /* TouchRevolution Fusion 7 and 10 multi-touch controller */ >>> + compatible = "touchrevolution,fusion-f0710a"; >> >> I do not find this binding documented. > > Thanks for your feedback Fabio, and sorry such obvious stuff went through. I > will go through my whole patchset again more carefully lookup all the bindings. > Hi Philippe, also look at the I2C sub-nodes - they should be sorted by the bus address. In most of the patches it is not correct. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Subject: Re: [PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards Date: Wed, 31 Jul 2019 08:54:35 +0200 Message-ID: References: <20190730144649.19022-1-dev@pschenker.ch> <20190730144649.19022-13-dev@pschenker.ch> <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Philippe Schenker , "festevam@gmail.com" Cc: "stefan@agner.ch" , Marcel Ziswiler , "kernel@pengutronix.de" , Max Krummenacher , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "s.hauer@pengutronix.de" , "robh+dt@kernel.org" , "linux-imx@nxp.com" List-Id: devicetree@vger.kernel.org On 31. 07. 19 8:43, Philippe Schenker wrote: > On Tue, 2019-07-30 at 17:46 -0300, Fabio Estevam wrote: >> On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: >> >>> + /* Atmel maxtouch controller */ >>> + atmel_mxt_ts: atmel_mxt_ts@4a { >> >> Generic node names, please: >> >> touchscreen@4a >> >>> + compatible = "atmel,maxtouch"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_pcap_1>; >>> + reg = <0x4a>; >>> + interrupt-parent = <&gpio1>; >>> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* SODIMM 28 */ >>> + reset-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; /* SODIMM 30 */ >>> + status = "disabled"; >>> + }; >>> + >>> + /* >>> + * the PCAPs use SODIMM 28/30, also used for PWM, PWM, aka >>> pwm1, >>> + * pwm4. So if you enable one of the PCAP controllers disable the >>> pwms. >>> + */ >>> + pcap: pcap@10 { >> >> touchscreen@10 >> >>> + /* TouchRevolution Fusion 7 and 10 multi-touch controller */ >>> + compatible = "touchrevolution,fusion-f0710a"; >> >> I do not find this binding documented. > > Thanks for your feedback Fabio, and sorry such obvious stuff went through. I > will go through my whole patchset again more carefully lookup all the bindings. > Hi Philippe, also look at the I2C sub-nodes - they should be sorted by the bus address. In most of the patches it is not correct. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656F9C32751 for ; Wed, 31 Jul 2019 06:54:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 385B420693 for ; Wed, 31 Jul 2019 06:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AiWMzgSv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ysoft.com header.i=@ysoft.com header.b="evXEg1Zu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 385B420693 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ysoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GhA+8VEHbJRf3l1S/dgzE4It8MIVFROxMOKtn6WsB50=; b=AiWMzgSvhZkyDhsPLyhXdAZ1g TzN4km3nHrfd3kKbbdrNxljeg/Cr6wHQGpPV7yKQuyzKaCO6n8AbcasN05qTq32IZLDzSf2PNz7PL ugUqiApW8fSksEetqCQjDJAlctKsvuE2TwZEg9D7djbpb0M23AoqW8vW66VjBE9p9dmmbz20HaYqu /0SRYMwLiK8OBZJeO0TrYym+7dAUSeW+IHyGut3DazUDPusifPIzGGZNJVdiYu6FBp+87yNfEcEfF blOFPSvdZ15PxxxsOziEQJrhcTB37LYGcGC7lnt4EX1dqFyErVkqq1S4FxxNmLp3TD8wdj7HM5fd8 Pp0aEIxAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsiVd-00041A-Kv; Wed, 31 Jul 2019 06:54:49 +0000 Received: from uho.ysoft.cz ([81.19.3.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsiVa-00040l-S2 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 06:54:48 +0000 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 99908A415D; Wed, 31 Jul 2019 08:54:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1564556075; bh=ThsOhNRIajeNUym+bp8b02ILLZbpBe61k5u1jccGA4k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=evXEg1ZuUxWP5CJvP5psdM7di4WpQYJivbeMTIixKqBCqE5GLn7H9RwcZR32Y9oyR 0CL+5q84x8jCK4nU/WyASAM7NFAPO22oFL030wS+cqdlLl2hNMzqijqHnL2zdoe7F+ JULn9s28Y+22TEIhoV6IwIT/mB9rauMJ3VqlXPhw= Subject: Re: [PATCH 12/22] ARM: dts: imx6: Add touchscreens used on Toradex eval boards To: Philippe Schenker , "festevam@gmail.com" References: <20190730144649.19022-1-dev@pschenker.ch> <20190730144649.19022-13-dev@pschenker.ch> <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: Date: Wed, 31 Jul 2019 08:54:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <60760aa2d4710252e13877c409d0c4d2267824a6.camel@toradex.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_235447_066356_A3AD1055 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" , Marcel Ziswiler , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , Max Krummenacher , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31. 07. 19 8:43, Philippe Schenker wrote: > On Tue, 2019-07-30 at 17:46 -0300, Fabio Estevam wrote: >> On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker wrote: >> >>> + /* Atmel maxtouch controller */ >>> + atmel_mxt_ts: atmel_mxt_ts@4a { >> >> Generic node names, please: >> >> touchscreen@4a >> >>> + compatible = "atmel,maxtouch"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_pcap_1>; >>> + reg = <0x4a>; >>> + interrupt-parent = <&gpio1>; >>> + interrupts = <9 IRQ_TYPE_EDGE_FALLING>; /* SODIMM 28 */ >>> + reset-gpios = <&gpio2 10 GPIO_ACTIVE_HIGH>; /* SODIMM 30 */ >>> + status = "disabled"; >>> + }; >>> + >>> + /* >>> + * the PCAPs use SODIMM 28/30, also used for PWM, PWM, aka >>> pwm1, >>> + * pwm4. So if you enable one of the PCAP controllers disable the >>> pwms. >>> + */ >>> + pcap: pcap@10 { >> >> touchscreen@10 >> >>> + /* TouchRevolution Fusion 7 and 10 multi-touch controller */ >>> + compatible = "touchrevolution,fusion-f0710a"; >> >> I do not find this binding documented. > > Thanks for your feedback Fabio, and sorry such obvious stuff went through. I > will go through my whole patchset again more carefully lookup all the bindings. > Hi Philippe, also look at the I2C sub-nodes - they should be sorted by the bus address. In most of the patches it is not correct. Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel