From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24E2FC433F5 for ; Mon, 23 May 2022 10:13:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.335764.559951 (Exim 4.92) (envelope-from ) id 1nt53M-0003FN-BR; Mon, 23 May 2022 10:12:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 335764.559951; Mon, 23 May 2022 10:12:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53M-0003FG-82; Mon, 23 May 2022 10:12:44 +0000 Received: by outflank-mailman (input) for mailman id 335764; Mon, 23 May 2022 10:12:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53L-0003FA-8u for xen-devel@lists.xenproject.org; Mon, 23 May 2022 10:12:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nt53K-0004uc-RJ; Mon, 23 May 2022 10:12:42 +0000 Received: from [54.239.6.189] (helo=[192.168.27.249]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nt53K-0005rG-Kf; Mon, 23 May 2022 10:12:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TZYJXEONpXWC5QOC3nHKsqTq8o3wfdN146Gq25qnHXo=; b=Mzc4J3pCHORuq82i514Jdc6bBj fVb1AuOhIOL2FqzguAiRyjC7OK4oPzrZiaxx1WfCBXaUDo0nBLgXsvSuyLVkGv6/hDmSRTqQ55AJG 5EJurcTfuKwPIt7SM1MV2hjaT/pQdVEQKmY5o6+SNPAxgMPLNSTDUcvfBOw41REXniWk=; Message-ID: Date: Mon, 23 May 2022 11:12:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 4/6] xen: Switch to byteswap To: Lin Liu , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> From: Julien Grall In-Reply-To: <3f8e73fdfb222b0d1ff391a18fa2a799f68a467c.1653295437.git.lin.liu@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 23/05/2022 10:52, Lin Liu wrote: > Update to use byteswap to swap bytes. I am still objecting on switching from be*_to_cpup() to be*_to_cpu(). I will not Nack, however the strict minimum is to explain why you want to replace the helpers as I think the reason that was currently provided is incorrect. Cheers, -- Julien Grall