From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E6EC04AB6 for ; Tue, 28 May 2019 08:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5687D2075C for ; Tue, 28 May 2019 08:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbfE1IU3 (ORCPT ); Tue, 28 May 2019 04:20:29 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:51756 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfE1IU3 (ORCPT ); Tue, 28 May 2019 04:20:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82DCE341; Tue, 28 May 2019 01:20:28 -0700 (PDT) Received: from [10.162.40.141] (p8cg001049571a15.blr.arm.com [10.162.40.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B8A83F59C; Tue, 28 May 2019 01:20:24 -0700 (PDT) Subject: Re: [PATCH 3/4] arm64/kprobes: set VM_FLUSH_RESET_PERMS on kprobe instruction pages To: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Cc: mark.rutland@arm.com, marc.zyngier@arm.com, Will Deacon , linux-kernel@vger.kernel.org, Peter Zijlstra , Nadav Amit , Masami Hiramatsu , James Morse , Andrew Morton , Rick Edgecombe References: <20190523102256.29168-1-ard.biesheuvel@arm.com> <20190523102256.29168-4-ard.biesheuvel@arm.com> From: Anshuman Khandual Message-ID: Date: Tue, 28 May 2019 13:50:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190523102256.29168-4-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2019 03:52 PM, Ard Biesheuvel wrote: > In order to avoid transient inconsistencies where freed code pages > are remapped writable while stale TLB entries still exist on other > cores, mark the kprobes text pages with the VM_FLUSH_RESET_PERMS > attribute. This instructs the core vmalloc code not to defer the > TLB flush when this region is unmapped and returned to the page > allocator. Makes sense. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/probes/kprobes.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index 2509fcb6d404..036cfbf9682a 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -131,8 +131,10 @@ void *alloc_insn_page(void) > void *page; > > page = vmalloc_exec(PAGE_SIZE); > - if (page) > + if (page) { > set_memory_ro((unsigned long)page, 1); > + set_vm_flush_reset_perms(page); > + } Looks good. It seems there might be more users who would like to set VM_FLUSH_RESET_PERMS right after their allocation for the same reason. Hence would not it help to have a variant like vmalloc_exec_reset() or such which will tag vm_struct->flags with VM_FLUSH_RESET_PERMS right after it's allocation without requiring the caller to do the same. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1469FC04AB6 for ; Tue, 28 May 2019 08:20:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE6F420883 for ; Tue, 28 May 2019 08:20:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cGR/zAHy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE6F420883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SKwLCt9Zeu0tsDTgPS818e0Fk/TLMsLs2WodmhoDsVc=; b=cGR/zAHy2qBlMX zM73KRanCK61FxQfa/YSmlGFUmvX6dr1ywdaus20Q71x0LXgYyo4nl/xkRs4eJU3/ceWeKjQDlrE6 EAVpWTYZAakUlnKGGirkW8YdbJdqyZGgtR+wYX0csyNkToIdtpLuqF6CEv7k/sNUw1I7SLOmrQsAc qDTtDakZ3t0pD0WcHymc3LaIJMYDRB3dcTOt9OALrXBjbb4b2VQiD5/5wiQbOceHnCzbMVx0oF4Se Ptlu9YadE2GaVhZEUhTl2+NKGwYS/lr1dc1epKGmUMGz6WS0kCSqkJ/Nxl0wrkktWzjHTABi1Wsfj w2gvhvj/JxzmpbfUEA9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXLT-0002eV-PK; Tue, 28 May 2019 08:20:31 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXLR-0002e7-0m for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2019 08:20:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 82DCE341; Tue, 28 May 2019 01:20:28 -0700 (PDT) Received: from [10.162.40.141] (p8cg001049571a15.blr.arm.com [10.162.40.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B8A83F59C; Tue, 28 May 2019 01:20:24 -0700 (PDT) Subject: Re: [PATCH 3/4] arm64/kprobes: set VM_FLUSH_RESET_PERMS on kprobe instruction pages To: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org References: <20190523102256.29168-1-ard.biesheuvel@arm.com> <20190523102256.29168-4-ard.biesheuvel@arm.com> From: Anshuman Khandual Message-ID: Date: Tue, 28 May 2019 13:50:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190523102256.29168-4-ard.biesheuvel@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_012029_067628_001B401C X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, marc.zyngier@arm.com, Will Deacon , linux-kernel@vger.kernel.org, Peter Zijlstra , Nadav Amit , Masami Hiramatsu , James Morse , Andrew Morton , Rick Edgecombe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/23/2019 03:52 PM, Ard Biesheuvel wrote: > In order to avoid transient inconsistencies where freed code pages > are remapped writable while stale TLB entries still exist on other > cores, mark the kprobes text pages with the VM_FLUSH_RESET_PERMS > attribute. This instructs the core vmalloc code not to defer the > TLB flush when this region is unmapped and returned to the page > allocator. Makes sense. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/probes/kprobes.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index 2509fcb6d404..036cfbf9682a 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -131,8 +131,10 @@ void *alloc_insn_page(void) > void *page; > > page = vmalloc_exec(PAGE_SIZE); > - if (page) > + if (page) { > set_memory_ro((unsigned long)page, 1); > + set_vm_flush_reset_perms(page); > + } Looks good. It seems there might be more users who would like to set VM_FLUSH_RESET_PERMS right after their allocation for the same reason. Hence would not it help to have a variant like vmalloc_exec_reset() or such which will tag vm_struct->flags with VM_FLUSH_RESET_PERMS right after it's allocation without requiring the caller to do the same. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel