From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [PATCH v10 26/28] qmp: add query-sev-capabilities command Date: Thu, 1 Mar 2018 14:13:37 -0600 Message-ID: References: <20180228211028.83970-1-brijesh.singh@amd.com> <20180228211028.83970-27-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "Edgar E. Iglesias" , Peter Maydell , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcel Apfelbaum , Markus Armbruster , Peter Crosthwaite , Richard Henderson , "Dr. David Alan Gilbert" , Alistair Francis , Christian Borntraeger , Alexander Graf , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Thomas Lendacky , Borislav Petkov , Bruce Rogers To: Brijesh Singh , qemu-devel@nongnu.org Return-path: In-Reply-To: <20180228211028.83970-27-brijesh.singh@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On 02/28/2018 03:10 PM, Brijesh Singh wrote: > The command can be used by libvirt to query the SEV capabilities. >=20 > Cc: "Daniel P. Berrang=C3=A9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Signed-off-by: Brijesh Singh > --- > monitor.c | 7 +++++++ > qapi-schema.json | 42 ++++++++++++++++++++++++++++++++++++++++++ > target/i386/monitor.c | 5 +++++ > 3 files changed, 54 insertions(+) And another rebase victim. > +## > +# @query-sev-capabilities: > +# > +# This command is used to get the SEV capabilities and supported on AM= D grammar suggestion: s/capabilities and/capabilities, and is/ > +# X86 platform only. s/platform/platforms/ > +# > +# Returns: a list of SevCapability objects. This says it returns a list of objects... > +# > +# Since: 2.12 > +# > +# Example: > +# > +# -> { "execute": "query-sev-capabilities" } ...but this says it returns a single object. > +# <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE", > +# "cbitpos": 47, "reduced-phys-bits": 5}} > +# > +## > +{ 'command': 'query-sev-capabilities', 'returns': 'SevCapability' } > diff --git a/target/i386/monitor.c b/target/i386/monitor.c > index 577d50eebaaa..1b55dd0fff88 100644 > --- a/target/i386/monitor.c > +++ b/target/i386/monitor.c > @@ -737,3 +737,8 @@ SevLaunchMeasureInfo *qmp_query_sev_launch_measure(= Error **errp) > =20 > return info; > } > + > +SevCapability *qmp_query_sev_capabilities(Error **errp) > +{ > + return NULL; Should call error_setg() before returning NULL. > +} >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erUaK-0001bu-FK for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:13:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erUaG-0008I1-6E for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:13:48 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59514 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1erUaG-0008HV-0Y for qemu-devel@nongnu.org; Thu, 01 Mar 2018 15:13:44 -0500 References: <20180228211028.83970-1-brijesh.singh@amd.com> <20180228211028.83970-27-brijesh.singh@amd.com> From: Eric Blake Message-ID: Date: Thu, 1 Mar 2018 14:13:37 -0600 MIME-Version: 1.0 In-Reply-To: <20180228211028.83970-27-brijesh.singh@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v10 26/28] qmp: add query-sev-capabilities command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh , qemu-devel@nongnu.org Cc: Alistair Francis , Christian Borntraeger , Cornelia Huck , "Daniel P . Berrange" , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , "Edgar E. Iglesias" , Eduardo Habkost , kvm@vger.kernel.org, Marcel Apfelbaum , Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Peter Maydell , Richard Henderson , Stefan Hajnoczi , Thomas Lendacky , Borislav Petkov , Alexander Graf , Bruce Rogers On 02/28/2018 03:10 PM, Brijesh Singh wrote: > The command can be used by libvirt to query the SEV capabilities. >=20 > Cc: "Daniel P. Berrang=C3=A9" > Cc: "Dr. David Alan Gilbert" > Cc: Markus Armbruster > Signed-off-by: Brijesh Singh > --- > monitor.c | 7 +++++++ > qapi-schema.json | 42 ++++++++++++++++++++++++++++++++++++++++++ > target/i386/monitor.c | 5 +++++ > 3 files changed, 54 insertions(+) And another rebase victim. > +## > +# @query-sev-capabilities: > +# > +# This command is used to get the SEV capabilities and supported on AM= D grammar suggestion: s/capabilities and/capabilities, and is/ > +# X86 platform only. s/platform/platforms/ > +# > +# Returns: a list of SevCapability objects. This says it returns a list of objects... > +# > +# Since: 2.12 > +# > +# Example: > +# > +# -> { "execute": "query-sev-capabilities" } ...but this says it returns a single object. > +# <- { "return": { "pdh": "8CCDD8DDD", "cert-chain": "888CCCDDDEE", > +# "cbitpos": 47, "reduced-phys-bits": 5}} > +# > +## > +{ 'command': 'query-sev-capabilities', 'returns': 'SevCapability' } > diff --git a/target/i386/monitor.c b/target/i386/monitor.c > index 577d50eebaaa..1b55dd0fff88 100644 > --- a/target/i386/monitor.c > +++ b/target/i386/monitor.c > @@ -737,3 +737,8 @@ SevLaunchMeasureInfo *qmp_query_sev_launch_measure(= Error **errp) > =20 > return info; > } > + > +SevCapability *qmp_query_sev_capabilities(Error **errp) > +{ > + return NULL; Should call error_setg() before returning NULL. > +} >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org