From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5490BC433F5 for ; Thu, 5 May 2022 18:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234291AbiEESgW (ORCPT ); Thu, 5 May 2022 14:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385133AbiEESaJ (ORCPT ); Thu, 5 May 2022 14:30:09 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A86FA49921; Thu, 5 May 2022 11:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651774842; x=1683310842; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kW5KwWZgzC3SmgpsLzBBNvOnmxUYdJFDMnc/md3fAow=; b=n9mg/wR389MSrxnR9HDa5kG1mOd7rcVuf839ZIYQwkTw2xLXdXk9y2V3 07+E1hhaFDFRmHZof6AvG17k8tsBpr56r37VsdcZpXwr2nKiPMB8nIX40 cDjqG9lO0kKkHoLOfGO4xygL389+lgt2YqSNRdFAR80yuAWxjMygRi+tN A/STlfVpZJYQy3xJtDmghWZnzT2P/9WJFxJeRD7Ov4yh2uCznoIGHrQ1A SnS1ae3qiFTM45lsmVmOrOVs+yRse40ebsnWLA/OK7HrYC5axxJcr7Bun AoLuOxJQxN1kB6D9wlphv8ZSerhzFmPx49ZhN+an9ozEvHHIoEGe6cURP w==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="354642597" X-IronPort-AV: E=Sophos;i="5.91,202,1647327600"; d="scan'208";a="354642597" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 11:19:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,202,1647327600"; d="scan'208";a="694788612" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 05 May 2022 11:19:31 -0700 Received: from [10.252.209.228] (kliang2-MOBL.ccr.corp.intel.com [10.252.209.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id B68DF5808EF; Thu, 5 May 2022 11:19:28 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 14:19:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/2] perf test: Add basic stat and topdown group test Content-Language: en-US To: Ian Rogers Cc: Caleb Biggers , Perry Taylor , Kshipra Bopardikar , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ravi Bangoria , Andi Kleen , Haowen Bai , Riccardo Mancini , Kim Phillips , Madhavan Srinivasan , Shunsuke Nakamura , Florian Fischer , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Zhengjun Xing , Stephane Eranian References: <20220505043846.3165303-1-irogers@google.com> <20220505043846.3165303-2-irogers@google.com> From: "Liang, Kan" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/2022 11:22 AM, Ian Rogers wrote: > On Thu, May 5, 2022 at 5:12 AM Liang, Kan wrote: >> >> On 5/5/2022 12:38 AM, Ian Rogers wrote: >>> Add a basic stat test. >>> Add two tests of grouping behavior for topdown events. Topdown events >>> are special as they must be grouped with the slots event first. >>> >>> Signed-off-by: Ian Rogers >>> --- >>> tools/perf/tests/shell/stat.sh | 65 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 65 insertions(+) >>> create mode 100755 tools/perf/tests/shell/stat.sh >>> >>> diff --git a/tools/perf/tests/shell/stat.sh b/tools/perf/tests/shell/stat.sh >>> new file mode 100755 >>> index 000000000000..80869ea6debc >>> --- /dev/null >>> +++ b/tools/perf/tests/shell/stat.sh >>> @@ -0,0 +1,65 @@ >>> +#!/bin/sh >>> +# perf stat tests >>> +# SPDX-License-Identifier: GPL-2.0 >>> + >>> +set -e >>> + >>> +err=0 >>> +test_default_stat() { >>> + echo "Basic stat command test" >>> + if ! perf stat true 2>&1 | egrep -q "Performance counter stats for 'true':" >>> + then >>> + echo "Basic stat command test [Failed]" >>> + err=1 >>> + return >>> + fi >>> + echo "Basic stat command test [Success]" >>> +} >>> + >>> +test_topdown_groups() { >>> + # Topdown events must be grouped with the slots event first. Test that >>> + # parse-events reorders this. >>> + echo "Topdown event group test" >>> + if ! perf stat -e '{slots,topdown-retiring}' true > /dev/null 2>&1 >>> + then >>> + echo "Topdown event group test [Skipped event parsing failed]" >>> + return >>> + fi >>> + if perf stat -e '{slots,topdown-retiring}' true 2>&1 | egrep -q "" >>> + then >>> + echo "Topdown event group test [Failed events not supported]" >>> + err=1 >>> + return >>> + fi >>> + if perf stat -e '{topdown-retiring,slots}' true 2>&1 | egrep -q "" >>> + then >>> + echo "Topdown event group test [Failed slots not reordered first]" >>> + err=1 >>> + return >>> + fi >>> + echo "Topdown event group test [Success]" >>> +} >>> + >>> +test_topdown_weak_groups() { >>> + # Weak groups break if the perf_event_open of multiple grouped events >>> + # fails. Breaking a topdown group causes the events to fail. Test a very large >>> + # grouping to see that the topdown events aren't broken out. >>> + echo "Topdown weak groups test" >>> + if ! perf stat -e '{slots,topdown-bad-spec,topdown-be-bound,topdown-fe-bound,topdown-retiring},branch-instructions,branch-misses,bus-cycles,cache-misses,cache-references,cpu-cycles,instructions,mem-loads,mem-stores,ref-cycles,baclears.any,ARITH.DIVIDER_ACTIVE' true > /dev/null 2>&1 >>> + then >>> + echo "Topdown weak groups test [Skipped event parsing failed]" >>> + return >>> + fi >>> + if perf stat -e '{slots,topdown-bad-spec,topdown-be-bound,topdown-fe-bound,topdown-retiring,branch-instructions,branch-misses,bus-cycles,cache-misses,cache-references,cpu-cycles,instructions,mem-loads,mem-stores,ref-cycles,baclears.any,ARITH.DIVIDER_ACTIVE}:W' true 2>&1 | egrep -q "" >>> + then >>> + echo "Topdown weak groups test [Failed events not supported]" >>> + err=1 >>> + return >>> + fi >>> + echo "Topdown weak groups test [Success]" >>> +} >>> + >> >> Should we check the existence of the slots event before the test? >> The perf metrics feature only be available on the new platform after >> ICL. It doesn't work on Atom. >> >> Also, I think the test may fails on the hybrid platform, since big core >> and small core have different formula for the topdown. I think we should >> avoid the test for the hybrid platform for now. >> +Zhengjun, who is fixing the topdown gap for the hybrid platform. I >> think he may take care of the hybrid support later. > > Thanks Kan, the test filters out systems that don't support the events > and silently skips the test. The main purpose of the test is to make > sure the somewhat complicated grouping operations for Icelake have > some coverage. Adding more coverage for hybrid would be great, but not > something I think gates this change. > Sure, we can add the coverage for hybrid later. But please make sure the test can filter out both the systems which doesn't support perf metircs and the hybrid system. Thanks, Kan > Thanks, > Ian > >> Thanks, >> Kan >>> +test_default_stat >>> +test_topdown_groups >>> +test_topdown_weak_groups >>> +exit $err