* [PATCH] io_uring: Fix comment of io_get_sqe
@ 2021-06-04 16:42 Fam Zheng
2021-06-15 13:02 ` Pavel Begunkov
2021-06-15 21:39 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Fam Zheng @ 2021-06-04 16:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Jens Axboe, Pavel Begunkov, io-uring, fam.zheng, fam
The sqe_ptr argument has been gone since 709b302faddf (io_uring:
simplify io_get_sqring, 2020-04-08), made the return value of the
function. Update the comment accordingly.
Signed-off-by: Fam Zheng <fam.zheng@bytedance.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 903458afd56c..bb3685ba335d 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
}
/*
- * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
+ * Fetch an sqe, if one is available. Note this returns a pointer to memory
* that is mapped by userspace. This means that care needs to be taken to
* ensure that reads are stable, as we cannot rely on userspace always
* being a good citizen. If members of the sqe are validated and then later
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring: Fix comment of io_get_sqe
2021-06-04 16:42 [PATCH] io_uring: Fix comment of io_get_sqe Fam Zheng
@ 2021-06-15 13:02 ` Pavel Begunkov
2021-06-15 21:39 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Begunkov @ 2021-06-15 13:02 UTC (permalink / raw)
To: Fam Zheng, linux-kernel; +Cc: Jens Axboe, io-uring, fam
On 6/4/21 5:42 PM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
>
> Signed-off-by: Fam Zheng <fam.zheng@bytedance.com>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 903458afd56c..bb3685ba335d 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
> }
>
> /*
> - * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
> + * Fetch an sqe, if one is available. Note this returns a pointer to memory
> * that is mapped by userspace. This means that care needs to be taken to
> * ensure that reads are stable, as we cannot rely on userspace always
> * being a good citizen. If members of the sqe are validated and then later
>
--
Pavel Begunkov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] io_uring: Fix comment of io_get_sqe
2021-06-04 16:42 [PATCH] io_uring: Fix comment of io_get_sqe Fam Zheng
2021-06-15 13:02 ` Pavel Begunkov
@ 2021-06-15 21:39 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-06-15 21:39 UTC (permalink / raw)
To: Fam Zheng, linux-kernel; +Cc: Pavel Begunkov, io-uring, fam
On 6/4/21 10:42 AM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-15 21:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 16:42 [PATCH] io_uring: Fix comment of io_get_sqe Fam Zheng
2021-06-15 13:02 ` Pavel Begunkov
2021-06-15 21:39 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.