From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B12C388F9 for ; Sun, 8 Nov 2020 16:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B7AD206F4 for ; Sun, 8 Nov 2020 16:53:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O7ZSLo3d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728709AbgKHQxC (ORCPT ); Sun, 8 Nov 2020 11:53:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728104AbgKHQxB (ORCPT ); Sun, 8 Nov 2020 11:53:01 -0500 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 925C9C0613CF; Sun, 8 Nov 2020 08:53:01 -0800 (PST) Received: by mail-ej1-x644.google.com with SMTP id 7so8884153ejm.0; Sun, 08 Nov 2020 08:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Rikl1cMUQrKKRfEty9vlE0bbTP/gldAUaSt6ZFA6Ac4=; b=O7ZSLo3dzGjafmpqqFnclreHOVe9FkJWqozL3Ixox4tRNR66EfsvsldQX1ywpxfjsN RxLCV/t8rwjqoS0VNyMR9fAvqEPMRCKifgbUkEpBu4oXxgck+aKQ9vQfihDe31SW7T2+ HF9wV5lavJbBkjFH6CL5mrwyIfFsF5B8Q+Sm4Rp5j0ti2oDzuuNc71na6PoL1/31jGTf WYBg/D3Dz3clJFZmKqg7M+Xukf6JxXQKulyUYLP7osdyFrPVBXlNXIg/gRSMcBLLA9sq TOzmPfq0y0Nv4So+3kAdpzo7RU/NUEXay5V1Wl9GmjFupYnCUkQFXnl91YAv/lerJSCq 6Z7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Rikl1cMUQrKKRfEty9vlE0bbTP/gldAUaSt6ZFA6Ac4=; b=OlUrt2vLc3eKwbna8ayh0DL28QpmRWo6RwKDO2aQy7Ug1yPYzgov5XpPykNmBgj0TX Z2qsBZMEgMX0JyNCdUfGRob1NQyRTUVHyndehJ47Zg/5uW0sO/Ge5azcKhiIoDwvD61x dT9A8MJDTfaqExYigKolEUGw5zqJX1p81afJNfKXBsKNFQVrBu/vDzJ9EYs9fnnGv2pj //LNspaF+1PY9iO2ASbmqZNMr8HIIWXG0LZAX96gY6OXO1I/fKyAX/H7StJKdqVFEvOZ Rgv4rbPZ+VlpL/rhNOOeLvzMwa7UVDa+vBjcudbuMZxc71P14XM99xDY3nkGjHvuKnSZ xrbA== X-Gm-Message-State: AOAM533OIUr44fedt6CyX7zjBBq7QSUvrn/wF6eSB8ycVR7FWu+od19U PtmFH6usjydv+Yp0gPGflFc= X-Google-Smtp-Source: ABdhPJzKeFZ4YDUaRqvql2Gqeb1pkAFCZ/bH4q99bP/i+x+1fPoTwk4Ei85xGYCuw3ehxLZ+6mSYeA== X-Received: by 2002:a17:906:74c6:: with SMTP id z6mr11832276ejl.448.1604854380356; Sun, 08 Nov 2020 08:53:00 -0800 (PST) Received: from ?IPv6:2a01:110f:b59:fd00:a483:75f7:76d4:f590? ([2a01:110f:b59:fd00:a483:75f7:76d4:f590]) by smtp.gmail.com with ESMTPSA id b6sm6684948edu.21.2020.11.08.08.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2020 08:52:59 -0800 (PST) Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Pavel Machek , Dan Murphy , Bjorn Andersson , Andy Gross , Rob Herring Cc: linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Brian Masney , Luca Weiss , Russell King , Georgi Djakov , linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org, andrealmeid@collabora.com References: <20201106165737.1029106-1-nfraprado@protonmail.com> <20201106165737.1029106-2-nfraprado@protonmail.com> From: Jacek Anaszewski Message-ID: Date: Sun, 8 Nov 2020 17:52:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hi Nicolas, We have LED flash class framework since 2015. Please refer to the following files: Documentation/leds/leds-class-flash.rst Documentation/ABI/testing/sysfs-class-led-flash Documentation/devicetree/bindings/leds/common.yaml drivers/leds/led-class-flash.c Thare are also few LED flash drivers in the tree. Since there seems to be boost feature present on the the device then you might want to compare drivers/leds/leds-max77693.c with its bindings Documentation/devicetree/bindings/mfd/max77693.txt (refer to LED part). Please also remember to include DT bindings patch to your series. On 11/6/20 5:58 PM, Nícolas F. R. A. Prado wrote: > Add driver for the QPNP flash LED. It works over SPMI and is part of the > PM8941 PMIC. > > Signed-off-by: Nícolas F. R. A. Prado > --- > drivers/leds/Kconfig | 9 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-qpnp.c | 1351 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1361 insertions(+) > create mode 100644 drivers/leds/leds-qpnp.c > -- Best regards, Jacek Anaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59DB5C388F9 for ; Sun, 8 Nov 2020 16:53:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6202206F4 for ; Sun, 8 Nov 2020 16:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="caIoGlqr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O7ZSLo3d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6202206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MtZ3f7MltlYgm9YYzYe9P7ZK+fXiPFW1H0uwEF6gCTw=; b=caIoGlqrYuGqGKXxxs8bon5Yq S62nMintdQCb3ZW3oQOdC6F8ZPRaxLB0OUnhxmngTfxfzuOdY64a5s5JCJu2zAQtfXiWBQMVaul0v CrG/4sjoPKXDrcY78QdMykk4C7Ncy8AX77XirasfhfAWPcHkbERQxTzCosnBhPrEdbc2BigG2a677 mMcMD6hQ10o/6vfLZWi/s5/MU4kKDFbdlpq7n0P/Cp9jFv2EMdADHaAQwaQFBFWNXfFUm6kfcgmMH b7bRH5QlcOQHGK68UlWOa+pIZbS9t5f5WP0LoxmwuJaoZp6xQTnafZEWp4whubjTui1rTgOqGNegC UkgY4hHsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbnw9-0000ir-MW; Sun, 08 Nov 2020 16:53:05 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbnw6-0000iR-Uk for linux-arm-kernel@lists.infradead.org; Sun, 08 Nov 2020 16:53:03 +0000 Received: by mail-ej1-x642.google.com with SMTP id i19so8864378ejx.9 for ; Sun, 08 Nov 2020 08:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Rikl1cMUQrKKRfEty9vlE0bbTP/gldAUaSt6ZFA6Ac4=; b=O7ZSLo3dzGjafmpqqFnclreHOVe9FkJWqozL3Ixox4tRNR66EfsvsldQX1ywpxfjsN RxLCV/t8rwjqoS0VNyMR9fAvqEPMRCKifgbUkEpBu4oXxgck+aKQ9vQfihDe31SW7T2+ HF9wV5lavJbBkjFH6CL5mrwyIfFsF5B8Q+Sm4Rp5j0ti2oDzuuNc71na6PoL1/31jGTf WYBg/D3Dz3clJFZmKqg7M+Xukf6JxXQKulyUYLP7osdyFrPVBXlNXIg/gRSMcBLLA9sq TOzmPfq0y0Nv4So+3kAdpzo7RU/NUEXay5V1Wl9GmjFupYnCUkQFXnl91YAv/lerJSCq 6Z7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Rikl1cMUQrKKRfEty9vlE0bbTP/gldAUaSt6ZFA6Ac4=; b=OcX/IY+YPg1ClTZR1Tpxd9ASumpH2BnDLsZb/BHDNRTuwUaggjBGmcaYTpJCo+LA8l U8OqdkWjgUtZkEQj9lx4ExotviBKBrnKpQYcV9C94kMgXfglBhQUehTNKDhAoS9eJlS8 yndgAMfqGEDnDxET/Wc7NpYvSNXQ9iOnGCAqf/hqHIMQssQ9MdeNisQUIZA42eEFet1g JhVSCEMZf4c/0209QGgXmnC68UeWdeQd44VSCj7RMtwx+gpLEBH5x6atq+E254HDrOQI UVHkchOndXtnA6k6IuXNCulxJI5Sr56BixPssdCBWW0/xBUML9shUhEB4LiZFWlP4LI3 KXtA== X-Gm-Message-State: AOAM531BhNFZ3+gOrze34KuCNlS44n7p+Mlp8h+EZfmwvxnhE+GVN4v2 nj5rjwGWLgnzmLQxP0uLLEY= X-Google-Smtp-Source: ABdhPJzKeFZ4YDUaRqvql2Gqeb1pkAFCZ/bH4q99bP/i+x+1fPoTwk4Ei85xGYCuw3ehxLZ+6mSYeA== X-Received: by 2002:a17:906:74c6:: with SMTP id z6mr11832276ejl.448.1604854380356; Sun, 08 Nov 2020 08:53:00 -0800 (PST) Received: from ?IPv6:2a01:110f:b59:fd00:a483:75f7:76d4:f590? ([2a01:110f:b59:fd00:a483:75f7:76d4:f590]) by smtp.gmail.com with ESMTPSA id b6sm6684948edu.21.2020.11.08.08.52.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2020 08:52:59 -0800 (PST) Subject: Re: [RFC PATCH 1/3] leds: Add driver for QPNP flash led To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Pavel Machek , Dan Murphy , Bjorn Andersson , Andy Gross , Rob Herring References: <20201106165737.1029106-1-nfraprado@protonmail.com> <20201106165737.1029106-2-nfraprado@protonmail.com> From: Jacek Anaszewski Message-ID: Date: Sun, 8 Nov 2020 17:52:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201106165737.1029106-2-nfraprado@protonmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201108_115303_007178_84CF05FA X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Luca Weiss , lkcamp@lists.libreplanetbr.org, linux-leds@vger.kernel.org, andrealmeid@collabora.com, Georgi Djakov , linux-arm-kernel@lists.infradead.org, Brian Masney Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTmljb2xhcywKCldlIGhhdmUgTEVEIGZsYXNoIGNsYXNzIGZyYW1ld29yayBzaW5jZSAyMDE1 LiBQbGVhc2UgcmVmZXIgdG8gdGhlCmZvbGxvd2luZyBmaWxlczoKCkRvY3VtZW50YXRpb24vbGVk cy9sZWRzLWNsYXNzLWZsYXNoLnJzdApEb2N1bWVudGF0aW9uL0FCSS90ZXN0aW5nL3N5c2ZzLWNs YXNzLWxlZC1mbGFzaApEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9jb21t b24ueWFtbApkcml2ZXJzL2xlZHMvbGVkLWNsYXNzLWZsYXNoLmMKClRoYXJlIGFyZSBhbHNvIGZl dyBMRUQgZmxhc2ggZHJpdmVycyBpbiB0aGUgdHJlZS4gU2luY2UgdGhlcmUgc2VlbXMgdG8KYmUg Ym9vc3QgZmVhdHVyZSBwcmVzZW50IG9uIHRoZSB0aGUgZGV2aWNlIHRoZW4geW91IG1pZ2h0IHdh bnQgdG8KY29tcGFyZSBkcml2ZXJzL2xlZHMvbGVkcy1tYXg3NzY5My5jIHdpdGggaXRzIGJpbmRp bmdzCkRvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvbWF4Nzc2OTMudHh0IChy ZWZlciB0byBMRUQgcGFydCkuCgpQbGVhc2UgYWxzbyByZW1lbWJlciB0byBpbmNsdWRlIERUIGJp bmRpbmdzIHBhdGNoIHRvIHlvdXIgc2VyaWVzLgoKT24gMTEvNi8yMCA1OjU4IFBNLCBOw61jb2xh cyBGLiBSLiBBLiBQcmFkbyB3cm90ZToKPiBBZGQgZHJpdmVyIGZvciB0aGUgUVBOUCBmbGFzaCBM RUQuIEl0IHdvcmtzIG92ZXIgU1BNSSBhbmQgaXMgcGFydCBvZiB0aGUKPiBQTTg5NDEgUE1JQy4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQHBy b3Rvbm1haWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9sZWRzL0tjb25maWcgICAgIHwgICAgOSAr Cj4gICBkcml2ZXJzL2xlZHMvTWFrZWZpbGUgICAgfCAgICAxICsKPiAgIGRyaXZlcnMvbGVkcy9s ZWRzLXFwbnAuYyB8IDEzNTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK PiAgIDMgZmlsZXMgY2hhbmdlZCwgMTM2MSBpbnNlcnRpb25zKCspCj4gICBjcmVhdGUgbW9kZSAx MDA2NDQgZHJpdmVycy9sZWRzL2xlZHMtcXBucC5jCj4gCgotLSAKQmVzdCByZWdhcmRzLApKYWNl ayBBbmFzemV3c2tpCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==