From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66AA4C433E0 for ; Wed, 13 Jan 2021 07:52:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89C9323333 for ; Wed, 13 Jan 2021 07:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89C9323333 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=0bits.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzawq-0000wg-92 for qemu-devel@archiver.kernel.org; Wed, 13 Jan 2021 02:52:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzavw-0000Rm-Hw for qemu-devel@nongnu.org; Wed, 13 Jan 2021 02:51:12 -0500 Received: from uk.hasbox.com ([2a01:7e00::f03c:91ff:fe91:5fdc]:51147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzavu-0003fP-Mv for qemu-devel@nongnu.org; Wed, 13 Jan 2021 02:51:12 -0500 Received: from [10.0.0.170] ([5.30.22.212]) (authenticated bits=0) by uk.hasbox.com (8.15.2/8.15.2) with ESMTPSA id 10D7p5dq011271 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 13 Jan 2021 07:51:07 GMT Subject: Re: absolute firmware path made relocatable in qemu 5.2.0 To: Paolo Bonzini References: <428592f1-a5fd-7e6a-f181-28f31343518a@0bits.com> <3ab19db3-7339-79d5-9f4f-aee7165b531a@0bits.com> <536bbda3-ebcb-e098-2625-5de4db08422e@redhat.com> From: Dave Message-ID: Date: Wed, 13 Jan 2021 11:51:00 +0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <536bbda3-ebcb-e098-2625-5de4db08422e@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2a01:7e00::f03c:91ff:fe91:5fdc; envelope-from=dave@0bits.com; helo=uk.hasbox.com X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is my qemu binary compiled with --prefix=/nonexistent bash-5.1# ./qemu-system-x86_64 -L help /usr/share/qemu /usr/share/qemu-firmware /usr/src/sources/qemu-5.2.0/build/pc-bios bash-5.1# ./qemu-system-x86_64 --help|grep helper [,br=bridge][,helper=helper][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off] use network helper 'helper' (default=/nonexistent/libexec/qemu-bridge-helper) to -netdev bridge,id=str[,br=bridge][,helper=helper] using the program 'helper (default=/nonexistent/libexec/qemu-bridge-helper) See that it will call /nonexistent/libexec/qemu-bridge-helper by default. Dave On 12/01/2021 23:53, Paolo Bonzini wrote: > On 12/01/21 18:04, Dave wrote: >> Thanks Paola, >> >> We are still in testing and that's the only thing we've uncovered so >> far with the new 5.2.0. I will post if the ops guys find anything else. > > Hmm, that's weird though.  The path to the default bridge helper is > relocated: > > net/tap.c:        helper = default_helper = > get_relocated_path(DEFAULT_BRIDGE_HELPER); > > Paolo >