From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BD0C433F5 for ; Tue, 5 Oct 2021 19:18:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D0D961154 for ; Tue, 5 Oct 2021 19:18:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D0D961154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXpx4-0008GI-Tl for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 15:18:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXpvV-0007E5-C9 for qemu-devel@nongnu.org; Tue, 05 Oct 2021 15:16:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXpvR-0005KB-Ak for qemu-devel@nongnu.org; Tue, 05 Oct 2021 15:16:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633461387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XSX000wYKTrORxaxvWHBWfzhvR60Rd21ZXYdn21m63A=; b=DArmNil8p0j71oFdZa2F9pBw9yXgkNNNh2I/uIkkSsK8y54xGm8hv3LoGuCrFYe5w6W7zf lq3FQA00kPVDQYLX+hT8vZa2Tea0yNkRniKIKGD+m0+61CqGc8ltVi7+fiu7/AydHc5JpI pjM10SrLvGdUex1qvyAPquKkXx+o6Xc= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-icbuJBPBOq23LKXake4yNA-1; Tue, 05 Oct 2021 15:16:22 -0400 X-MC-Unique: icbuJBPBOq23LKXake4yNA-1 Received: by mail-ed1-f72.google.com with SMTP id 14-20020a508e4e000000b003d84544f33eso242412edx.2 for ; Tue, 05 Oct 2021 12:16:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=THl8aVPS6F1uabbI6Sv1L2nIDyNjKGvJ0IwK6/NADE0=; b=ULNc4xkJLLRXFLOyaM8W29eqKgfOu90fIlGXgddADyt0klt52fezpYeyV1aXaJPC20 hUBdz5AWak/UqhAn6xZRfZ5Gx2iCS4VKpHMESdkrU2fop1D54ciXevR3U4YWuwFjP7ix n93zpOLH+qFXC4H3RSFDBfIyfEJJxh/HdKHa7O5AQvPzj58U/5qvGqfGgA7OmWZC+LhV 6Pe9/Xz4+BsBiWL8AyFhX5Id2ykEIEYmHQemEiCXBqbeEOpoE3WL9WTi1WfALNqZihmX Fm/CfKup9SeIsT2Pqj6QaNDa/9vybcBOvhHeW8TqyHCsHfMJc06NXmo1eSiji1gWnOLW BlMw== X-Gm-Message-State: AOAM53333yAcqA2pYuIDFzGxLZSC/20lfX8a8iTqaKRNtBz0tbnXPsyj iHrfaI/R+9OknEIJFfGYuQwDg1nBC26oIBqxU3fu8ajAEh5tMMRPFcsMB9g3PXosCVON8m5y3mg ewH3SLD2GCvfweUE= X-Received: by 2002:a50:e006:: with SMTP id e6mr27655756edl.302.1633461380885; Tue, 05 Oct 2021 12:16:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznJNZ9FNHvj/wl0tQMYHz9WOykI1XhpZrbuwQa1FUQHWRQ/sOr0IWO9TTAFmm2WEvmvKQl+A== X-Received: by 2002:a50:e006:: with SMTP id e6mr27655711edl.302.1633461380538; Tue, 05 Oct 2021 12:16:20 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm1501250edr.64.2021.10.05.12.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:16:19 -0700 (PDT) Message-ID: Date: Tue, 5 Oct 2021 21:16:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson , qemu-devel@nongnu.org References: <20210926220103.1721355-1-f4bug@amsat.org> <20210926220103.1721355-2-f4bug@amsat.org> <4dcb518e-dd69-ed75-1d57-7fcf76c5cb69@amsat.org> From: Paolo Bonzini In-Reply-To: <4dcb518e-dd69-ed75-1d57-7fcf76c5cb69@amsat.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Kyle Evans , Laurent Vivier , Warner Losh Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 27/09/21 07:24, Philippe Mathieu-Daudé wrote: >> Why here and not in the parent meson.build? > This is what Paolo recommended me to do last time I added a > conditional inclusion. > > Personally I prefer having it in the call site rather than > the callee (no need to read the callee to notice it isn't > called). I guess this is for readability, to not clutter > meson.build? files more... Yes, pretty much. In this case it's quite obvious that bsd-user is BSD-only, but I prefer it if dir/meson.build has the knowledge of what goes on in dir/. That said, we're not terribly consistent, see have_block and have_tools, so either will be okay. Paolo > Paolo, what is your preference? >