On 12/19/2018 8:51 PM, Daniel Vetter wrote: > Indeed, I overlooked that. Maybe highlight it a bit more with a separate > > if (!CONFIG_ENABLED(MEI_HDCP)) > return false; > > so it stick out more in the previous patch. Currently it's a bit burried. > > With that + the init ordering fixed: > > Reviewed-by: Daniel Vetter Sure. Thank you. > > There's no need to split the patch out anymore, since without the mei > patches you can't enable that Kconfig option and hence no bisect issues. Still Kconfig and makefile is added at 22nd patch but component support in mei_hdcp is added at 35th patch. So even now this chunk needs to be kept after the component support addition. -Ram > > Cheers, Daniel