From mboxrd@z Thu Jan 1 00:00:00 1970 From: "C, Ramalingam" Subject: Re: [PATCH v9 07/39] drm/i915: MEI interface definition Date: Thu, 20 Dec 2018 18:48:08 +0530 Message-ID: References: <1544673701-6353-1-git-send-email-ramalingam.c@intel.com> <1544673701-6353-8-git-send-email-ramalingam.c@intel.com> <20181219140021.GE21184@phenom.ffwll.local> <20181219152114.GJ21184@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1278277602==" Return-path: In-Reply-To: <20181219152114.GJ21184@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, tomas.winkler@intel.com List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1278277602== Content-Type: multipart/alternative; boundary="------------091808D222822C13BE0A787E" Content-Language: en-US This is a multi-part message in MIME format. --------------091808D222822C13BE0A787E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/2018 8:51 PM, Daniel Vetter wrote: > Indeed, I overlooked that. Maybe highlight it a bit more with a separate > > if (!CONFIG_ENABLED(MEI_HDCP)) > return false; > > so it stick out more in the previous patch. Currently it's a bit burried. > > With that + the init ordering fixed: > > Reviewed-by: Daniel Vetter Sure. Thank you. > > There's no need to split the patch out anymore, since without the mei > patches you can't enable that Kconfig option and hence no bisect issues. Still Kconfig and makefile is added at 22nd patch but component support in mei_hdcp is added at 35th patch. So even now this chunk needs to be kept after the component support addition. -Ram > > Cheers, Daniel --------------091808D222822C13BE0A787E Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On 12/19/2018 8:51 PM, Daniel Vetter wrote:
Indeed, I overlooked that. Maybe highlight it a bit more with a separate

	if (!CONFIG_ENABLED(MEI_HDCP))
		return false;

so it stick out more in the previous patch. Currently it's a bit burried.

With that + the init ordering fixed:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Sure. Thank you.

There's no need to split the patch out anymore, since without the mei
patches you can't enable that Kconfig option and hence no bisect issues.
Still Kconfig and makefile is added at 22nd patch but component support in mei_hdcp is added at 35th patch.
So even now this chunk needs to be kept after the component support addition.

-Ram


Cheers, Daniel
--------------091808D222822C13BE0A787E-- --===============1278277602== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1278277602==--