From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] converting build system to Meson?
Date: Thu, 7 Mar 2019 12:06:11 +0100 [thread overview]
Message-ID: <e14a37bd-9606-a9f6-4426-4142fa79ded1@redhat.com> (raw)
In-Reply-To: <CAFEAcA_t=okvOgHNKHttJS0XNcoFhnhX2MHqY1AA-C+nz6d=jw@mail.gmail.com>
On 07/03/19 11:48, Peter Maydell wrote:
> On Thu, 7 Mar 2019 at 10:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> ---
>> # This would be ui/meson.build:
>>
>> vnc_sources = source_set.source_set()
>> vnc_sources.add([], files(
>> 'vnc.c',
>> 'vnc-auth-vencrypt.c',
>> 'vnc-enc-hextile.c',
>> 'vnc-enc-tight.c',
>> 'vnc-enc-zlib.c',
>> 'vnc-enc-zrle.c',
>> 'vnc-jobs.c',
>> 'vnc-palette.c',
>> 'vnc-ws.c'))
>> vnc_sources.add('CONFIG_VNC_SASL', files(
>> 'vnc-auth-sasl.c'))
>
> All this foo_sources.add() seems pretty clunky syntax,
> which doesn't seem like a good sign for what is
> pretty much the simplest possible case for the build system.
ui/Makefile.objs is actually one of the most complex cases. The quotes
and commas are indeed somewhat clunky, but I don't think the above
compares particularly negatively to
vnc-obj-y = vnc.o
vnc-obj-y += vnc-auth-vencrypt.o
vnc-obj-y += vnc-enc-hextile.o
vnc-obj-y += vnc-enc-tight.o
vnc-obj-y += vnc-enc-zlib.o
vnc-obj-y += vnc-enc-zrle.o
vnc-obj-y += vnc-jobs.o
vnc-obj-y += vnc-palette.o
vnc-obj-y += vnc-ws.o
vnc-obj-$(CONFIG_VNC_SASL) += vnc-auth-sasl.o
The simplest possible case is
common-obj-$(CONFIG_IPACK) += ipack.o tpci200.o
=> common_obj.add('CONFIG_IPACK', files('ipack.c', 'tpci200.c'))
or
qemu-keymap$(EXESUF): qemu-keymap.o ui/input-keymap.o $(COMMON_LDADDS)
qemu-keymap$(EXESUF): LIBS += $(XKBCOMMON_LIBS)
qemu-keymap$(EXESUF): QEMU_CFLAGS += $(XKBCOMMON_CFLAGS)
=> executable('qemu-keymap',
['qemu-keymap.c', 'ui/input-keymap.c'],
dependencies: [common_deps, xkbcommon])
(where the latter provides "make install" functionality without having
to touch configure).
Paolo
next prev parent reply other threads:[~2019-03-07 11:06 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 18:12 [Qemu-devel] converting build system to Meson? Paolo Bonzini
2019-03-06 18:50 ` Marc-André Lureau
2019-03-06 21:08 ` Paolo Bonzini
2019-03-07 10:29 ` Daniel P. Berrangé
2019-03-07 6:39 ` Thomas Huth
2019-03-07 10:13 ` Peter Maydell
2019-03-07 11:11 ` Paolo Bonzini
2019-03-07 11:29 ` Dr. David Alan Gilbert
2019-03-07 11:32 ` Peter Maydell
2019-03-07 11:49 ` Marc-André Lureau
2019-03-07 11:33 ` Daniel P. Berrangé
2019-03-10 14:21 ` Markus Armbruster
2019-03-10 14:33 ` Markus Armbruster
2019-03-11 16:30 ` Paolo Bonzini
2019-03-07 10:18 ` Daniel P. Berrangé
2019-03-07 10:40 ` Paolo Bonzini
2019-03-07 10:48 ` Peter Maydell
2019-03-07 11:06 ` Paolo Bonzini [this message]
2019-03-07 10:49 ` Daniel P. Berrangé
2019-03-07 10:33 ` Stefan Hajnoczi
2019-03-07 11:54 ` Alex Bennée
2019-03-07 12:56 ` Paolo Bonzini
2019-03-07 13:09 ` Peter Maydell
2019-03-07 13:22 ` Daniel P. Berrangé
2019-03-07 18:13 ` Paolo Bonzini
2019-03-07 18:17 ` Marc-André Lureau
2019-03-07 18:18 ` Peter Maydell
2019-03-07 18:19 ` Peter Maydell
2019-03-07 19:23 ` BALATON Zoltan
2019-03-07 19:50 ` Eric Blake
2019-03-07 20:28 ` Liviu Ionescu
2019-03-08 12:19 ` Daniel P. Berrangé
2019-03-07 19:04 ` Eric Blake
2019-03-07 19:24 ` Eric Blake
2019-03-08 12:21 ` Daniel P. Berrangé
2019-03-07 18:20 ` Alex Bennée
2019-03-08 6:47 ` Gerd Hoffmann
2019-03-08 6:58 ` Thomas Huth
2019-03-08 10:31 ` Peter Maydell
2019-03-08 11:58 ` Gerd Hoffmann
2019-03-08 12:03 ` Peter Maydell
2019-03-08 16:17 ` Eric Blake
2019-03-08 16:26 ` Peter Maydell
2019-03-08 16:32 ` Paolo Bonzini
2019-03-08 16:36 ` Peter Maydell
2019-03-11 1:09 ` Neal Gompa
2019-03-07 19:05 ` Cleber Rosa
2019-03-10 16:33 ` Markus Armbruster
2019-03-10 16:28 ` Markus Armbruster
2019-03-11 6:42 ` Thomas Huth
2019-03-11 10:14 ` Daniel P. Berrangé
2019-04-18 8:21 ` Markus Armbruster
2019-04-18 8:21 ` Markus Armbruster
2019-04-18 8:35 ` Paolo Bonzini
2019-04-18 8:35 ` Paolo Bonzini
2019-05-27 16:16 ` [Qemu-devel] Status update on Meson features needed by QEMU Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e14a37bd-9606-a9f6-4426-4142fa79ded1@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.