From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD205C433E0 for ; Mon, 3 Aug 2020 13:00:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE14205CB for ; Mon, 3 Aug 2020 13:00:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgHCNAS (ORCPT ); Mon, 3 Aug 2020 09:00:18 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:9321 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726941AbgHCNAS (ORCPT ); Mon, 3 Aug 2020 09:00:18 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id BBB92F67641D87B08163; Mon, 3 Aug 2020 21:00:09 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 3 Aug 2020 21:00:08 +0800 Subject: Re: [PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused To: Dmitry Osipenko , , , , , References: <20200803115901.44068-1-yuehaibing@huawei.com> <721b8d01-5d7e-09c6-5f86-705130ab31a9@gmail.com> CC: , , , From: Yuehaibing Message-ID: Date: Mon, 3 Aug 2020 21:00:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <721b8d01-5d7e-09c6-5f86-705130ab31a9@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 2020/8/3 20:51, Dmitry Osipenko wrote: > 03.08.2020 14:59, YueHaibing пишет: >> If CONFIG_PM is not set, gcc warns: >> >> drivers/staging/media/tegra-vde/vde.c:916:12: >> warning: 'tegra_vde_runtime_suspend' defined but not used [-Wunused-function] >> >> Make it __maybe_unused to fix this. >> >> Signed-off-by: YueHaibing >> --- >> drivers/staging/media/tegra-vde/vde.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/tegra-vde/vde.c b/drivers/staging/media/tegra-vde/vde.c >> index a3c24d96d5b9..2d043d518eef 100644 >> --- a/drivers/staging/media/tegra-vde/vde.c >> +++ b/drivers/staging/media/tegra-vde/vde.c >> @@ -913,7 +913,7 @@ static irqreturn_t tegra_vde_isr(int irq, void *data) >> return IRQ_HANDLED; >> } >> >> -static int tegra_vde_runtime_suspend(struct device *dev) >> +static __maybe_unused int tegra_vde_runtime_suspend(struct device *dev) >> { >> struct tegra_vde *vde = dev_get_drvdata(dev); >> int err; >> > > Hello Yue, > > Shouldn't the tegra_vde_runtime_resume() be marked as well? No, tegra_vde_runtime_resume() always be called by tegra_vde_shutdown(). > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75819C433DF for ; Mon, 3 Aug 2020 13:00:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5314120775 for ; Mon, 3 Aug 2020 13:00:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5314120775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 18D2186174; Mon, 3 Aug 2020 13:00:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6uZEoswVF4f5; Mon, 3 Aug 2020 13:00:17 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 783DA864C5; Mon, 3 Aug 2020 13:00:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id E68B61BF3C5 for ; Mon, 3 Aug 2020 13:00:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DD932864C5 for ; Mon, 3 Aug 2020 13:00:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zrTXQ8Flv0+v for ; Mon, 3 Aug 2020 13:00:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by whitealder.osuosl.org (Postfix) with ESMTPS id 28BE286174 for ; Mon, 3 Aug 2020 13:00:13 +0000 (UTC) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id BBB92F67641D87B08163; Mon, 3 Aug 2020 21:00:09 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Mon, 3 Aug 2020 21:00:08 +0800 Subject: Re: [PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused To: Dmitry Osipenko , , , , , References: <20200803115901.44068-1-yuehaibing@huawei.com> <721b8d01-5d7e-09c6-5f86-705130ab31a9@gmail.com> From: Yuehaibing Message-ID: Date: Mon, 3 Aug 2020 21:00:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <721b8d01-5d7e-09c6-5f86-705130ab31a9@gmail.com> X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gMjAyMC84LzMgMjA6NTEsIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPiAwMy4wOC4yMDIwIDE0 OjU5LCBZdWVIYWliaW5nINC/0LjRiNC10YI6Cj4+IElmIENPTkZJR19QTSBpcyBub3Qgc2V0LCBn Y2Mgd2FybnM6Cj4+Cj4+IGRyaXZlcnMvc3RhZ2luZy9tZWRpYS90ZWdyYS12ZGUvdmRlLmM6OTE2 OjEyOgo+PiAgd2FybmluZzogJ3RlZ3JhX3ZkZV9ydW50aW1lX3N1c3BlbmQnIGRlZmluZWQgYnV0 IG5vdCB1c2VkIFstV3VudXNlZC1mdW5jdGlvbl0KPj4KPj4gTWFrZSBpdCBfX21heWJlX3VudXNl ZCB0byBmaXggdGhpcy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFpYmlu Z0BodWF3ZWkuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvc3RhZ2luZy9tZWRpYS90ZWdyYS12ZGUv dmRlLmMgfCAyICstCj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS90ZWdyYS12ZGUv dmRlLmMgYi9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvdGVncmEtdmRlL3ZkZS5jCj4+IGluZGV4IGEz YzI0ZDk2ZDViOS4uMmQwNDNkNTE4ZWVmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcv bWVkaWEvdGVncmEtdmRlL3ZkZS5jCj4+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS90ZWdy YS12ZGUvdmRlLmMKPj4gQEAgLTkxMyw3ICs5MTMsNyBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgdGVn cmFfdmRlX2lzcihpbnQgaXJxLCB2b2lkICpkYXRhKQo+PiAgCXJldHVybiBJUlFfSEFORExFRDsK Pj4gIH0KPj4gIAo+PiAtc3RhdGljIGludCB0ZWdyYV92ZGVfcnVudGltZV9zdXNwZW5kKHN0cnVj dCBkZXZpY2UgKmRldikKPj4gK3N0YXRpYyBfX21heWJlX3VudXNlZCBpbnQgdGVncmFfdmRlX3J1 bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4+ICB7Cj4+ICAJc3RydWN0IHRlZ3Jh X3ZkZSAqdmRlID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4+ICAJaW50IGVycjsKPj4KPiAKPiBI ZWxsbyBZdWUsCj4gCj4gU2hvdWxkbid0IHRoZSB0ZWdyYV92ZGVfcnVudGltZV9yZXN1bWUoKSBi ZSBtYXJrZWQgYXMgd2VsbD8KCk5vLCB0ZWdyYV92ZGVfcnVudGltZV9yZXN1bWUoKSBhbHdheXMg YmUgY2FsbGVkIGJ5IHRlZ3JhX3ZkZV9zaHV0ZG93bigpLgoKPiAKPiAuCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QK ZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVy cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK