From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbeECHNI (ORCPT ); Thu, 3 May 2018 03:13:08 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:49832 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751961AbeECHNE (ORCPT ); Thu, 3 May 2018 03:13:04 -0400 Subject: Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff To: Jan Kiszka , Bjorn Helgaas , Linux Kernel Mailing List , , References: CC: Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Will Deacon From: Vladimir Zapolskiy Message-ID: Date: Thu, 3 May 2018 10:12:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.87] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan, On 04/30/2018 08:48 AM, Jan Kiszka wrote: > Changes in v2: > - patch 1: commit message reworking as suggested by Lorenzo > - patch 3-6: split-up as suggested by Bjorn > - patch 8: new > - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than > allowing manual choice, as suggested by Lorenzo > > This primarily enables to unbind the generic PCI host controller without > leaving lots of memory leaks behind. A previous proposal patch 5 was > rejected because of those issues [1]. > > The fixes have been validated in the Jailhouse setup, where we add and > remove a virtual PCI host controller on hypervisor activation/ > deactivation, with the help of kmemleak. by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), so I can give you a number of review tags. FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ should be changed to obsoleted/deprecated/rejected. -- With best wishes, Vladimir From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff To: Jan Kiszka , Bjorn Helgaas , Linux Kernel Mailing List , , References: From: Vladimir Zapolskiy Message-ID: Date: Thu, 3 May 2018 10:12:54 +0300 MIME-Version: 1.0 In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Joao Pinto , Will Deacon , Lorenzo Pieralisi Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Jan, On 04/30/2018 08:48 AM, Jan Kiszka wrote: > Changes in v2: > - patch 1: commit message reworking as suggested by Lorenzo > - patch 3-6: split-up as suggested by Bjorn > - patch 8: new > - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than > allowing manual choice, as suggested by Lorenzo > > This primarily enables to unbind the generic PCI host controller without > leaving lots of memory leaks behind. A previous proposal patch 5 was > rejected because of those issues [1]. > > The fixes have been validated in the Jailhouse setup, where we add and > remove a virtual PCI host controller on hypervisor activation/ > deactivation, with the help of kmemleak. by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), so I can give you a number of review tags. FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ should be changed to obsoleted/deprecated/rejected. -- With best wishes, Vladimir _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: vladimir_zapolskiy@mentor.com (Vladimir Zapolskiy) Date: Thu, 3 May 2018 10:12:54 +0300 Subject: [PATCH v2 00/10] PCI: leak fixes, removable generic PCI host, assorted stuff In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jan, On 04/30/2018 08:48 AM, Jan Kiszka wrote: > Changes in v2: > - patch 1: commit message reworking as suggested by Lorenzo > - patch 3-6: split-up as suggested by Bjorn > - patch 8: new > - patch 10: select PCI_DOMAINS from PCI_HOST_GENERIC, rather than > allowing manual choice, as suggested by Lorenzo > > This primarily enables to unbind the generic PCI host controller without > leaving lots of memory leaks behind. A previous proposal patch 5 was > rejected because of those issues [1]. > > The fixes have been validated in the Jailhouse setup, where we add and > remove a virtual PCI host controller on hypervisor activation/ > deactivation, with the help of kmemleak. by chance I was looking into a memleak in of_pci_get_host_bridge_resources(), so I can give you a number of review tags. FWIW the state of unfixably broken https://patchwork.kernel.org/patch/9662893/ should be changed to obsoleted/deprecated/rejected. -- With best wishes, Vladimir