All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Fazio <vfazio@xes-inc.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 01/10 v3] core/pkg-infra: prepare for alternate default source archives
Date: Thu, 7 Jan 2021 13:52:50 -0600	[thread overview]
Message-ID: <e1753e66-c11e-2b9d-e350-b1e50ca6f7fc@xes-inc.com> (raw)
In-Reply-To: <7d52ccdb9dd1b0e56d1a3720e649f52693ee1c68.1609239666.git.yann.morin.1998@free.fr>



On 12/29/20 5:01 AM, Yann E. MORIN wrote:
> The .tar.gz default extension is historical, and we initially used
> to only fetch tarballs from remote sites.
> 
> When we introduced downloads from VCS repositories, we kept that
> extension, and kept compressing with gz, by lack of good reason to
> switch to some other compression scheme.
> 
> However, nowadays, we will want to change the way we construct the
> tarballs we generate from VCS. This will de facto change the hashes
> of those tarballs.
> 
> So we will want that the archives we generate do not clash with the
> existing ones, so we need another filename. Thus, we need a way to
> be able to use a different extension when we generate archives from
> VCS.
> 
> Note that we do not need to play the host-defaults-to-target-value
> dance we do for the _SOURCE variable, because this is a purely internal
> variable, not exposed to packages, and as such, is not documented.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Vincent Fazio <vfazio@xes-inc.com>
> ---
>   package/pkg-generic.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 621fb91424..6a9389f1b5 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -514,11 +514,12 @@ ifneq ($$($(2)_OVERRIDE_SRCDIR),)
>   $(2)_VERSION = custom
>   endif
>   
> +$(2)_SOURCE_EXT = .tar.gz
>   ifndef $(2)_SOURCE
>    ifdef $(3)_SOURCE
>     $(2)_SOURCE = $$($(3)_SOURCE)
>    else ifdef $(2)_VERSION
> -  $(2)_SOURCE			?= $$($(2)_BASENAME_RAW).tar.gz
> +  $(2)_SOURCE			?= $$($(2)_BASENAME_RAW)$$($(2)_SOURCE_EXT)
>    endif
>   endif
>   
> 

Reviewed-by: Vincent Fazio <vfazio@xes-inc.com>

-- 
Vincent Fazio
Embedded Software Engineer - Linux
Extreme Engineering Solutions, Inc
http://www.xes-inc.com

  parent reply	other threads:[~2021-01-07 19:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 11:01 [Buildroot] [PATCH 00/10 v3] support/download: reproducible archives whatever tar version (branch yem/dl-git-tar-pax-2) Yann E. MORIN
2020-12-29 11:01 ` [Buildroot] [PATCH 01/10 v3] core/pkg-infra: prepare for alternate default source archives Yann E. MORIN
2021-01-05 21:54   ` Arnout Vandecappelle
2021-01-07 19:52   ` Vincent Fazio [this message]
2020-12-29 11:01 ` [Buildroot] [PATCH 02/10 v3] core/pkg-infra: allow per site-method sub-version strings Yann E. MORIN
2021-01-05 21:58   ` Arnout Vandecappelle
2021-01-07 19:52   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 03/10 v3] support/download: add helper to generate a reproducible archive Yann E. MORIN
2020-12-29 14:26   ` Vincent Fazio
2020-12-29 14:37     ` Yann E. MORIN
2021-01-05 22:05   ` Arnout Vandecappelle
2021-01-07 19:50   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 04/10 v3] WIP: support/download: change format of archives generated from git Yann E. MORIN
2021-01-05 22:13   ` Arnout Vandecappelle
2021-01-09 13:45     ` Yann E. MORIN
2021-01-07 19:50   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 05/10 v3] WIP: boot+packages: update hash to new git-tarballs format Yann E. MORIN
2021-01-05 22:30   ` Arnout Vandecappelle
2021-01-09 13:46     ` Yann E. MORIN
2021-01-07 19:47   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 06/10 v3] WIP: support/testing: update git-hash checks with new archive format Yann E. MORIN
2021-01-05 22:32   ` Arnout Vandecappelle
2021-01-09 11:16     ` Yann E. MORIN
2021-01-07 19:46   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 07/10 v3] support/download: cleanup svn backend Yann E. MORIN
2021-01-05 22:33   ` Arnout Vandecappelle
2021-01-07 19:42   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 08/10 v3] support/download: change format of archives generated from svn Yann E. MORIN
2021-01-05 22:38   ` Arnout Vandecappelle
2021-01-07 19:44   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 09/10 v3] support/dependencies: drop check for maximal tar version Yann E. MORIN
2021-01-05 22:41   ` Arnout Vandecappelle
2021-01-07 19:40   ` Vincent Fazio
2020-12-29 11:01 ` [Buildroot] [PATCH 10/10 v3] package/tar: drop specific version for host variant Yann E. MORIN
2021-01-05 22:46   ` Arnout Vandecappelle
2021-01-07 19:40   ` Vincent Fazio
2020-12-29 13:09 ` [Buildroot] [PATCH 00/10 v3] support/download: reproducible archives whatever tar version (branch yem/dl-git-tar-pax-2) Thomas Petazzoni
2020-12-29 13:46   ` Yann E. MORIN
2020-12-29 14:15     ` Thomas Petazzoni
2020-12-29 14:25       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1753e66-c11e-2b9d-e350-b1e50ca6f7fc@xes-inc.com \
    --to=vfazio@xes-inc.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.