From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1C6C433FE for ; Tue, 21 Sep 2021 07:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55E3B61131 for ; Tue, 21 Sep 2021 07:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbhIUH3O (ORCPT ); Tue, 21 Sep 2021 03:29:14 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:32908 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbhIUH3N (ORCPT ); Tue, 21 Sep 2021 03:29:13 -0400 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1A44F3FE01 for ; Tue, 21 Sep 2021 07:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632209265; bh=i7xVOY9cswgNsb9rWd2OfLK5tguMPWFz/JQqL1RwXvg=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=AgJl9KCOrfjxEYR9IExFDwkbVGoeNochyMesGk5jn9AFZG/Csv10yzqGPTdCM++cY oLhM4xgd2tWQUMCC1JGbi5ZYogHufqt06DwFj2Ol5k256uaD9bur/tTI8g4q7LKZM2 DTz+XlrQWfyBiHQmumW/PxLv7BSHm+JcvEeUgKGdhkoDnHYEJTrpLXw6mW+KUBPQcI qgTPPuZ3TQZYHmbb/iPdKj7bcZ8c9HUeveISmlZ+SQOCP7TU1INYfhfo2N+FAEgxHl 1bbDV9RUWoQl9vkYBqNjfIOhjuAuUGErUM0QcZAz5UGjb0kYv8QngH4g7XJYEraZ8i FPnWPEKsf8i4A== Received: by mail-wr1-f71.google.com with SMTP id m18-20020adfe952000000b0015b0aa32fd6so8047975wrn.12 for ; Tue, 21 Sep 2021 00:27:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i7xVOY9cswgNsb9rWd2OfLK5tguMPWFz/JQqL1RwXvg=; b=3nVnkvCPMbc/gDO4/ZLtJD7dBVdytlnxBoCHZUwshbAc3NnJ5tqHeP0TnZscNHpr0B 1vu9fu3j5tJ02A9Kw/qrEOLy0j0RUwmmBSPqhW+Ufbab4G+N/dOrkwhbt3E5guEZ7Zxu UWza9NBRIMh+Xn6AmB6TakiJ6TnVeS5y3fF8XeWqKL1+kSHYaCIZ3hQtwmGAp9/6Nbzh NFoKIpeULcZYKo2nutRu06lwRJkwEhfVfOfe1bReorfs7OzUyop4ez7lFH2izPg5iJk6 4UDqijQDsZYQqQUCFA0g0qAEd2wzONz5Tt6gOUqcdUNpak3coLv8kLhqrPCnZv5dG/1j mEQg== X-Gm-Message-State: AOAM530UTQR8kL4wLGQbLwp+ETDXXxlWITs7NCfmmA34sVYdPhc4CQJy AP1hGOtj1xnK/W+erBwwKeNeXx+OadfcFMmjnU1TSA12CVu8bS8k71hGesdwD0POUvUfKkYGN8Z WF5ikgscvC36btj5IQG5OtYcQobMtmxv8LTBEClk= X-Received: by 2002:adf:fe0b:: with SMTP id n11mr33312234wrr.371.1632209264349; Tue, 21 Sep 2021 00:27:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzil+vY8RVd7ISnKg7wzJr13+3UggzlkbmenwjowhYp7j04/Gvh/nntwfWnHjrLAQD5yVbfiQ== X-Received: by 2002:adf:fe0b:: with SMTP id n11mr33312212wrr.371.1632209264162; Tue, 21 Sep 2021 00:27:44 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id c14sm12634040wrd.50.2021.09.21.00.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:27:43 -0700 (PDT) Subject: Re: [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS default config logic To: Will McVicker , Catalin Marinas , Will Deacon , Tomasz Figa , Sylwester Nawrocki , Linus Walleij Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-4-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: Date: Tue, 21 Sep 2021 09:27:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-4-willmcvicker@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 20/09/2021 21:03, Will McVicker wrote: > Switching the default config logic of PINCTRL_EXYNOS to use "default > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select the config. > This gives vendors the flexibility to disable the config or modularize > it in the presence of a generic kernel. Reasoning is incorrect. This is an essential driver which CANNOT be disabled for any kernel having ARCH_EXYNOS or ARCH_S5PV210. You are trying to prepare it for some out-of-tree code? Please, upstream your code instead. > > Verified this change doesn't effect the .config. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 1 - > drivers/pinctrl/samsung/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 6a006490c9b9..a884e5da8b0f 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -93,7 +93,6 @@ config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > - select PINCTRL_EXYNOS > select PM_GENERIC_DOMAINS if PM > help > This enables support for ARMv8 based Samsung Exynos SoC family. > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > index dfd805e76862..483acb8ac1f6 100644 > --- a/drivers/pinctrl/samsung/Kconfig > +++ b/drivers/pinctrl/samsung/Kconfig > @@ -12,6 +12,7 @@ config PINCTRL_EXYNOS > bool "Pinctrl common driver part for Samsung Exynos SoCs" > depends on OF_GPIO > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > + default y if ARCH_EXYNOS default ARCH_EXYNOS || ARCH_S5PV210 ... and update all mach Kconfigs. > select PINCTRL_SAMSUNG > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08198C433EF for ; Tue, 21 Sep 2021 07:30:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFF6961100 for ; Tue, 21 Sep 2021 07:30:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFF6961100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=pIe+CkUJO10qBZLPL0Hh+YxS89l5wnbtUCwPitSFceo=; b=MziQ3psLmb0YRPnNEYesJ2CMxJ RQGdKKpgWFuhJ32vO+D9TXlnreg5u+MSqWSxluQjls3RIN1ewENN1lfDokWm7gOZF/RjtSxwwgNgf 3FNhhExYnk+zVeihChvT+5G1vZ0Jbn4XEcvW6Qs/uTImXIGp4X2Y1etyKD2IJQrUU6NrtZnLPeOHt CURdAajJYbje237/Vp9KKF75Bvm3KYqMZ/dvJlWF62QpSLUq6wfI7ehWpEG7zcCk1UnBYwTGxw3U4 zc3GZZf8ajiyrGJDtX/y69FwmFB6Y77bGzLDfp6CZ4miO7t0/bQHdjohWrgaadrwNt/rTFSe+gh2M 85DzTKDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSaBy-003oJQ-5e; Tue, 21 Sep 2021 07:27:50 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSaBt-003oIR-UP for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 07:27:47 +0000 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id C09233FE05 for ; Tue, 21 Sep 2021 07:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632209264; bh=i7xVOY9cswgNsb9rWd2OfLK5tguMPWFz/JQqL1RwXvg=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=fpu66Nr+o/an5gLpapYzzKhFkdKcn5CLfLJOLjXhFkXC98La+veFRIJuYpMkyUeOk Li5ztGQLrIejytIQxIgmqCcrmSqFAxIqqZDSriCTzZdPs4ls4stFnEQZsaqtbX7DmG b3GtpkQOZnsnJ3OuVDb/sb0Zl/Qp/z8KahR4Qog3Kh26+KTditKEjblPb/6KWum4Ug JPmYEHfG/PsPP6dt8CzL6ZaE4OtOpfPkTRkqHCAe5lQCbiRe1V7XZ7sCjq6+zE/wTt ezj/ZUcNGhMJixCw6ZS5AihY6HH7dZ/vCNRTCS+h0nrlyHuF6BRIsm0LTiqMzdwBNO ORxy+jwzpMxXA== Received: by mail-wr1-f72.google.com with SMTP id r7-20020a5d6947000000b0015e0f68a63bso8086582wrw.22 for ; Tue, 21 Sep 2021 00:27:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i7xVOY9cswgNsb9rWd2OfLK5tguMPWFz/JQqL1RwXvg=; b=0ELPgKrbtM+N0n00eJh6f9q/mdeODpT830xqQfaGSFSG2w9wcRyryVE7LT8qh/TnKT l8p0K7trplOL3EVnDCjomKIgndwYRA16U/QP0zuK2864mahRw7dgYoudOPCDwycr/Cue cLLC6MukEE/9hH6oPdTJN4KjimI0FZnm11KG8zxpJ2684l1hvfRQ/gfJH6X2NoE7POiQ +7V/L9F0fpd+NkPCT9jIzmWElcixl9338M8vznlGqSAl9qZY5gqjRdYFBAX8nFfOdciA skNK6wrM9CdDapTfK6jkI0adJNGNeBV4IaazoxyWgqY2rpV9Y77GM52ENxhwF3Z8gXpQ rbKg== X-Gm-Message-State: AOAM532LiexCPZW9cpbRooIObYXAVUd57prWOD5+5/nwwi9peC5quwNX 2y1I6Sh/KMjOf/snNjEBoKNL82Riu3NU899hvmiqnWg4m/FfIOUZ25RcpT1cky7UrHRf1YUL6RN zthLSFFktKsks1C2DFjtJHfOZBS29YK/9lcPytWqhK1OvGTUvPZbK X-Received: by 2002:adf:fe0b:: with SMTP id n11mr33312228wrr.371.1632209264349; Tue, 21 Sep 2021 00:27:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzil+vY8RVd7ISnKg7wzJr13+3UggzlkbmenwjowhYp7j04/Gvh/nntwfWnHjrLAQD5yVbfiQ== X-Received: by 2002:adf:fe0b:: with SMTP id n11mr33312212wrr.371.1632209264162; Tue, 21 Sep 2021 00:27:44 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id c14sm12634040wrd.50.2021.09.21.00.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:27:43 -0700 (PDT) Subject: Re: [PATCH v1 3/4] pinctrl: samsung: change PINCTRL_EXYNOS default config logic To: Will McVicker , Catalin Marinas , Will Deacon , Tomasz Figa , Sylwester Nawrocki , Linus Walleij Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-4-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: Date: Tue, 21 Sep 2021 09:27:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-4-willmcvicker@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_002746_173297_1D348E02 X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/09/2021 21:03, Will McVicker wrote: > Switching the default config logic of PINCTRL_EXYNOS to use "default > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select the config. > This gives vendors the flexibility to disable the config or modularize > it in the presence of a generic kernel. Reasoning is incorrect. This is an essential driver which CANNOT be disabled for any kernel having ARCH_EXYNOS or ARCH_S5PV210. You are trying to prepare it for some out-of-tree code? Please, upstream your code instead. > > Verified this change doesn't effect the .config. > > Signed-off-by: Will McVicker > --- > arch/arm64/Kconfig.platforms | 1 - > drivers/pinctrl/samsung/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 6a006490c9b9..a884e5da8b0f 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -93,7 +93,6 @@ config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > - select PINCTRL_EXYNOS > select PM_GENERIC_DOMAINS if PM > help > This enables support for ARMv8 based Samsung Exynos SoC family. > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > index dfd805e76862..483acb8ac1f6 100644 > --- a/drivers/pinctrl/samsung/Kconfig > +++ b/drivers/pinctrl/samsung/Kconfig > @@ -12,6 +12,7 @@ config PINCTRL_EXYNOS > bool "Pinctrl common driver part for Samsung Exynos SoCs" > depends on OF_GPIO > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > + default y if ARCH_EXYNOS default ARCH_EXYNOS || ARCH_S5PV210 ... and update all mach Kconfigs. > select PINCTRL_SAMSUNG > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) > select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel