* [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()
@ 2022-05-04 3:21 Zeng Guang
2022-05-04 19:12 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Zeng Guang @ 2022-05-04 3:21 UTC (permalink / raw)
To: Paolo Bonzini, kvm
Cc: Robert Hu, Gao Chao, Zeng Guang, Chen Farrah, Wei Danmei
Change function claim to static.
Report warning: no previous prototype for 'vmx_get_pid_table_order'
[-Wmissing-prototypes].
Fixes: 101c99f6506d ("KVM: VMX: enable IPI virtualization")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Zeng Guang <guang.zeng@intel.com>
---
Paolo, could you please merge this fix into commit 101c99f6506d ("KVM:
VMX: enable IPI virtualization") in kvm/queue? Sorry for such mistake.
arch/x86/kvm/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index bb09fc9a7e55..2065babb2c9c 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -4402,7 +4402,7 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx)
return exec_control;
}
-int vmx_get_pid_table_order(struct kvm *kvm)
+static int vmx_get_pid_table_order(struct kvm *kvm)
{
return get_order(kvm->arch.max_vcpu_ids * sizeof(*to_kvm_vmx(kvm)->pid_table));
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order()
2022-05-04 3:21 [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order() Zeng Guang
@ 2022-05-04 19:12 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2022-05-04 19:12 UTC (permalink / raw)
To: Zeng Guang, kvm; +Cc: Robert Hu, Gao Chao, Chen Farrah, Wei Danmei
On 5/4/22 05:21, Zeng Guang wrote:
> Change function claim to static.
> Report warning: no previous prototype for 'vmx_get_pid_table_order'
> [-Wmissing-prototypes].
>
> Fixes: 101c99f6506d ("KVM: VMX: enable IPI virtualization")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Zeng Guang <guang.zeng@intel.com>
> ---
> Paolo, could you please merge this fix into commit 101c99f6506d ("KVM:
> VMX: enable IPI virtualization") in kvm/queue? Sorry for such mistake.
>
> arch/x86/kvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index bb09fc9a7e55..2065babb2c9c 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -4402,7 +4402,7 @@ static u32 vmx_secondary_exec_control(struct vcpu_vmx *vmx)
> return exec_control;
> }
>
> -int vmx_get_pid_table_order(struct kvm *kvm)
> +static int vmx_get_pid_table_order(struct kvm *kvm)
> {
> return get_order(kvm->arch.max_vcpu_ids * sizeof(*to_kvm_vmx(kvm)->pid_table));
> }
Yup, done.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-04 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 3:21 [PATCH] KVM: VMX: Fix build error on claim of vmx_get_pid_table_order() Zeng Guang
2022-05-04 19:12 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.