From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn9GW-0005TG-LN for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:02:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn9GU-0003lp-Eo for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:02:35 -0400 References: <1474558931-8968-1-git-send-email-kwolf@redhat.com> <1474558931-8968-4-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: Date: Thu, 22 Sep 2016 14:02:26 -0500 MIME-Version: 1.0 In-Reply-To: <1474558931-8968-4-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OPGChFql9rN13UNSG4v5ats8KSG5hw6Fs" Subject: Re: [Qemu-devel] [PATCH 3/3] doc: Document driver-specific -blockdev options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, mreitz@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OPGChFql9rN13UNSG4v5ats8KSG5hw6Fs From: Eric Blake To: Kevin Wolf , qemu-block@nongnu.org Cc: armbru@redhat.com, mreitz@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH 3/3] doc: Document driver-specific -blockdev options References: <1474558931-8968-1-git-send-email-kwolf@redhat.com> <1474558931-8968-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1474558931-8968-4-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2016 10:42 AM, Kevin Wolf wrote: > This documents the driver-specific options for the raw, qcow2 and file > block drivers for the man page. For everything else, we refer to the > QAPI documentation. >=20 > Signed-off-by: Kevin Wolf > --- > qemu-options.hx | 62 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 62 insertions(+) >=20 > =20 > +@item Driver-specific options for @code{file} > +@table @code > +@item filename > +The path to the image file in the local filesystem > +@item aio > +Specifies the AIO backend (threads/native, default: threads) > +@end table > + > +@item Driver-specific options for @code{raw} > +@table @code > +@item file > +Reference to or definition of the data source block device > +@end table Would an example command line make things any easier to read, for giving hints on how many dotted names are needed as you describe further nesting levels in relation to the top level? > +@item cache-clean-interval > +Clean unused entries in the L2 and refcount caches. The interval is in= seconds. > +The default value is 0 and it disables this feature. > + > +@item pass-discard-request > +Whether discard requests to the qcow2 device should be forwarded to th= e data > +source (on/off) > + > +@item pass-discard-snapshot > +Whether discard requests for the data source should be issued when a s= napshot > +operation (e.g. deleting a snapshot) frees clusters in the qcow2 file = (on/off) > + > +@item pass-discard-other > +Whether discard requests for the data source should be issued on other= > +occasions where a cluster gets freed (on/off) I like that cache-clean-interval mentioned a default; should these other lines do likewise? At any rate, those ideas can be followups if desired, as this patch is strictly an improvement. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OPGChFql9rN13UNSG4v5ats8KSG5hw6Fs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX5CrCAAoJEKeha0olJ0NqCCEIAJdfEG+UhmCjryuGKpOsQokO OjV2WWDkYHjLs/SBcGkoJGhfqDxrVss0iwLB0FuB77jOZOuVxsto6jqOMtXzdQlj AdAcEkTWULMWGDSeUz8GTcxLnlu+zQboICHXKND0A9ZRB9TIVapgMo3qyhbO2bfT rheBwoopyjKlO2X1E+7mGeAvQNHaltMkllnH3ldvIy4x5a481BeiDdhS19lZutY7 XAYa5TuNBhQLpvUrE1xchrtVwWQhtYZ1EoQKr7PF2+AwY9sKVDahMao5HdsZjiIi ithRV3UZdE2I0qHouzys0JFM0phkHr9KO5O7j+JJoReOPKniYV6DPX+jigs3o8A= =uTdv -----END PGP SIGNATURE----- --OPGChFql9rN13UNSG4v5ats8KSG5hw6Fs--