All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC] am65x_evm_r5: Disable serial output
@ 2020-05-11 19:41 Tom Rini
  2020-05-12  6:05 ` Lokesh Vutla
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2020-05-11 19:41 UTC (permalink / raw)
  To: u-boot

Given limitations on the current implementation of our test framework,
having both am65x_evm_r5 and am65x_evm_a53 have serial output on the
same port confuses the tests.  If we disable serial output in r5 and
disable the SPL tests as well, we can run the rest of the testsuite on
am65x_evm_a53.

Cc: Lokesh Vutla <lokeshvutla@ti.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
For practical reasons this depends on
http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/
to build.  Since this also removes YMODEM support, I assume it breaks a
functional use case, so I'm not sure this is best.  Stephen Warren
suggested a rework to the pytest framework that I haven't had a chance
to try and do yet.
---
 configs/am65x_evm_r5_defconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configs/am65x_evm_r5_defconfig b/configs/am65x_evm_r5_defconfig
index 4fc199e80911..2c61bee4b8bc 100644
--- a/configs/am65x_evm_r5_defconfig
+++ b/configs/am65x_evm_r5_defconfig
@@ -11,7 +11,6 @@ CONFIG_ENV_SIZE=0x20000
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x80000
 CONFIG_DM_GPIO=y
 CONFIG_SPL_MMC_SUPPORT=y
-CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
 CONFIG_SPL_STACK_R_ADDR=0x82000000
 CONFIG_NR_DRAM_BANKS=2
@@ -41,7 +40,6 @@ CONFIG_SPL_REMOTEPROC=y
 # CONFIG_SPL_SPI_FLASH_TINY is not set
 CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y
 CONFIG_SPL_SPI_LOAD=y
-CONFIG_SPL_YMODEM_SUPPORT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_ASKENV=y
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [RFC] am65x_evm_r5: Disable serial output
  2020-05-11 19:41 [RFC] am65x_evm_r5: Disable serial output Tom Rini
@ 2020-05-12  6:05 ` Lokesh Vutla
  2020-05-12 12:08   ` Tom Rini
  0 siblings, 1 reply; 3+ messages in thread
From: Lokesh Vutla @ 2020-05-12  6:05 UTC (permalink / raw)
  To: u-boot

Hi Tom,

On 12/05/20 1:11 AM, Tom Rini wrote:
> Given limitations on the current implementation of our test framework,
> having both am65x_evm_r5 and am65x_evm_a53 have serial output on the
> same port confuses the tests.  If we disable serial output in r5 and
> disable the SPL tests as well, we can run the rest of the testsuite on
> am65x_evm_a53.
> 
> Cc: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> For practical reasons this depends on
> http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/
> to build.  Since this also removes YMODEM support, I assume it breaks a

Right this breaks UART boot which is very useful for remote testing of U-Boot.
This cannot be compromised.

May be I am missing something, Can you explain what is the problem here?

Thanks and regards,
Lokesh

> functional use case, so I'm not sure this is best.  Stephen Warren
> suggested a rework to the pytest framework that I haven't had a chance
> to try and do yet.
> ---
>  configs/am65x_evm_r5_defconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/configs/am65x_evm_r5_defconfig b/configs/am65x_evm_r5_defconfig
> index 4fc199e80911..2c61bee4b8bc 100644
> --- a/configs/am65x_evm_r5_defconfig
> +++ b/configs/am65x_evm_r5_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SIZE=0x20000
>  CONFIG_SYS_SPI_U_BOOT_OFFS=0x80000
>  CONFIG_DM_GPIO=y
>  CONFIG_SPL_MMC_SUPPORT=y
> -CONFIG_SPL_SERIAL_SUPPORT=y
>  CONFIG_SPL_DRIVERS_MISC_SUPPORT=y
>  CONFIG_SPL_STACK_R_ADDR=0x82000000
>  CONFIG_NR_DRAM_BANKS=2
> @@ -41,7 +40,6 @@ CONFIG_SPL_REMOTEPROC=y
>  # CONFIG_SPL_SPI_FLASH_TINY is not set
>  CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=y
>  CONFIG_SPL_SPI_LOAD=y
> -CONFIG_SPL_YMODEM_SUPPORT=y
>  CONFIG_HUSH_PARSER=y
>  CONFIG_CMD_BOOTZ=y
>  CONFIG_CMD_ASKENV=y
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RFC] am65x_evm_r5: Disable serial output
  2020-05-12  6:05 ` Lokesh Vutla
@ 2020-05-12 12:08   ` Tom Rini
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2020-05-12 12:08 UTC (permalink / raw)
  To: u-boot

On Tue, May 12, 2020 at 11:35:06AM +0530, Lokesh Vutla wrote:
> Hi Tom,
> 
> On 12/05/20 1:11 AM, Tom Rini wrote:
> > Given limitations on the current implementation of our test framework,
> > having both am65x_evm_r5 and am65x_evm_a53 have serial output on the
> > same port confuses the tests.  If we disable serial output in r5 and
> > disable the SPL tests as well, we can run the rest of the testsuite on
> > am65x_evm_a53.
> > 
> > Cc: Lokesh Vutla <lokeshvutla@ti.com>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > For practical reasons this depends on
> > http://patchwork.ozlabs.org/project/uboot/patch/20200507230810.21476-1-samuel at sholland.org/
> > to build.  Since this also removes YMODEM support, I assume it breaks a
> 
> Right this breaks UART boot which is very useful for remote testing of U-Boot.
> This cannot be compromised.

I figured you might be using that in the lab there (I've got a WiFi SD
card for mine again).

> May be I am missing something, Can you explain what is the problem here?

See https://lists.denx.de/pipermail/u-boot/2020-May/410921.html

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200512/2119f7ff/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-12 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 19:41 [RFC] am65x_evm_r5: Disable serial output Tom Rini
2020-05-12  6:05 ` Lokesh Vutla
2020-05-12 12:08   ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.