From: Benson Leung <bleung@chromium.org>
To: Gwendal Grignou <gwendal@chromium.org>, bleung@chromium.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform: chrome: Add Tablet Switch ACPI driver
Date: Mon, 30 Jan 2017 15:36:02 -0800 [thread overview]
Message-ID: <e18c9fba-393e-b075-c518-c88b9e57dc18@google.com> (raw)
In-Reply-To: <20170130193020.29623-1-gwendal@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 1195 bytes --]
Hi Gwendal,
Overall, this looks good to me, but please make sure this is based on
upstream, and not the ChromeOS kernel trees.
On 01/30/2017 11:30 AM, Gwendal Grignou wrote:
> Add a kernel driver for GOOG0006, an ACPI driver reporting an event when
> the tablet switch status changes.
>
> On an ACPI based convertible chromebook check evtest display tablet mode
> switch changes:
> Available devices:
> ..
> /dev/input/event3: Tablet Mode Switch
> ..
> Testing ... (interrupt to exit)
> Event: time 1484879712.604360, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 1
> Event: time 1484879712.604360, -------------- SYN_REPORT ------------
> Event: time 1484879715.132228, type 5 (EV_SW), code 1 (SW_TABLET_MODE),
> value 0
> Event: time 1484879715.132228, -------------- SYN_REPORT ------------
> ...
> Check state is updated at resume time when different from suspend time.
>
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2
Strip off the gerrit Change-Id: as it is meaningless upstream.
Thanks!
Benson
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2017-01-30 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 23:39 [PATCH] platform: chrome: Add Tablet Switch ACPI driver Gwendal Grignou
2017-01-28 0:30 ` Benson Leung
2017-01-30 19:30 ` [PATCH v2] " Gwendal Grignou
2017-01-30 23:36 ` Benson Leung [this message]
2017-01-30 23:47 ` [PATCH v3] " Gwendal Grignou
2017-02-01 18:30 ` Benson Leung
2018-05-23 18:19 ` [v3] " Guenter Roeck
2018-05-23 18:24 ` Benson Leung
2018-05-24 0:00 ` [PATCH v3] " Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e18c9fba-393e-b075-c518-c88b9e57dc18@google.com \
--to=bleung@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.