From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbdBSPbC (ORCPT ); Sun, 19 Feb 2017 10:31:02 -0500 Received: from ste-pvt-msa1.bahnhof.se ([213.80.101.70]:62108 "EHLO ste-pvt-msa1.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844AbdBSPbB (ORCPT ); Sun, 19 Feb 2017 10:31:01 -0500 X-Greylist: delayed 575 seconds by postgrey-1.27 at vger.kernel.org; Sun, 19 Feb 2017 10:31:00 EST Subject: Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes To: Daniel Vetter , Intel Graphics Development , DRI Development References: <20161028081050.1042-1-daniel.vetter@ffwll.ch> <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> Cc: Daniel Vetter , Dave Airlie , "linux-kernel@vger.kernel.org" X-Priority: 1 (Highest) From: Thomas Hellstrom Message-ID: Date: Sun, 19 Feb 2017 16:21:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So I think we need a quick revert of this commit or a quick stable follow-up to unbreak things on our side. /Thomas On 02/19/2017 03:54 PM, Thomas Hellstrom wrote: > Hi! > > This patch breaks the vmwgfx resolutionKMS daemon which opens a control > node to tell DRM about the monitor layout... > > /Thomas > > > On 10/28/2016 10:10 AM, Daniel Vetter wrote: >> Looking at the ioctl permission checks I noticed that it's impossible >> to import gem buffers into a control nodes, and fd2handle/handle2fd >> also don't work, so no joy with dma-bufs. >> >> The only way to do anything with a control node is by drawing stuff >> into a dumb buffer and displaying that. I suspect control nodes are an >> entirely unused thing, and a cursory check shows that there does not >> seem to be any callers of drmOpenControl nor of the other drmOpen >> functions using DRM_MODE_CONTROL. >> >> Since I don't like dead uabi, let's remove it. But since this would be >> a really big change I think it's better to start out small by simply >> not registering anything. We can garbage-collect the dead code later >> on, once we're sure it's really not used anywhere. >> >> Signed-off-by: Daniel Vetter >> --- >> drivers/gpu/drm/drm_drv.c | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c >> index 6efdba4993fc..f085e28ffc6f 100644 >> --- a/drivers/gpu/drm/drm_drv.c >> +++ b/drivers/gpu/drm/drm_drv.c >> @@ -517,12 +517,6 @@ int drm_dev_init(struct drm_device *dev, >> goto err_free; >> } >> >> - if (drm_core_check_feature(dev, DRIVER_MODESET)) { >> - ret = drm_minor_alloc(dev, DRM_MINOR_CONTROL); >> - if (ret) >> - goto err_minors; >> - } >> - >> if (drm_core_check_feature(dev, DRIVER_RENDER)) { >> ret = drm_minor_alloc(dev, DRM_MINOR_RENDER); >> if (ret) > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes Date: Sun, 19 Feb 2017 16:21:14 +0100 Message-ID: References: <20161028081050.1042-1-daniel.vetter@ffwll.ch> <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development , DRI Development Cc: Daniel Vetter , "linux-kernel@vger.kernel.org" , Dave Airlie List-Id: dri-devel@lists.freedesktop.org U28gSSB0aGluayB3ZSBuZWVkIGEgcXVpY2sgcmV2ZXJ0IG9mIHRoaXMgY29tbWl0IG9yIGEgcXVp Y2sgc3RhYmxlCmZvbGxvdy11cCB0byB1bmJyZWFrIHRoaW5ncyBvbiBvdXIgc2lkZS4KCi9UaG9t YXMKCgpPbiAwMi8xOS8yMDE3IDAzOjU0IFBNLCBUaG9tYXMgSGVsbHN0cm9tIHdyb3RlOgo+IEhp IQo+Cj4gVGhpcyBwYXRjaCBicmVha3MgdGhlIHZtd2dmeCByZXNvbHV0aW9uS01TIGRhZW1vbiB3 aGljaCBvcGVucyBhIGNvbnRyb2wKPiBub2RlIHRvIHRlbGwgRFJNIGFib3V0IHRoZSBtb25pdG9y IGxheW91dC4uLgo+Cj4gL1Rob21hcwo+Cj4KPiBPbiAxMC8yOC8yMDE2IDEwOjEwIEFNLCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+PiBMb29raW5nIGF0IHRoZSBpb2N0bCBwZXJtaXNzaW9uIGNoZWNr cyBJIG5vdGljZWQgdGhhdCBpdCdzIGltcG9zc2libGUKPj4gdG8gaW1wb3J0IGdlbSBidWZmZXJz IGludG8gYSBjb250cm9sIG5vZGVzLCBhbmQgZmQyaGFuZGxlL2hhbmRsZTJmZAo+PiBhbHNvIGRv bid0IHdvcmssIHNvIG5vIGpveSB3aXRoIGRtYS1idWZzLgo+Pgo+PiBUaGUgb25seSB3YXkgdG8g ZG8gYW55dGhpbmcgd2l0aCBhIGNvbnRyb2wgbm9kZSBpcyBieSBkcmF3aW5nIHN0dWZmCj4+IGlu dG8gYSBkdW1iIGJ1ZmZlciBhbmQgZGlzcGxheWluZyB0aGF0LiBJIHN1c3BlY3QgY29udHJvbCBu b2RlcyBhcmUgYW4KPj4gZW50aXJlbHkgdW51c2VkIHRoaW5nLCBhbmQgYSBjdXJzb3J5IGNoZWNr IHNob3dzIHRoYXQgdGhlcmUgZG9lcyBub3QKPj4gc2VlbSB0byBiZSBhbnkgY2FsbGVycyBvZiBk cm1PcGVuQ29udHJvbCBub3Igb2YgdGhlIG90aGVyIGRybU9wZW4KPj4gZnVuY3Rpb25zIHVzaW5n IERSTV9NT0RFX0NPTlRST0wuCj4+Cj4+IFNpbmNlIEkgZG9uJ3QgbGlrZSBkZWFkIHVhYmksIGxl dCdzIHJlbW92ZSBpdC4gQnV0IHNpbmNlIHRoaXMgd291bGQgYmUKPj4gYSByZWFsbHkgYmlnIGNo YW5nZSBJIHRoaW5rIGl0J3MgYmV0dGVyIHRvIHN0YXJ0IG91dCBzbWFsbCBieSBzaW1wbHkKPj4g bm90IHJlZ2lzdGVyaW5nIGFueXRoaW5nLiBXZSBjYW4gZ2FyYmFnZS1jb2xsZWN0IHRoZSBkZWFk IGNvZGUgbGF0ZXIKPj4gb24sIG9uY2Ugd2UncmUgc3VyZSBpdCdzIHJlYWxseSBub3QgdXNlZCBh bnl3aGVyZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRl ckBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYyB8IDYgLS0t LS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgNiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Rydi5jCj4+ IGluZGV4IDZlZmRiYTQ5OTNmYy4uZjA4NWUyOGZmYzZmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2Rydi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMKPj4g QEAgLTUxNywxMiArNTE3LDYgQEAgaW50IGRybV9kZXZfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LAo+PiAgCQlnb3RvIGVycl9mcmVlOwo+PiAgCX0KPj4gIAo+PiAtCWlmIChkcm1fY29yZV9j aGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKSB7Cj4+IC0JCXJldCA9IGRybV9taW5v cl9hbGxvYyhkZXYsIERSTV9NSU5PUl9DT05UUk9MKTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCWdv dG8gZXJyX21pbm9yczsKPj4gLQl9Cj4+IC0KPj4gIAlpZiAoZHJtX2NvcmVfY2hlY2tfZmVhdHVy ZShkZXYsIERSSVZFUl9SRU5ERVIpKSB7Cj4+ICAJCXJldCA9IGRybV9taW5vcl9hbGxvYyhkZXYs IERSTV9NSU5PUl9SRU5ERVIpOwo+PiAgCQlpZiAocmV0KQo+Cj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==